4a53ebe1ed
* make-pascal_language-print_type-handle-varstring-nul.patch
- Renable gcc-fortran for SLE-11.
- Use system compiler (gcc 4.3.4) for testing all languages on
SLE-11.
- Maintenance script qa.sh:
* Ignore all fails for SLE-11.
- Maintenance script import-fedora.sh:
* Use %patch -P N instead of deprecated %patchN.
* Drop patch skips:
* gdb-6.5-readline-long-line-crash-test.patch
* gdb-6.7-charsign-test.patch
* gdb-test-ivy-bridge.patch
* gdb-ppc-power7-test.patch
* gdb-6.3-bz140532-ppc-unwinding-test.patch
- Patches added (import from fedora rawhide @ a27201b):
* gdb-bz2196395-debuginfod-legacy-openssl-crash.patch
* gdb-rhbz-2232086-cpp-ify-mapped-symtab.patch
* gdb-rhbz-2232086-generate-dwarf-5-index-consistently.patch
* gdb-rhbz-2232086-generate-gdb-index-consistently.patch
* gdb-rhbz-2232086-reduce-size-of-gdb-index.patch
* gdb-rhbz2232086-refactor-selftest-support.patch
- Patches updated (import from fedora rawhide @ a27201b):
* gdb-6.6-buildid-locate-rpm.patch
* gdb-6.6-buildid-locate.patch
* gdb-fedora-libncursesw.patch
* gdb-rhbz2233961-CVE-2022-4806.patch
* gdb-rhbz2233965-memory-leak.patch
- Patches updated:
* gdb-6.6-buildid-locate-rpm-suse.patch
- Patches deleted (import from fedora rawhide @ a27201b):
* gdb-rhbz1553104-s390x-arch12-test.patch
* gdb-lineno-makeup-test.patch
* gdb-6.3-bz202689-exec-from-pthread-test.patch
* gdb-6.5-bz109921-DW_AT_decl_file-test.patch
* gdb-6.5-ia64-libunwind-leak-test.patch
* gdb-6.5-last-address-space-byte-test.patch
* gdb-6.5-missed-trap-on-step-test.patch
* gdb-6.5-sharedlibrary-path.patch
* gdb-6.7-testsuite-stable-results.patch
* gdb-6.8-bz442765-threaded-exec-test.patch
* gdb-ccache-workaround.patch
* gdb-opcodes-clflushopt-test.patch
* gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch
* gdb-rhbz1350436-type-printers-error.patch
* gdb-rhbz2196395-debuginfod-legacy-openssl-crash.patch
* gdb-rhel5.9-testcase-xlf-var-inside-mod.patch
* gdb-test-pid0-core.patch
- Patches deleted:
* fixup-gdb-rhbz1553104-s390x-arch12-test.patch
* fixup-2-gdb-rhbz1553104-s390x-arch12-test.patch
* fixup-gdb-lineno-makeup-test.patch
* fixup-gdb-6.6-buildid-locate-rpm.patch
- Remove commented out mention of dropped patch
gdb-fix-selftest-fails-with-gdb-build-with-O2-flto.patch.
OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=383
44 lines
1.6 KiB
Diff
44 lines
1.6 KiB
Diff
From f27cc602d85c46b46f5b02d6f584a1d872e098e3 Mon Sep 17 00:00:00 2001
|
|
From: Tom Tromey <tom@tromey.com>
|
|
Date: Wed, 27 Mar 2024 10:34:46 -0600
|
|
Subject: [PATCH] Make pascal_language::print_type handle varstring==nullptr
|
|
|
|
PR gdb/31524 points out a crash when pascal_language::print_type is
|
|
called with varstring==nullptr. This crash is a regression arising
|
|
from the printf/pager rewrite -- that indirectly removed a NULL check
|
|
from gdb's "puts".
|
|
|
|
This patch instead fixes the problem by adding a check to print_type.
|
|
Passing nullptr here seems to be expected in other places (e.g., there
|
|
is a call to type_print like this in expprint.c), and other
|
|
implementations of this method (or related helpers) explicitly check
|
|
for NULL.
|
|
|
|
I didn't write a test case for this because it seemed like overkill
|
|
for a Pascal bug that only occurs with -i=mi. However, if you want
|
|
one, let me know and I will do it.
|
|
|
|
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31524
|
|
Approved-By: John Baldwin <jhb@FreeBSD.org>
|
|
---
|
|
gdb/p-typeprint.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/gdb/p-typeprint.c b/gdb/p-typeprint.c
|
|
index e8542d6845a..68a94a65f64 100644
|
|
--- a/gdb/p-typeprint.c
|
|
+++ b/gdb/p-typeprint.c
|
|
@@ -55,7 +55,8 @@ pascal_language::print_type (struct type *type, const char *varstring,
|
|
type_print_varspec_prefix (type, stream, show, 0, flags);
|
|
}
|
|
/* first the name */
|
|
- gdb_puts (varstring, stream);
|
|
+ if (varstring != nullptr)
|
|
+ gdb_puts (varstring, stream);
|
|
|
|
if ((varstring != NULL && *varstring != '\0')
|
|
&& !(code == TYPE_CODE_FUNC
|
|
--
|
|
2.35.3
|
|
|