diff --git a/geoclue2-rpmlintrc b/geoclue2-rpmlintrc index c4ac20a..fd2928f 100644 --- a/geoclue2-rpmlintrc +++ b/geoclue2-rpmlintrc @@ -1,6 +1,8 @@ +# note: do not use systemd macros for geoclue2.service, they are not meant for dbus unit files. addFilter("W: systemd-service-without-service_del_preun") addFilter("W: systemd-service-without-service_del_postun") addFilter("W: systemd-service-without-service_add_pre") addFilter("W: systemd-service-without-service_add_post") addFilter("W: non-standard-uid /var/lib/srvGeoClue srvGeoClue") - +# This is a dbus activated service, no human should ever call it. +addFilter("W: suse-missing-rclink geoclue") diff --git a/geoclue2.changes b/geoclue2.changes index e5e50ec..6be7236 100644 --- a/geoclue2.changes +++ b/geoclue2.changes @@ -1,3 +1,11 @@ +------------------------------------------------------------------- +Thu Feb 2 21:21:10 UTC 2017 - zaitor@opensuse.org + +- Drop convenience shortcut for rcgeoclue, as this is a dbus + activated service, there is no point in that shortcut, no human + should ever manually call it. Following this, filter warning now + produced via rpmlintrc. + ------------------------------------------------------------------- Fri Jan 27 16:26:11 UTC 2017 - zaitor@opensuse.org diff --git a/geoclue2.spec b/geoclue2.spec index 3e662c4..1b16350 100644 --- a/geoclue2.spec +++ b/geoclue2.spec @@ -90,9 +90,6 @@ make %{?_smp_mflags} V=1 %install make DESTDIR=%{buildroot} install %{?_smp_mflags} install -d %{buildroot}%{_localstatedir}/lib/%{dbus_user} -# Create conveniance shortcut for rcgeoclue -> /usr/sbin/service -mkdir -p %{buildroot}%{_sbindir} -ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rcgeoclue find %{buildroot} -type f -name "*.la" -delete -print # Remove desktop file, we do not build the demos find %{buildroot} -type f -name "geoclue-demo-agent.desktop" -delete -print @@ -130,7 +127,6 @@ getent passwd %{dbus_user} > /dev/null || useradd -r -g nogroup -d %{_localstate %config %{_sysconfdir}/dbus-1/system.d/org.freedesktop.GeoClue2.conf %config %{_sysconfdir}/dbus-1/system.d/org.freedesktop.GeoClue2.Agent.conf %attr(0700,%{dbus_user},root) %{_localstatedir}/lib/%{dbus_user} -%{_sbindir}/rcgeoclue %{_unitdir}/geoclue.service %files -n typelib-1_0-Geoclue-2_0