Accepting request 657015 from home:jengelh:branches:science

factory review output

- Remove devel-static subpackage. There is no reason to ship these.
- Remove .la files. These do not constitute static libs, either.
- Use find -delete rather than expensively calling -exec rm.

OBS-URL: https://build.opensuse.org/request/show/657015
OBS-URL: https://build.opensuse.org/package/show/science/giac?expand=0&rev=5
This commit is contained in:
Dirk Stoecker 2018-12-11 14:54:45 +00:00 committed by Git OBS Bridge
parent 2c18ab8d06
commit e5562ce602
2 changed files with 15 additions and 26 deletions

View File

@ -1,3 +1,10 @@
-------------------------------------------------------------------
Tue Dec 11 00:32:57 UTC 2018 - Jan Engelhardt <jengelh@inai.de>
- Remove devel-static subpackage. There is no reason to ship these.
- Remove .la files. These do not constitute static libs, either.
- Use find -delete rather than expensively calling -exec rm.
-------------------------------------------------------------------
Fri Dec 7 17:47:12 UTC 2018 - Todd R <toddrme2178@gmail.com>

View File

@ -61,7 +61,7 @@ BuildRequires: pkgconfig(ao)
%endif
%description
Free computer algebra system, compatible with existing CAS, as a C++
A computer algebra system, compatible with existing CAS, as a C++
library with various user interfaces (GUI with formal spreadsheet and exact
dynamic geometry, on-line, readline, emacs, texmacs...).
@ -81,7 +81,7 @@ Summary: The core library for %{name}
Group: System/Libraries
%description -n lib%{name}%{soname}
Free computer algebra system, compatible with existing CAS, as a C++
A computer algebra system, compatible with existing CAS, as a C++
library with various user interfaces (GUI with formal spreadsheet and exact
dynamic geometry, on-line, readline, emacs, texmacs...).
@ -97,21 +97,8 @@ Requires: pkgconfig(ao)
Requires: pkgconfig(gsl)
%description devel
Computer algebra system.
This package contains header files and libraries needed to develop
application that use %{name}.
%package devel-static
Summary: Static development files for %{name}
Group: Development/Libraries/C and C++
Requires: %{name}-devel = %{version}
%description devel-static
Computer algebra system.
This package contains static libraries needed to develop
application that use %{name}.
application that use the GIAC computer algebra system.
%package doc
Summary: Documentation for %{name}
@ -119,10 +106,8 @@ Group: Documentation/HTML
BuildArch: noarch
%description doc
Computer algebra system.
This document describes the basic structure and provides information on
usage of %{name}.
usage of giac, a computer algebra system.
%lang_package
@ -130,7 +115,7 @@ usage of %{name}.
%setup -q -n %{name}-%{mainver}
# remove all hidden files
find . -type f -iname '.*' -exec rm -f {} \;
find . -type f -iname '.*' -delete
%build
%configure \
@ -140,6 +125,7 @@ make %{?_smp_mflags}
%install
%make_install
rm -f %{buildroot}/%{_libdir}/*.la
# use the freedesktop standard
rm -rf %{buildroot}%{_datadir}/application-registry
@ -150,9 +136,9 @@ install -Dm 0644 $i %{buildroot}%{_mandir}/man1/$f; done
# install mimeinfo
install -Dm 0644 debian/%{name}.sharedmimeinfo %{buildroot}%{_datadir}/mime/packages/%{name}.xml
# remove makefiles from %%doc
find %{buildroot}%{_datadir}/%{name}/doc -type f -name \*akefile* -exec rm -f {} \;
find %{buildroot}%{_datadir}/%{name}/doc -type f -name \*akefile* -delete
# remove zero-length
find %{buildroot}%{_datadir}/%{name}/doc -type f -empty -exec rm -f {} \;
find %{buildroot}%{_datadir}/%{name}/doc -type f -empty -delete
# fix non-executable-script
chmod a+x %{buildroot}%{_datadir}/%{name}/doc/pari/gphtml
# fix script-without-shebang
@ -241,10 +227,6 @@ fi
%{_includedir}/giac/
%{_libdir}/libgiac.so
%files devel-static
%license COPYING
%{_libdir}/libgiac.la
%files doc
%license COPYING
%{_datadir}/giac/doc/