Dirk Mueller
293988be41
- glibc-fix-cve-2024-33599.patch: nscd: Stack-based buffer overflow in netgroup cache (CVE-2024-33599, bsc#1223423) OBS-URL: https://build.opensuse.org/request/show/1170863 OBS-URL: https://build.opensuse.org/package/show/Base:System/glibc?expand=0&rev=703
38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
From 87801a8fd06db1d654eea3e4f7626ff476a9bdaa Mon Sep 17 00:00:00 2001
|
|
From: Florian Weimer <fweimer@redhat.com>
|
|
Date: Thu, 25 Apr 2024 15:00:45 +0200
|
|
Subject: [PATCH] CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup
|
|
cache (bug 31677)
|
|
|
|
Using alloca matches what other caches do. The request length is
|
|
bounded by MAXKEYLEN.
|
|
|
|
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
|
|
---
|
|
nscd/netgroupcache.c | 5 +++--
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
|
|
index 0c6e46f15c..f227dc7fa2 100644
|
|
--- a/nscd/netgroupcache.c
|
|
+++ b/nscd/netgroupcache.c
|
|
@@ -502,12 +502,13 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req,
|
|
= (struct indataset *) mempool_alloc (db,
|
|
sizeof (*dataset) + req->key_len,
|
|
1);
|
|
- struct indataset dataset_mem;
|
|
bool cacheable = true;
|
|
if (__glibc_unlikely (dataset == NULL))
|
|
{
|
|
cacheable = false;
|
|
- dataset = &dataset_mem;
|
|
+ /* The alloca is safe because nscd_run_worker verfies that
|
|
+ key_len is not larger than MAXKEYLEN. */
|
|
+ dataset = alloca (sizeof (*dataset) + req->key_len);
|
|
}
|
|
|
|
datahead_init_pos (&dataset->head, sizeof (*dataset) + req->key_len,
|
|
--
|
|
2.44.0
|
|
|