Jan Engelhardt
ad5abde066
OBS-URL: https://build.opensuse.org/request/show/938263 OBS-URL: https://build.opensuse.org/package/show/X11:Wayland/glslang?expand=0&rev=84
174 lines
4.4 KiB
Diff
174 lines
4.4 KiB
Diff
From 0eda343970e04e7c9447d264271b1c4cfdc923f4 Mon Sep 17 00:00:00 2001
|
|
From: Marius Hillenbrand <mhillen@linux.ibm.com>
|
|
Date: Tue, 9 Nov 2021 16:31:22 +0100
|
|
Subject: [PATCH] Use intermOut.cpp's IsNan and IsInfinity for parse-time
|
|
constant folding (updated)
|
|
|
|
There were two implementations of isInf() and isNan(), in Constant.cpp
|
|
and in intermOut.cpp. The former only works on little-endian systems,
|
|
the latter is a wrapper for library functions and works regardless of
|
|
endianness. Move the second version into Common.h and adopt it in both
|
|
places. Thereby avoid the duplication and fix for big-endian systems.
|
|
|
|
A previous commit with the same intent and purpose had missed a required
|
|
header for builds on Windows.
|
|
|
|
On s390x, this fixes the test case
|
|
Glsl/CompileToAstTest.FromFile/constFold_frag.
|
|
|
|
Fixes #2802
|
|
---
|
|
glslang/Include/Common.h | 33 ++++++++++++++++++++++++
|
|
glslang/MachineIndependent/Constant.cpp | 33 ++----------------------
|
|
glslang/MachineIndependent/intermOut.cpp | 31 ----------------------
|
|
3 files changed, 35 insertions(+), 62 deletions(-)
|
|
|
|
diff --git a/glslang/Include/Common.h b/glslang/Include/Common.h
|
|
index e7b5e072b..9042a1aa2 100644
|
|
--- a/glslang/Include/Common.h
|
|
+++ b/glslang/Include/Common.h
|
|
@@ -39,6 +39,11 @@
|
|
|
|
#include <algorithm>
|
|
#include <cassert>
|
|
+#ifdef _MSC_VER
|
|
+#include <cfloat>
|
|
+#else
|
|
+#include <cmath>
|
|
+#endif
|
|
#include <cstdio>
|
|
#include <cstdlib>
|
|
#include <list>
|
|
@@ -302,6 +307,34 @@ template <class T> int IntLog2(T n)
|
|
return result;
|
|
}
|
|
|
|
+inline bool IsInfinity(double x) {
|
|
+#ifdef _MSC_VER
|
|
+ switch (_fpclass(x)) {
|
|
+ case _FPCLASS_NINF:
|
|
+ case _FPCLASS_PINF:
|
|
+ return true;
|
|
+ default:
|
|
+ return false;
|
|
+ }
|
|
+#else
|
|
+ return std::isinf(x);
|
|
+#endif
|
|
+}
|
|
+
|
|
+inline bool IsNan(double x) {
|
|
+#ifdef _MSC_VER
|
|
+ switch (_fpclass(x)) {
|
|
+ case _FPCLASS_SNAN:
|
|
+ case _FPCLASS_QNAN:
|
|
+ return true;
|
|
+ default:
|
|
+ return false;
|
|
+ }
|
|
+#else
|
|
+ return std::isnan(x);
|
|
+#endif
|
|
+}
|
|
+
|
|
} // end namespace glslang
|
|
|
|
#endif // _COMMON_INCLUDED_
|
|
diff --git a/glslang/MachineIndependent/Constant.cpp b/glslang/MachineIndependent/Constant.cpp
|
|
index 7f5d4c4f2..5fc61dbb7 100644
|
|
--- a/glslang/MachineIndependent/Constant.cpp
|
|
+++ b/glslang/MachineIndependent/Constant.cpp
|
|
@@ -46,35 +46,6 @@ namespace {
|
|
|
|
using namespace glslang;
|
|
|
|
-typedef union {
|
|
- double d;
|
|
- int i[2];
|
|
-} DoubleIntUnion;
|
|
-
|
|
-// Some helper functions
|
|
-
|
|
-bool isNan(double x)
|
|
-{
|
|
- DoubleIntUnion u;
|
|
- // tough to find a platform independent library function, do it directly
|
|
- u.d = x;
|
|
- int bitPatternL = u.i[0];
|
|
- int bitPatternH = u.i[1];
|
|
- return (bitPatternH & 0x7ff80000) == 0x7ff80000 &&
|
|
- ((bitPatternH & 0xFFFFF) != 0 || bitPatternL != 0);
|
|
-}
|
|
-
|
|
-bool isInf(double x)
|
|
-{
|
|
- DoubleIntUnion u;
|
|
- // tough to find a platform independent library function, do it directly
|
|
- u.d = x;
|
|
- int bitPatternL = u.i[0];
|
|
- int bitPatternH = u.i[1];
|
|
- return (bitPatternH & 0x7ff00000) == 0x7ff00000 &&
|
|
- (bitPatternH & 0xFFFFF) == 0 && bitPatternL == 0;
|
|
-}
|
|
-
|
|
const double pi = 3.1415926535897932384626433832795;
|
|
|
|
} // end anonymous namespace
|
|
@@ -663,12 +634,12 @@ TIntermTyped* TIntermConstantUnion::fold(TOperator op, const TType& returnType)
|
|
|
|
case EOpIsNan:
|
|
{
|
|
- newConstArray[i].setBConst(isNan(unionArray[i].getDConst()));
|
|
+ newConstArray[i].setBConst(IsNan(unionArray[i].getDConst()));
|
|
break;
|
|
}
|
|
case EOpIsInf:
|
|
{
|
|
- newConstArray[i].setBConst(isInf(unionArray[i].getDConst()));
|
|
+ newConstArray[i].setBConst(IsInfinity(unionArray[i].getDConst()));
|
|
break;
|
|
}
|
|
|
|
diff --git a/glslang/MachineIndependent/intermOut.cpp b/glslang/MachineIndependent/intermOut.cpp
|
|
index a0fade16c..d8a3aab5d 100644
|
|
--- a/glslang/MachineIndependent/intermOut.cpp
|
|
+++ b/glslang/MachineIndependent/intermOut.cpp
|
|
@@ -48,37 +48,6 @@
|
|
#endif
|
|
#include <cstdint>
|
|
|
|
-namespace {
|
|
-
|
|
-bool IsInfinity(double x) {
|
|
-#ifdef _MSC_VER
|
|
- switch (_fpclass(x)) {
|
|
- case _FPCLASS_NINF:
|
|
- case _FPCLASS_PINF:
|
|
- return true;
|
|
- default:
|
|
- return false;
|
|
- }
|
|
-#else
|
|
- return std::isinf(x);
|
|
-#endif
|
|
-}
|
|
-
|
|
-bool IsNan(double x) {
|
|
-#ifdef _MSC_VER
|
|
- switch (_fpclass(x)) {
|
|
- case _FPCLASS_SNAN:
|
|
- case _FPCLASS_QNAN:
|
|
- return true;
|
|
- default:
|
|
- return false;
|
|
- }
|
|
-#else
|
|
- return std::isnan(x);
|
|
-#endif
|
|
-}
|
|
-
|
|
-}
|
|
|
|
namespace glslang {
|
|
|