Accepting request 155771 from GNOME:Factory

Remove nonworking help button from gnome-session-properties ("Startup Applications")

Now with correct upstream bug number! (forwarded request 155770 from dimstar)

OBS-URL: https://build.opensuse.org/request/show/155771
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/gnome-session?expand=0&rev=132

gnome-session-properties-remove-help.patch

@@ -0,0 +1,24 @@
+From e9764e3db2696e282521c7f01dd460416f8e6ee0 Mon Sep 17 00:00:00 2001
+From: Matthias Clasen <mclasen@redhat.com>
+Date: Sat, 09 Feb 2013 18:15:57 +0000
+Subject: Hide non-working help button
+
+gnome-session-properties has a help button that points to
+no-longer-exising docs. Hide it until new docs are
+available.
+https://bugzilla.gnome.org/show_bug.cgi?id=658712
+---
+diff --git a/capplet/gsm-properties-dialog.c b/capplet/gsm-properties-dialog.c
+index 4270551..712b861 100644
+--- a/capplet/gsm-properties-dialog.c
++++ b/capplet/gsm-properties-dialog.c
+@@ -474,7 +474,6 @@ setup_dialog (GsmPropertiesDialog *dialog)
+         GtkTargetList     *targetlist;
+ 
+         gtk_dialog_add_buttons (GTK_DIALOG (dialog),
+-                                GTK_STOCK_HELP, GTK_RESPONSE_HELP,
+                                 GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
+                                 NULL);
+ 
+--
+cgit v0.9.0.2

gnome-session.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Mon Feb 18 21:36:49 UTC 2013 - mike.catanzaro@gmail.com
+
+- Add gnome-session-properties-remove-help.patch (bnc#804180) from
+  upstream git to remove the help button in "Startup Applications"
+  which points to nowhere.
+
 -------------------------------------------------------------------
 Fri Nov 16 22:01:14 UTC 2012 - dimstar@opensuse.org
 

gnome-session.spec

@@ -32,6 +32,8 @@ Source2:        gnome.desktop
 Patch0:         gnome-session-ice-auth-for-suid.patch
 # PATCH-FIX-UPSTREAM gnome-session-kdm-support.patch hpj@novell.com -- Adds support for KDM logout commands.
 Patch1:         gnome-session-kdm-support.patch
+# PATCH-FIX-UPSTREAM gnome-session-properties-remove-help.patch bnc#804180 bgo#658712 mike.catanzaro@gmail.com -- This module no longer has help so remove the button
+Patch2:         gnome-session-properties-remove-help.patch
 # PATCH-FEATURE-OPENSUSE gnome-session-unblacklist-llvmpipe.patch badshah400@gmail.com -- Remove llvmpipe from blacklisted drivers to enable full gnome-shell session on virtual machines.
 Patch4:         gnome-session-unblacklist-llvmpipe.patch
 BuildRequires:  fdupes
@@ -131,6 +133,7 @@ functional GNOME desktop.
 translation-update-upstream
 %patch0 -p1
 %patch1 -p1
+%patch2 -p1
 %patch4 -p1
 
 %build