pool/gnome-shell
SHA256
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accepting request 703084 from home:yfjiang:branches:GNOME:Factory

Browse Source 
- Add gnome-shell-do-not-chain-up-to-parent-allocate.patch: Don't
  chain up to parent's allocate, resolving Topicon Plus extension
  high cpu consumption (glgo#GNOME/gnome-shell#1054).

OBS-URL: https://build.opensuse.org/request/show/703084
OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/gnome-shell?expand=0&rev=389
This commit is contained in:
Dominique Leuenberger 2019-05-15 13:56:15 +00:00 committed by Git OBS Bridge
parent 4b952c485b
commit b353bbb879
3 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
gnome-shell-do-not-chain-up-to-parent-allocate.patch Normal file
View File

@ -0,0 +1,31 @@
From d57234bec93dc486dac07d6cbc02c52091c5098a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Mon, 29 Apr 2019 17:53:57 +0000
Subject: [PATCH] panel: Don't chain up to parent's allocate
The top bar handles allocating all its children itself, so there's
little value in chaining up to st_widget_allocate() and get the
default layout manager allocating all children again (and possibly
differently).
If this happens, we end up with an infinite allocation cycle with
corresponding performance penalty. Fix this by just doing and what
Shell.GenericContainer did before commit 286ffbe2b6 replaced it,
and not chain up to StWidget.
Thanks to Robert Mader for debugging the issue.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1054
Index: gnome-shell-3.32.1/js/ui/panel.js
===================================================================
--- gnome-shell-3.32.1.orig/js/ui/panel.js
+++ gnome-shell-3.32.1/js/ui/panel.js
@@ -882,7 +882,7 @@ class Panel extends St.Widget {
}
vfunc_allocate(box, flags) {
- super.vfunc_allocate(box, flags);
+ this.set_allocation(box, flags);
let allocWidth = box.x2 - box.x1;
let allocHeight = box.y2 - box.y1;

7
gnome-shell.changes
View File

@ -1,3 +1,10 @@
-------------------------------------------------------------------
Tue May 14 09:05:41 UTC 2019 - Yifan Jiang <yfjiang@suse.com>
- Add gnome-shell-do-not-chain-up-to-parent-allocate.patch: Don't
chain up to parent's allocate, resolving Topicon Plus extension
high cpu consumption (glgo#GNOME/gnome-shell#1054).
-------------------------------------------------------------------
Fri Apr 19 18:11:42 UTC 2019 - Bjørn Lie <bjorn.lie@gmail.com>

3
gnome-shell.spec
View File

@ -41,6 +41,8 @@ Patch4: gnome-shell-fate324570-Make-GDM-background-image-configurable.pa
# PATCH-FEATURE-SLE gnome-shell-gdm-login-applet.patch fate#314545 dliang@suse.com -- Add an applet on login UI to display suse icon, product name, hostname.
# PATCH-FIX-UPSTREAM gnome-shell-animations-speedup.patch glgo#GNOME/gnome-shell!505 -- Speed up animations
Patch5: gnome-shell-animations-speedup.patch
# PATCH-FIX-UPSTREAM gnome-shell-do-not-chain-up-to-parent-allocate.patch yfjiang@suse.com glgo#GNOME/gnome-shell#1054 -- panel: Don't chain up to parent's allocate, resolving Topicon Plus extension high cpu consumption
Patch6: gnome-shell-do-not-chain-up-to-parent-allocate.patch
Patch1001: gnome-shell-gdm-login-applet.patch
# PATCH-FEATURE-SLE gnome-shell-domain.patch fate#307773 dliang@suse.com -- Active Directory Integration
@ -167,6 +169,7 @@ into GNOME Shell calendar.
%patch3 -p1
%patch4 -p1
%patch5 -p1
%patch6 -p1
translation-update-upstream