OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/groff?expand=0&rev=13

fgets-overflow.patch

@@ -0,0 +1,13 @@
+--- src/devices/grops/ps.cc
++++ src/devices/grops/ps.cc
+@@ -740,8 +740,8 @@
+   if (fp == 0)
+     fatal("can't open encoding file `%1'", encoding);
+   int lineno = 1;
+-  char buf[256];
+-  while (fgets(buf, 512, fp) != 0) {
++  char buf[512];
++  while (fgets(buf, sizeof(buf), fp) != 0) {
+     char *p = buf;
+     while (csspace(*p))
+       p++;

groff.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Mon Oct  6 22:15:13 CEST 2008 - meissner@suse.de
+
+- fixed fgets overflow
+- fixed some rpmlint issues
+
 -------------------------------------------------------------------
 Mon Apr 21 17:25:52 CEST 2008 - mfabian@suse.de
 

groff.spec

@@ -2,9 +2,16 @@
 # spec file for package groff (Version 1.18.1.1)
 #
 # Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany.
-# This file and all modifications and additions to the pristine
-# package are under the same license as the package itself.
 #
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
@@ -12,7 +19,7 @@
 
 
 Name:           groff
-BuildRequires:  bison gcc-c++
+BuildRequires:  bison fdupes gcc-c++
 %define	build_groff_docu	1
 #
 License:        BSD 3-Clause; GPL v2 or later
@@ -22,7 +29,7 @@ Obsoletes:      jgroff
 PreReq:         %fillup_prereq %install_info_prereq
 AutoReqProv:    on
 Version:        1.18.1.1
-Release:        131
+Release:        164
 Summary:        GNU troff Document Formatting System
 Url:            http://www.gnu.org/software/groff/groff.html
 # cvs -z3 -d:pserver:anonymous@cvs.savannah.gnu.org:/sources/groff co groff
@@ -44,6 +51,7 @@ Patch9:         groff-1.18.1.1-gcc41.patch
 Patch10:        bugzilla-217106-too-few-arguments-in-function-call.patch
 Patch11:        bugzilla-292412-special-encoding-handling-also-for-chinese.patch
 Patch12:        gcc43.patch
+Patch13:        fgets-overflow.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
@@ -77,6 +85,7 @@ Authors:
 %patch10 -p1
 %patch11 -p1
 %patch12 -p0
+%patch13 -p0
 
 %build
 # remove empty backups
@@ -128,12 +137,13 @@ echo "papersize a4" > $RPM_BUILD_ROOT/etc/papersize
 chmod 0644 $RPM_BUILD_ROOT/etc/papersize
 # install profiles to disable the use of ANSI colour sequences by default:
 mkdir -p $RPM_BUILD_ROOT/etc/profile.d
-install -m 755 $RPM_SOURCE_DIR/groff.sh  $RPM_BUILD_ROOT/etc/profile.d
+install -m 644 $RPM_SOURCE_DIR/groff.sh  $RPM_BUILD_ROOT/etc/profile.d
-install -m 755 $RPM_SOURCE_DIR/groff.csh $RPM_BUILD_ROOT/etc/profile.d
+install -m 644 $RPM_SOURCE_DIR/groff.csh $RPM_BUILD_ROOT/etc/profile.d
 pushd $RPM_BUILD_ROOT/usr/share/groff
     test -d 1.18.1 || exit 1
     ln -s 1.18.1 current
 popd
+%fdupes $RPM_BUILD_ROOT
 
 %clean
 #[ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT;
@@ -153,7 +163,7 @@ popd
 /usr/bin/*
 %doc %{_mandir}/man?/*
 %config(noreplace) %verify(not md5 size mtime) /etc/papersize
-/etc/profile.d/groff.*sh
+%config /etc/profile.d/groff.*sh
 %dir /usr/share/groff/
 %dir /usr/share/groff/site-tmac/
 /usr/share/groff/site-tmac/*
@@ -177,6 +187,9 @@ popd
 /var/adm/fillup-templates/sysconfig.suseconfig-groff
 
 %changelog
+* Tue Oct 07 2008 meissner@suse.de
+- fixed fgets overflow
+- fixed some rpmlint issues
 * Mon Apr 21 2008 mfabian@suse.de
 - bnc#381905: remove the hack in /usr/bin/nroff to convert
   UTF-8 encoded man-pages back to the appropriate legacy encoding

gxdview.spec

@@ -2,9 +2,16 @@
 # spec file for package gxdview (Version 1.18.1.1)
 #
 # Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany.
-# This file and all modifications and additions to the pristine
-# package are under the same license as the package itself.
 #
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
@@ -18,7 +25,7 @@ AutoReqProv:    on
 Requires:       groff
 Conflicts:      jgxdview
 Version:        1.18.1.1
-Release:        160
+Release:        205
 Summary:        Ditroff Output Displayer for Groff
 Url:            http://www.gnu.org/software/groff/groff.html
 Source0:        ftp://ftp.gnu.org/gnu/groff/groff-1.18.1.1.tar.bz2