pool/grub2-compat-ia32
SHA256
16
0
Fork 1
Code Issues Pull Requests 1 Activity

Drop update-bootloader --get (poo#1247052) #2

Manually merged
lkocman merged 1 commits from lkocman/grub2-compat-ia32:leap-16.0 into leap-16.0 2026-01-12 17:31:51 +01:00
Conversation 19 Commits 1 Files Changed 2 +22 -7
lkocman commented 2025-09-30 00:49:01 +02:00
Contributor
Copy Link
  • it returns 0 even if the variable is unset
  • factory sr#1307971
  • Fixes poo#1247052
- it returns 0 even if the variable is unset - factory sr#1307971 - Fixes poo#1247052
autogits_workflow_pr_bot requested review from legaldb 2025-09-30 00:49:22 +02:00
autogits_workflow_pr_bot requested review from packagehub-review 2025-09-30 00:49:23 +02:00
lkocman changed title from Drop update-bootloader --get to Drop update-bootloader --get (poo#1247052) 2025-09-30 00:52:13 +02:00
packagehub-review commented 2025-09-30 00:53:38 +02:00
Member
Copy Link

Review by packagehub-review represents a group of reviewers: bigironman, lkocman-factory, maxlin_factory, .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @packagehub-review: approve.
To request changes on behalf of the group, create the following comment: @packagehub-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by packagehub-review represents a group of reviewers: bigironman, lkocman-factory, maxlin_factory, . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@packagehub-review: approve`. To request changes on behalf of the group, create the following comment: `@packagehub-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
legaldb commented 2025-09-30 01:04:59 +02:00
Member
Copy Link

Legal reviewed as acceptable:

Accepted because previously reviewed under the same license (455614)
Legal reviewed as [acceptable](https://legaldb.suse.de/reviews/details/468069): ``` Accepted because previously reviewed under the same license (455614) ```
report.md
345 B
legaldb approved these changes 2025-09-30 01:04:59 +02:00
Dismissed
adamm requested changes 2025-09-30 09:18:11 +02:00
adamm left a comment
First-time contributor
Copy Link

it's missing the

Requires(post):    update-bootloader
Requires(postun):  update-bootloader
it's missing the ``` Requires(post): update-bootloader Requires(postun): update-bootloader ```
adamm reviewed 2025-09-30 09:19:33 +02:00
grub2-compat-ia32.spec Outdated
@@ -25,6 +25,7 @@ URL: https://en.opensuse.org/GRUB#Enabling_32bit_x86_support_in_Kerne
Source1: README.md
Requires: glibc-32bit
Requires: update-bootloader
BuildRequires: update-bootloader
adamm commented 2025-09-30 09:19:33 +02:00
First-time contributor
Copy Link

This BuildRequire doesn't seem to be used anywhere. Is this for some post check in the buildenv?

This BuildRequire doesn't seem to be used anywhere. Is this for some post check in the buildenv?
eroca commented 2025-10-27 14:10:57 +01:00
Owner
Copy Link

@lkocman ping

@lkocman ping
lkocman commented 2025-10-27 14:19:19 +01:00
Author
Contributor
Copy Link

Hello Adam,

i believe there was an idempotency check was failing on this if it wasn't used or similar.
This one needs to go out early as otherwise the GA version of the package doesn't do its job.

Lubos

Hello Adam, i believe there was an idempotency check was failing on this if it wasn't used or similar. This one needs to go out early as otherwise the GA version of the package doesn't do its job. Lubos
👍 1
adamm_super marked this conversation as resolved
packagehub-review requested review from bigironman 2025-10-08 18:46:00 +02:00
packagehub-review requested review from lkocman-factory 2025-10-08 18:46:00 +02:00
packagehub-review requested review from maxlin_factory 2025-10-08 18:46:00 +02:00
packagehub-review requested review from smithfarm 2025-10-08 18:46:00 +02:00
autogits_workflow_pr_bot requested review from maintenance-release-review 2025-10-09 13:47:04 +02:00
autogits_workflow_pr_bot requested review from opensuse-review 2025-10-09 13:47:04 +02:00
opensuse-review commented 2025-10-09 13:49:23 +02:00
Member
Copy Link

Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @opensuse-review: approve.
To request changes on behalf of the group, create the following comment: @opensuse-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@opensuse-review: approve`. To request changes on behalf of the group, create the following comment: `@opensuse-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
maintenance-release-review commented 2025-10-09 13:49:25 +02:00
First-time contributor
Copy Link

Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, msmeissn, pluskalm, rfrohl, slemke .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @maintenance-release-review: approve.
To request changes on behalf of the group, create the following comment: @maintenance-release-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, msmeissn, pluskalm, rfrohl, slemke . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@maintenance-release-review: approve`. To request changes on behalf of the group, create the following comment: `@maintenance-release-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
eroca removed review request for packagehub-review 2025-10-27 14:09:14 +01:00
eroca removed review request for maxlin_factory 2025-10-27 14:09:16 +01:00
eroca removed review request for bigironman 2025-10-27 14:09:18 +01:00
eroca removed review request for lkocman-factory 2025-10-27 14:09:20 +01:00
eroca removed review request for smithfarm 2025-10-27 14:09:21 +01:00
oertel commented 2025-10-27 18:35:23 +01:00
First-time contributor
Copy Link

anything on the comment from adamm ?

anything on the comment from adamm ?
lkocman commented 2025-11-24 18:08:10 +01:00
Author
Contributor
Copy Link

Fixed in https://build.opensuse.org/requests/1319812
I did meanwhile move the project to git / scmsync, so I can send a parallel pr

Fixed in https://build.opensuse.org/requests/1319812 I did meanwhile move the project to git / scmsync, so I can send a parallel pr
lkocman added 1 commit 2025-11-24 18:11:36 +01:00
- Add update-bootloader also into post and postun Requires 1dbc6bcb1a 
- Drop update-bootloader --get as it returns 0
  even if the variable is unset
lkocman dismissed legaldb's review 2025-11-24 18:11:36 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

autogits_workflow_pr_bot requested review from legaldb 2025-11-24 18:12:02 +01:00
lkocman commented 2025-11-24 18:12:50 +01:00
Author
Contributor
Copy Link

@oertel @adamm I did force pushed the content of the main branch (now a new devel repo for the project). Which is identical to sr#1319812 and should address Adam's feedback.

@oertel @adamm I did force pushed the content of the main branch (now a new devel repo for the project). Which is identical to sr#1319812 and should address Adam's feedback.
opensuse-review commented 2025-11-24 18:15:20 +01:00
Member
Copy Link

Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @opensuse-review: approve.
To request changes on behalf of the group, create the following comment: @opensuse-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@opensuse-review: approve`. To request changes on behalf of the group, create the following comment: `@opensuse-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
maintenance-release-review commented 2025-11-24 18:18:43 +01:00
First-time contributor
Copy Link

Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, msmeissn, pluskalm, rfrohl, slemke .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @maintenance-release-review: approve.
To request changes on behalf of the group, create the following comment: @maintenance-release-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, msmeissn, pluskalm, rfrohl, slemke . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@maintenance-release-review: approve`. To request changes on behalf of the group, create the following comment: `@maintenance-release-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
legaldb commented 2025-11-24 18:28:53 +01:00
Member
Copy Link

Legal reviewed as acceptable:

Accepted because previously reviewed under the same license (467961)
Legal reviewed as [acceptable](https://legaldb.suse.de/reviews/details/490936): ``` Accepted because previously reviewed under the same license (467961) ```
report.md
345 B
legaldb approved these changes 2025-11-24 18:28:53 +01:00
rfrohl commented 2025-11-28 10:38:21 +01:00
First-time contributor
Copy Link

@maintenance-release-review: approve
merge ok

@maintenance-release-review: approve merge ok
maintenance-release-review approved these changes 2025-11-28 10:47:45 +01:00
maintenance-release-review left a comment
First-time contributor
Copy Link

rfrohl approved a review on behalf of maintenance-release-review

rfrohl approved a review on behalf of maintenance-release-review
oertel commented 2025-11-28 12:07:16 +01:00
First-time contributor
Copy Link

@opensuse-review : approve

LGTM

@opensuse-review : approve LGTM
oertel commented 2025-11-28 12:07:16 +01:00
First-time contributor
Copy Link

merge ok

merge ok
opensuse-review approved these changes 2025-11-28 12:13:49 +01:00
opensuse-review left a comment
Member
Copy Link

oertel approved a review on behalf of opensuse-review

oertel approved a review on behalf of opensuse-review
lkocman manually merged commit 1dbc6bcb1a into leap-16.0 2026-01-12 17:31:51 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
adamm
legaldb
maintenance-release-review
opensuse-review
Labels
Clear labels
legaldb
Critical Priority
Critical legaldb priority
Archived
legaldb
High Priority
2
High legaldb priority
legaldb
Normal Priority
1
Normal legaldb priority
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super adrianSuSE autobuild-owner autobuild-review autogits_workflow_pr_bot bigironman dirkmueller eroca factory_bot gitea_test legaldb lkocman-factory maxlin_factory opensuse-review packagehub-review smithfarm
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pool/grub2-compat-ia32#2
Delete Branch "lkocman/grub2-compat-ia32:leap-16.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?