1855ad5881
* 0001-fs-xfs-Add-new-superblock-features-added-in-Linux-6..patch * 0002-fs-xfs-Fix-grub_xfs_iterate_dir-return-value-in-case.patch - Fix "attempt to read of write outside of partition" error message (bsc#1237844) * 0003-fs-xfs-fix-large-extent-counters-incompat-feature-su.patch OBS-URL: https://build.opensuse.org/package/show/Base:System/grub2?expand=0&rev=531
36 lines
1.1 KiB
Diff
36 lines
1.1 KiB
Diff
From 07482c2ab034df5069761319e4969551c3dcc6e1 Mon Sep 17 00:00:00 2001
|
|
From: B Horn <b@horn.uk>
|
|
Date: Sun, 12 May 2024 03:01:40 +0100
|
|
Subject: [PATCH 06/20] kern/file: Ensure file->data is set
|
|
|
|
This is to avoid a generic issue were some filesystems would not set
|
|
data and also not set a grub_errno. This meant it was possible for many
|
|
filesystems to grub_dl_unref() themselves multiple times resulting in
|
|
it being possible to unload the filesystems while there were still
|
|
references to them, e.g., via a loopback.
|
|
|
|
Reported-by: B Horn <b@horn.uk>
|
|
Signed-off-by: B Horn <b@horn.uk>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
---
|
|
grub-core/kern/file.c | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/grub-core/kern/file.c b/grub-core/kern/file.c
|
|
index 750177248f..e990507fca 100644
|
|
--- a/grub-core/kern/file.c
|
|
+++ b/grub-core/kern/file.c
|
|
@@ -114,6 +114,9 @@ grub_file_open (const char *name, enum grub_file_type type)
|
|
if ((file->fs->fs_open) (file, file_name) != GRUB_ERR_NONE)
|
|
goto fail;
|
|
|
|
+ if (file->data == NULL)
|
|
+ goto fail;
|
|
+
|
|
file->name = grub_strdup (name);
|
|
grub_errno = GRUB_ERR_NONE;
|
|
|
|
--
|
|
2.48.1
|
|
|