- replace setBadness with addFilter in guix-rpmlint, add explanations

- add guix-rpmlint into spec file as Source
- create rcguix-daemon symlink
- make guix bash completion script as %config to silence warning

OBS-URL: https://build.opensuse.org/package/show/system:packagemanager/guix?expand=0&rev=9

guix-rpmlintrc

@@ -1,5 +1,20 @@
 # guix is bootstrapping package so there are some non-standard exceptions
-setBadness("arch-dependent-file-in-usr-share",0)
+#  1] it violates FHS (intentionally) - this is feature, not bug
+addFilter("W: suse-filelist-forbidden-fhs23 /gnu is not allowed in FHS 2.3")
 
-# static binaries are expected for bootstrapping
-setBadness("statically-linked-binary",0)
+
+#  2] it contains foreign static binaries used for bootstrap see:
+# https://www.gnu.org/software/guix/manual/html_node/Bootstrapping.html#Building-the-Bootstrap-Binaries
+
+# they are binaries in /usr/share
+addFilter("E: arch-dependent-file-in-usr-share .*/usr/share/guile/site/2.0/gnu/packages/bootstrap/.*")
+
+# they are static binaries
+addFilter("W: statically-linked-binary /usr/share/guile/site/2.0/gnu/packages/bootstrap/.*")
+
+# they are foreign
+addFilter("W: missing-PT_GNU_STACK-section /usr/share/guile/site/2.0/gnu/packages/bootstrap/.*")
+
+# I will add guixbuild group into rpmlint once I know that everything
+# else is correct
+addFilter("W: non-standard-gid /gnu/store guixbuild")

guix.changes

@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Fri Feb 12 09:18:04 UTC 2016 - sleep_walker@opensuse.org
+
+- replace setBadness with addFilter in guix-rpmlint, add explanations
+- add guix-rpmlint into spec file as Source
+- create rcguix-daemon symlink
+- make guix bash completion script as %config to silence warning
+
 -------------------------------------------------------------------
 Tue Jan  5 18:58:35 UTC 2016 - sleep_walker@opensuse.org
 

guix.spec

@@ -39,6 +39,7 @@ Source4:        x86_64-linux-%{guile}
 Source5:        mips64el-linux-%{guile}
 # http://alpha.gnu.org/gnu/guix/bootstrap/armhf-linux/20150101/guile-2.0.11.tar.xz
 Source6:        armhf-linux-guile-2.0.11.tar.xz
+Source10:	guix-rpmlintrc
 BuildRequires:  emacs-nox
 BuildRequires:  gcc-c++
 BuildRequires:	guile-json
@@ -48,7 +49,6 @@ BuildRequires:  pkgconfig(bzip2)
 BuildRequires:  pkgconfig(guile-2.0) >= 2.0.7
 BuildRequires:  pkgconfig(sqlite3)
 Requires:       guile
-Requires:       libgcrypt-devel
 Requires(pre):  %{install_info_prereq}
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 %{?systemd_requires}
@@ -87,6 +87,8 @@ install -d -m 0755 %{buildroot}/gnu/store
 %if ! %{systemd_present}
 rm -rvf %{buildroot}%{_unitdir}
 %endif
+ln -sf /usr/sbin/service %{buildroot}%{_sbindir}/rcguix-daemon
+
 
 %pre
 %{_sbindir}/groupadd -r %{guix_builder_group} >/dev/null 2>/dev/null || :
@@ -118,12 +120,14 @@ done
 %files -f %{name}.lang -f guix-packages.lang
 %defattr(-,root,root)
 %doc COPYING README
-%{_sysconfdir}/bash_completion.d/guix
+# bash completion script is not configuration file but who would argue
+# with RPM lint :b
+%config %{_sysconfdir}/bash_completion.d/guix
 %{_datadir}/guile
 %{_datadir}/guix
 %{_datadir}/emacs/site-lisp/guix*
 %{_bindir}/guix*
-%{_sbindir}/guix*
+%{_sbindir}/*guix*
 %{_libexecdir}/guix
 %{_libexecdir}/guix-authenticate
 %{_infodir}/guix*