Update to 2.12.0 #1
Reference in New Issue
Block a user
Delete Branch "java-packages/hibiscus:main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created submit request sr#1315756
Created submit request sr#1315946
@fstrba
Why was spec changed?
As the maintainer, I wanted it to stay exactly as it was.
The commented-out lines were intentionally left in.
Because it's not yet clear whether it will stay that way.
Previously, it was different for several versions and years.
Perhaps it will return?
And then what?
I uploaded the version for the sole reason that there was a change in EU law, which meant that transfers could no longer be made.
And why were the file names changed?
I want it this way because just having the version number is stupid, especially in this case. You can't tell whether 2.12.0 is hibiscus or jamaica.
And why was the _service file removed?
I need that to download things.
@fstrba
And why am I not allowed to accept the request?
Until now, I was the maintainer of java:packages/jameica and hibiscus under OBS.
Does that no longer apply?
Or what good does it do anymore?
And how should one apply for this in the future?
It's all very, very suspicious.
One more thing.
What does “first-time contributor” mean?
I have been maintaining the package since 2018.
Because the stuff was not building. But this being git, it is easy to revert. Just I don't want to see in Java:packages packages that don't build. I made the mistake to remove that commented lines, but those packages did not have their sources added and were broken.
No, nothing was broken.
It still works in OBS.
Unfortunately, you can't check that beforehand with git. Or can you? I don't know. It's not described properly anywhere. The documentation doesn't work, etc.
I then logged in via the GUI because nothing else worked.
I took the packages from my home that built without errors.
After I had uploaded everything manually via the GUI, I made a request. Whether it was right or wrong, I have no idea. It's not described correctly anywhere.
After that, my project in home was broken. It's complete crap. They were exactly the same packages. Absolute crap. It took a while until I had everything working again. And that was only because I had made a backup beforehand.
The whole thing with Git is so buggy. It's unbelievable. Practically nothing works. And you have to search for everything yourself. Then you get strange emails saying that you're not allowed to do that or something like that.
And then files and comments are removed. Just great.
That was definitely my last attempt to contribute to openSUSE.
Maybe again in a few months, but only if everything works and there is functional documentation. And if there is a real workflow from start to finish.
And only then!!!
This jumping back and forth between osc, git, and git gui is unmanageable.
It's a disaster.
Sorry for my harsh words.
I've been building packages for about 15 years.
But the way things are going at the moment, it's no longer manageable.
My time and my nerves are too precious for that.
It was broken because you forgot to git add the tarballs. I saw what you tried to make and tried to fix it. You can decide to get angry and throw tantrums, or you can simply revert my commit, add the tarballs and push it again. It also takes less time then pointless whining :(
https://en.opensuse.org/openSUSE:Git_Packaging_Workflow
Everything's fine. Maybe I forgot it here, which is no surprise when you have to do everything manually and use different systems. and withoutworking dokumantation.
But I didn't forget it in the corresponding jameica package.
Will everything stay that way now?
Is there no longer a maintainer?
Previously, I updated my home local, built and tested locally, and if successful, uploaded. Everything with osc. It was super easy. Super fast. Then another request to devel. And because I'm a maintainer, it was accepted on devel.
Normally, it takes a maximum of 5 minutes to complete the jameica and hibiscus tasks.
This time, it took me approximately 6 hours. It was likely more if I count the multiple attempts.
Accepting is apparently no longer possible. Maintainers of this kind no longer seem to exist. People who want to contribute to openSUSE no longer have any special rights. Just cheap helpers, it seems to me. Or am I wrong?
So what about a maintainer as we know it from bs and osc?
You forgot to add the tarball in jameica. It was failing because of that in Java:packages. I checked the jameica github and saw that the tags changed, so I did the modification to make it work. Meanwhile, hibiscus was unresolved. Once I made jameica work, I realized that the tarball was not added to hibiscus either, so I redid the same thing to hibiscus.
It is true that I removed the commented lines. But it is for each of the packages just one git commit and one can get the diff and re-add them if one wants.
Concerning the src.opensuse.org setup, yes it has to be done, but it is like any other git based stuff. Even in github, you have to upload your ssh key to be able to push stuff. Then it works the normal git way: change, commit, push ....
Even with the sources being maintained in gitea, the build still happens here https://build.opensuse.org/project/show/Java:packages and one can always see whether one did break anything. Please, check that if you are pushing stuff. It will avoid broken devel project, my intervention and your frustration with my changes. If something is work in progress, it is possible to fork the package from java-packages/ and work on it and then send PR to yourself - when ready - and accept it.
That's not true. I apparently forgot about one, or it didn't work. I'm not so sure anymore. It was in another one. I only got a message from one package saying it was missing. And when I checked, it was. I just wasn't at the computer to fix it.
I'm telling you, the whole thing with Git is extremely makeshift. It doesn't work 100%.
It works on GitHub, but not here!
Why don't you finally accept the criticism of the old-timers and stop trying to belittle them?
You don't need to tell me how to do it. I've been doing it for 15 years. And I also described above how I do it.
And everything locally, including local builds until everything works. I've been doing that for 15 years.
osc co
Change
osc build
osc commit
osc sr
Always. For 15 years.
And the “old files from Jameica and Hibiscus” before they were changed are in my home directory. And they build perfectly. Locally and also in OBS online.
I'll say it again. The git stuff doesn't work consistently and transparently.
I am not belittling you. I also am not excited about the git workflow, but I try to make it work since I have no other choice. I understood that you had problem with it and that is why I fixed the packages myself. But then you take your beef with the fact that I removed the commented lines. Now both packages just work fine in Java:packages and you can add those lines whenever you want, since the history is in git and can be reverted whenever one wants. I have no time for complaining about tooling that I cannot change, I am trying to make it work as well as I can.
So, now it is:
git clone https://src.opensuse.org/java-packages/jameica.git
git checkout main
Change
osc build
git add
git commit -a
git pull -r && git push
osc sr Java:packages jameica openSUSE:Factory
Yeah, for pushing it is gitea@src.opensuse.org:java-packages/jameica.git
Also the best would be to make the new checkout of the whole project by "osc checkout Java:packages" that basically pulls out the https://src.opensuse.org/java-packages/_ObsPrj and initializes the submodules. The advantage of this is that the project has there a _manifest file that specifies what to build against. If it is absent, it might build against openSUSE:Factory standard, which can be also ok though.
That works?
That would be great.
I'll give it a try later.
If it works, then thank you very much.
Yes. I'll do that.
But if I need a service file, then it should be included there, right?
(At the time, I needed it for Hibiscus because there was no tag in GitHub yet. And it wasn't clear whether the developer would do the same thing.)
Yes, something like https://src.opensuse.org/java-packages/maven-filtering4/src/branch/main/_service
Then you can just locally run that by "osc service runall" and it will generate the tarball that you can commit. I do it quite often for stuff when for instance, I need to exclude some files for licensing issues.
It doesnt' work at all
How can I see if the package builds for the corresponding version?
A package build does not necessarily have to work for 16.0 if it works in factory.
The locally created directory for osc is only called standard. Previously, the name included whether it was leap 15.6, leap 16, or tumbleweed. os-release does not exist there.
So how do I test my changes locally for Leap and how do I test for Tumbleweed?
Could you please publish a detailed description of this normal procedure in the wiki, using examples that everyone can understand?
Step by step.
And also with prerequisites such as ssh-agent, etc.
Hibiscus 2.12.0 entered Factory and I think this one can be closed.
BTW, once everything is working well in git, one should not make PRs to pool/factory directly. The submit should be done in the old way, just that the projects and packages have to be explicitely mentioned:
osc sr -m "..." Java:packages hibiscus openSUSE:FactoryThat will cause a request like this one: https://build.opensuse.org/request/show/1316387
orry. I don't understand anything anymore.
First you're supposed to use osc, then git, then osc again. Then you're supposed to branch from the pool, then from the former repo again.
It makes your head spin.
The normal procedure is:
(I hope you looked into this before introducing git)
Change
Test and if OK
So I have no idea what was wrong again.
And as long as there is no understandable and functional documentation, it will stay that way.
And as long as there is no corresponding documentation and the whole thing with git is error-free, the criticism, errors, and annoyance will not stop.
OK, please read me attentively:
https://src.opensuse.org/java-packages/hibiscus and
https://src.opensuse.org/java-packages/jameica
https://build.opensuse.org/project/show/Java:packages
osc sr -m "..." Java:packages hibiscus|jameica openSUSE:Factory
There is a git<->obs bridge that will create a submit request like in the old time. Just you have to write out all the projects manually so that the process knows what to send from where to where
Now, I am not the documentation writer. I am just another developer that had to get used to this thing and I am sharing with you what I did. If you read attentively, it will be easier for you. I don't have anything to do with the criticisms and I don't care about them. I have my own beef with this system, but at least I want my packages to work, so I am trying to learn.