- Fix crash if python3-reportlab is missing (bsc#1159240, lp#1859179)

* Added hp-sendfax-avoid-crash-if-python-reportlab-is-missin.patch
  * Added recommends on python3-reportlab
Reformatted changelog to match hplip changes by version

OBS-URL: https://build.opensuse.org/package/show/Printing/hplip?expand=0&rev=185

hp-sendfax-avoid-crash-if-python-reportlab-is-missin.patch

@@ -0,0 +1,39 @@
+From 8b1bbbb9a3659475367a6f58986ac8248576663b Mon Sep 17 00:00:00 2001
+From: Martin Wilck <mwilck@suse.com>
+Date: Fri, 10 Jan 2020 14:44:51 +0100
+Subject: [PATCH] hp-sendfax: avoid crash if python-reportlab is missing
+
+Avoids this crash:
+
+warning: Reportlab not installed. Fax coverpages disabled.
+warning: Please install version 2.0+ of Reportlab for coverpage support.
+qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 669, resource id: 13465094, major code: 40 (TranslateCoords), minor code: 0
+Traceback (most recent call last):
+  File "/usr/share/hplip/ui5/sendfaxdialog.py", line 375, in FilesTable_fileListChanged
+    self.toggleCoverPage(self.FilesTable.isMIMETypeInList(MIME_TYPE_COVERPAGE))
+  File "/usr/share/hplip/ui5/sendfaxdialog.py", line 328, in toggleCoverPage
+---
+ ui5/sendfaxdialog.py | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/ui5/sendfaxdialog.py b/ui5/sendfaxdialog.py
+index 4248907..3c3e880 100644
+--- a/ui5/sendfaxdialog.py
++++ b/ui5/sendfaxdialog.py
+@@ -325,9 +325,11 @@ class SendFaxDialog(QDialog, Ui_Dialog):
+ 
+     def toggleCoverPage(self, b):
+         # XXX: qt5port: disconnect method requires attention
+-        self.CoverPageGroupBox.toggled[bool].disconnect(self.CoverPageGroupBox_toggled)
++        if coverpages_enabled:
++            self.CoverPageGroupBox.toggled[bool].disconnect(self.CoverPageGroupBox_toggled)
+         self.CoverPageGroupBox.setChecked(b)
+-        self.CoverPageGroupBox.toggled[bool].connect(self.CoverPageGroupBox_toggled)
++        if coverpages_enabled:
++            self.CoverPageGroupBox.toggled[bool].connect(self.CoverPageGroupBox_toggled)
+ 
+ 
+     #
+-- 
+2.24.1
+

hplip.changes

@@ -1,14 +1,56 @@
+-------------------------------------------------------------------
+Fri Jan 10 13:52:53 UTC 2020 - Martin Wilck <mwilck@suse.com>
+
+- Fix crash if python3-reportlab is missing (bsc#1159240, lp#1859179)
+  * Added hp-sendfax-avoid-crash-if-python-reportlab-is-missin.patch
+  * Added recommends on python3-reportlab
+
 -------------------------------------------------------------------
 Thu Jan  9 11:54:45 UTC 2020 - Johannes Weberhofer <jweberhofer@weberhofer.at>
 
 - updated to 3.19.12
 
-  * hp-uiscan will fetch the paper sizes from the device dynamically for ScanJet devices.
+  Rendering print jobs with cupsfilter command 
-  * hp-uiscan will prompt error message when paper jam occurs for ScanJet devices.
+  Added support for the following new Printers:
-  * Added Supported for “hp-uiscan” to scan only backside of a page
-  * Rendering print jobs with cupsfilter command 
 
-  Added Job Accounting Support for the following devices
+  * HP Color LaserJet Pro M256dn
+  * HP Color LaserJet Pro M255dn
+  * HP Color LaserJet Pro M256nw
+  * HP Color LaserJet Pro M255nw
+  * HP Color LaserJet Pro M256dw
+  * HP Color LaserJet Pro M255dw
+  * HP Color LaserJet Pro M155a
+  * HP Color LaserJet Pro M156a
+  * HP Color LaserJet Pro M155nw
+  * HP Color LaserJet Pro M156nw
+  * HP Color LaserJet Pro MFP M282nw
+  * HP Color LaserJet Pro MFP M284nw
+  * HP Color LaserJet Pro MFP M283fdn
+  * HP Color LaserJet Pro MFP M285fdn
+  * HP Color LaserJet Pro MFP M283fdw
+  * HP Color LaserJet Pro MFP M285fdw
+  * HP Color LaserJet Pro MFP M283cdw
+  * HP Color LaserJet Pro MFP M285cdw
+  * HP Color LaserJet Pro MFP M182n
+  * HP Color LaserJet Pro MFP M184n
+  * HP Color LaserJet Pro MFP M182nw
+  * HP Color LaserJet Pro MFP M184nw
+  * HP Color LaserJet Pro MFP M183fw
+  * HP Color LaserJet Pro MFP M185fw
+
+- updated to 3.19.11
+
+  Added Supported for “hp-uiscan” to scan only backside of a page
+
+  Added support for the following new Printers:
+  * HP Color LaserJet MFP M776dn
+  * HP Color LaserJet Flow MFP M776z
+  * HP Color LaserJet Flow MFP M776zs
+  * HP Color LaserJet M856dn
+  * HP Color LaserJet M856x
+  * HP Color LaserJet E85055dn
+
+  Added Job Accounting Support for the following devices:
   * HP LaserJet Managed Flow MFP E77822-28-30 Printer
   * HP LaserJet Managed MFP E77822-28-30 Printer
   * HP LaserJet Managed Flow MFP E87640-50-60 Printer
@@ -18,36 +60,11 @@ Thu Jan  9 11:54:45 UTC 2020 - Johannes Weberhofer <jweberhofer@weberhofer.at>
   * HP LaserJet Managed Flow MFP E72525-30-35 Printer
   * HP LaserJet Managed MFP E72525-30-35 Printer
 
+- updated to 3.19.8
+  hp-uiscan will fetch the paper sizes from the device dynamically for ScanJet devices.
+  hp-uiscan will prompt error message when paper jam occurs for ScanJet devices.
+
   Added support for the following new Printers:
-  * HP Color LaserJet E85055dn
-  * HP Color LaserJet Flow MFP M776z
-  * HP Color LaserJet Flow MFP M776zs
-  * HP Color LaserJet M856dn
-  * HP Color LaserJet M856x
-  * HP Color LaserJet Pro M155a
-  * HP Color LaserJet Pro M155nw
-  * HP Color LaserJet Pro M156a
-  * HP Color LaserJet Pro M156nw
-  * HP Color LaserJet Pro M255dn
-  * HP Color LaserJet Pro M255dw
-  * HP Color LaserJet Pro M255nw
-  * HP Color LaserJet Pro M256dn
-  * HP Color LaserJet Pro M256dw
-  * HP Color LaserJet Pro M256nw
-  * HP Color LaserJet Pro MFP M182n
-  * HP Color LaserJet Pro MFP M182nw
-  * HP Color LaserJet Pro MFP M183fw
-  * HP Color LaserJet Pro MFP M184n
-  * HP Color LaserJet Pro MFP M184nw
-  * HP Color LaserJet Pro MFP M185fw-HP Color LaserJet MFP M776dn
-  * HP Color LaserJet Pro MFP M282nw
-  * HP Color LaserJet Pro MFP M283cdw
-  * HP Color LaserJet Pro MFP M283fdn
-  * HP Color LaserJet Pro MFP M283fdw
-  * HP Color LaserJet Pro MFP M284nw
-  * HP Color LaserJet Pro MFP M285cdw
-  * HP Color LaserJet Pro MFP M285fdn
-  * HP Color LaserJet Pro MFP M285fdw
   * HP DesignJet T1530 Postscript
   * HP DesignJet T1600 Postscript Printer
   * HP DesignJet T1600dr Postscript Printer

hplip.spec

@@ -72,6 +72,8 @@ Patch301:       hplip-misc-missing-includes-and-definitions.patch
 Patch302:       hp_ipp.h-add-missing-prototypes.patch
 # Fix import error for pcardext
 Patch303:       photocard-fix-import-error-for-pcardext.patch
+# bsc#1159240, lp#1859179
+Patch304:       hp-sendfax-avoid-crash-if-python-reportlab-is-missin.patch
 # PATCH-FIX-SUSE: Remove references to the closed-source ImageProcessor
 Patch400:       hplip-remove-imageprocessor.diff
 # Let a function return NULL instead of nothing
@@ -150,6 +152,7 @@ Requires(post): coreutils
 Obsoletes:      hplip17
 Provides:       hplip3 = 3.9.5
 Obsoletes:      hplip3 < 3.9.5
+Recommends:     python3-reportlab
 %if 0%{?with_new_pycups}
 # All printer driver packages should have "BuildRequires: cups-rpm-helper"
 # for automatic generation of Provides: tags.
@@ -307,6 +310,7 @@ This sub-package is only required by developers.
 %patch301 -p1 -b .misc-headers
 %patch302 -p1 -b .hp_ipp_missing_prototypes
 %patch303 -p1 -b .photocard_import
+%patch304 -p1
 %patch400 -p1
 %patch401 -p1
 %patch402 -p1