Accepting request 237250 from home:trenn:branches:Base:System

- Really fillup (and create) /etc/sysconfig/irqbalance file
- Remove IRQBALANCE_ONESHOT variable from sysconfig file.
  Default IRQBALANCE_ONESHOT=auto will be interpreted as --oneshot, other
  than documented in /etc/sysconfig/irqbalance. The same can be achieved via
  passing --oneshot via newly introduced IRQBALANCE_ARGS= variable (see below)
  bnc#874125
- The irqbalance.service file passes $IRQBALANCE_ARGS when the daemon
  is started. Provide it for the user via /etc/sysconfig/irqbalance.

OBS-URL: https://build.opensuse.org/request/show/237250
OBS-URL: https://build.opensuse.org/package/show/Base:System/irqbalance?expand=0&rev=37

irqbalance.changes

@@ -1,3 +1,15 @@
+-------------------------------------------------------------------
+Fri Jun 13 15:43:32 UTC 2014 - trenn@suse.de
+
+- Really fillup (and create) /etc/sysconfig/irqbalance file
+- Remove IRQBALANCE_ONESHOT variable from sysconfig file.
+  Default IRQBALANCE_ONESHOT=auto will be interpreted as --oneshot, other
+  than documented in /etc/sysconfig/irqbalance. The same can be achieved via
+  passing --oneshot via newly introduced IRQBALANCE_ARGS= variable (see below)
+  bnc#874125
+- The irqbalance.service file passes $IRQBALANCE_ARGS when the daemon
+  is started. Provide it for the user via /etc/sysconfig/irqbalance.
+
 -------------------------------------------------------------------
 Wed Dec 11 13:50:43 UTC 2013 - dvaleev@suse.com
 

irqbalance.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package irqbalance
 #
-# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -68,7 +68,7 @@ ln -s /usr/sbin/service %{buildroot}%{_sbindir}/rcirq_balancer
 %service_add_pre irqbalance.service
 
 %post
-%fillup_only
+%fillup_only %{name}
 %service_add_post irqbalance.service
 
 %preun

sysconfig.irqbalance

@@ -3,25 +3,15 @@
 
 ## Type:	string
 ## Default:	""
-## ServiceRestart:	irq_balancer
+## ServiceRestart:	irqbalance
 #
 # Bitmap of CPUs that are banned from IRQ balancing
 #
 IRQBALANCE_BANNED_CPUS=""
 
-## Type:	list(auto,enabled)
-## Default:	auto
-## ServiceRestart:	Iirq_balancer
-#
-# Instead of running as daemon, the IRQ balancer just does a setup
-# once and then exits. "auto" is the default behaviour which means that
-# the service is started as daemon.
-#
-IRQBALANCE_ONESHOT=auto
-
 ## Type:	string
 ## Default:	""
-## ServiceRestart:	Iirq_balancer
+## ServiceRestart:	irqbalance
 #
 # Interrupt that don't get balanced as list (separation character doesn't
 # matter). For example broken chipsets don't allow the timer interrupt
@@ -30,3 +20,12 @@ IRQBALANCE_ONESHOT=auto
 #
 IRQBALANCE_BANNED_INTERRUPTS=""
 
+## Type:        string
+## Default:     ""
+## ServiceRestart:     irqbalance
+#
+# Pass specific irqbalance(1) options when the service is started via
+# systemctl. For example --debug will show additional output via
+# systemctl status irqbalance
+#
+IRQBALANCE_ARGS=""