29 lines
1.1 KiB
Diff
29 lines
1.1 KiB
Diff
|
From d35b88c1b25fe13715f9170f18674d476ca9acdc Mon Sep 17 00:00:00 2001
|
||
|
|
From: Matthias Gerstner <mgerstner@suse.de>
|
||
|
|
Date: Thu, 24 Sep 2020 17:03:06 +0200
|
||
|
|
Subject: [PATCH 2/9] Fix use after free in LanLinkProvider::connectError()
|
||
|
|
|
||
|
|
If QSslSocket::connectToHost() hasn't finished running.
|
||
|
|
|
||
|
|
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
|
||
|
|
---
|
||
|
|
core/backends/lan/lanlinkprovider.cpp | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/core/backends/lan/lanlinkprovider.cpp b/core/backends/lan/lanlinkprovider.cpp
|
||
|
|
index fc005cee..235c221f 100644
|
||
|
|
--- a/core/backends/lan/lanlinkprovider.cpp
|
||
|
|
+++ b/core/backends/lan/lanlinkprovider.cpp
|
||
|
|
@@ -252,7 +252,7 @@ void LanLinkProvider::connectError(QAbstractSocket::SocketError socketError)
|
||
|
|
//The socket we created didn't work, and we didn't manage
|
||
|
|
//to create a LanDeviceLink from it, deleting everything.
|
||
|
|
delete m_receivedIdentityPackets.take(socket).np;
|
||
|
|
- delete socket;
|
||
|
|
+ socket->deleteLater();
|
||
|
|
}
|
||
|
|
|
||
|
|
//We received a UDP packet and answered by connecting to them by TCP. This gets called on a successful connection.
|
||
|
|
--
|
||
|
|
2.28.0
|
||
|
|
|