ksystemlog/Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch
Luca Beltrame fa715b5a80 Accepting request 809407 from home:wolfi323:branches:KDE:Applications
- Add patch to fix a possible crash when closing the window:
  (boo#1164633, kde#409375)
  * Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch

OBS-URL: https://build.opensuse.org/request/show/809407
OBS-URL: https://build.opensuse.org/package/show/KDE:Applications/ksystemlog?expand=0&rev=129
2020-05-28 09:59:15 +00:00

30 lines
937 B
Diff

From eeab31a116535efc6d4757f027897265736ed161 Mon Sep 17 00:00:00 2001
From: Wolfgang Bauer <wbauer@tmo.at>
Date: Sun, 17 May 2020 20:22:45 +0000
Subject: Disconnect `QtabWidget::currentChanged` signal on window close event
Otherwise `MainWindow::changeCurrentTab()` may still get called when things are already being destroyed, leading to crashes.
BUG: 409375
FIXED-IN: 20.04.2
---
src/mainWindow.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainWindow.cpp b/src/mainWindow.cpp
index 3607f6c..a30449c 100644
--- a/src/mainWindow.cpp
+++ b/src/mainWindow.cpp
@@ -350,6 +350,8 @@ void MainWindow::updateReloading()
void MainWindow::closeEvent(QCloseEvent *event)
{
+ disconnect(d->tabs, &QTabWidget::currentChanged, this, &MainWindow::changeCurrentTab);
+
LogManager *currentLogManager = d->tabs->activeLogManager();
if (currentLogManager) {
currentLogManager->stopWatching();
--
cgit v1.1