This commit is contained in:
parent
c564b8969a
commit
b1940fc096
@ -1,60 +0,0 @@
|
|||||||
From 41bd04234b104312f54d25822f68738ba8d7133d Mon Sep 17 00:00:00 2001
|
|
||||||
From: Marcus Meissner <marcus@jet.franken.de>
|
|
||||||
Date: Tue, 25 Jul 2017 23:44:44 +0200
|
|
||||||
Subject: [PATCH] fixes some (not all) buffer overreads during decoding pentax
|
|
||||||
makernote entries.
|
|
||||||
|
|
||||||
This should fix:
|
|
||||||
https://sourceforge.net/p/libexif/bugs/125/ CVE-2016-6328
|
|
||||||
---
|
|
||||||
libexif/pentax/mnote-pentax-entry.c | 16 +++++++++++++---
|
|
||||||
1 file changed, 13 insertions(+), 3 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/libexif/pentax/mnote-pentax-entry.c b/libexif/pentax/mnote-pentax-entry.c
|
|
||||||
index d03d159..ea0429a 100644
|
|
||||||
--- a/libexif/pentax/mnote-pentax-entry.c
|
|
||||||
+++ b/libexif/pentax/mnote-pentax-entry.c
|
|
||||||
@@ -425,24 +425,34 @@ mnote_pentax_entry_get_value (MnotePentaxEntry *entry,
|
|
||||||
case EXIF_FORMAT_SHORT:
|
|
||||||
{
|
|
||||||
const unsigned char *data = entry->data;
|
|
||||||
- size_t k, len = strlen(val);
|
|
||||||
+ size_t k, len = strlen(val), sizeleft;
|
|
||||||
+
|
|
||||||
+ sizeleft = entry->size;
|
|
||||||
for(k=0; k<entry->components; k++) {
|
|
||||||
+ if (sizeleft < 2)
|
|
||||||
+ break;
|
|
||||||
vs = exif_get_short (data, entry->order);
|
|
||||||
snprintf (val+len, maxlen-len, "%i ", vs);
|
|
||||||
len = strlen(val);
|
|
||||||
data += 2;
|
|
||||||
+ sizeleft -= 2;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
case EXIF_FORMAT_LONG:
|
|
||||||
{
|
|
||||||
const unsigned char *data = entry->data;
|
|
||||||
- size_t k, len = strlen(val);
|
|
||||||
+ size_t k, len = strlen(val), sizeleft;
|
|
||||||
+
|
|
||||||
+ sizeleft = entry->size;
|
|
||||||
for(k=0; k<entry->components; k++) {
|
|
||||||
+ if (sizeleft < 4)
|
|
||||||
+ break;
|
|
||||||
vl = exif_get_long (data, entry->order);
|
|
||||||
snprintf (val+len, maxlen-len, "%li", (long int) vl);
|
|
||||||
len = strlen(val);
|
|
||||||
data += 4;
|
|
||||||
+ sizeleft -= 4;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
@@ -455,5 +465,5 @@ mnote_pentax_entry_get_value (MnotePentaxEntry *entry,
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
- return (val);
|
|
||||||
+ return val;
|
|
||||||
}
|
|
@ -1,20 +0,0 @@
|
|||||||
Index: libexif/exif-data.c
|
|
||||||
===================================================================
|
|
||||||
RCS file: /cvsroot/libexif/libexif/libexif/exif-data.c,v
|
|
||||||
retrieving revision 1.131
|
|
||||||
diff -u -r1.131 exif-data.c
|
|
||||||
--- libexif/exif-data.c 12 Jul 2012 17:28:26 -0000 1.131
|
|
||||||
+++ libexif/exif-data.c 25 Jul 2017 21:34:06 -0000
|
|
||||||
@@ -255,6 +255,12 @@
|
|
||||||
exif_mnote_data_set_offset (data->priv->md, *ds - 6);
|
|
||||||
exif_mnote_data_save (data->priv->md, &e->data, &e->size);
|
|
||||||
e->components = e->size;
|
|
||||||
+ if (exif_format_get_size (e->format) != 1) {
|
|
||||||
+ /* e->format is taken from input code,
|
|
||||||
+ * but we need to make sure it is a 1 byte
|
|
||||||
+ * entity due to the multiplication below. */
|
|
||||||
+ e->format = EXIF_FORMAT_UNDEFINED;
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user