pool/libfabric
SHA256
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accepting request 1008574 from science:HPC

Browse Source 
OBS-URL: https://build.opensuse.org/request/show/1008574
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/libfabric?expand=0&rev=35
This commit is contained in:
Fabian Vogt 2022-10-10 16:43:27 +00:00 committed by Git OBS Bridge
commit 99fd313f39
5 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fabtests.changes
View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Thu Oct 6 16:06:29 UTC 2022 - Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
- Add prov-rxm-Disable-128-bit-atomics.patch to fix a potential
segfault on misaligned buffers.
-------------------------------------------------------------------
Fri Sep 30 11:44:45 UTC 2022 - Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>

2
fabtests.spec
View File

@ -28,6 +28,7 @@ URL: http://www.github.com/ofiwg/libfabric
Source: libfabric-%{version}%{git_ver}.tar.bz2
Source1: fabtests-rpmlintrc
Patch0: libfabric-libtool.patch
Patch1: prov-rxm-Disable-128-bit-atomics.patch
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libfabric-devel = %{version}
@ -40,6 +41,7 @@ Fabtests provides a set of examples that uses libfabric, a fabric software libra
%prep
%setup -q -n libfabric-%{version}%{git_ver}
%patch0 -p1
%patch1
%build
cd fabtests

6
libfabric.changes
View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Thu Oct 6 16:06:29 UTC 2022 - Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
- Add prov-rxm-Disable-128-bit-atomics.patch to fix a potential
segfault on misaligned buffers.
-------------------------------------------------------------------
Fri Sep 30 11:44:45 UTC 2022 - Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>

2
libfabric.spec
View File

@ -28,6 +28,7 @@ Group: Development/Libraries/C and C++
Source: %{name}-%{version}%{git_ver}.tar.bz2
Source1: baselibs.conf
Patch0: libfabric-libtool.patch
Patch1: prov-rxm-Disable-128-bit-atomics.patch
URL: http://www.github.com/ofiwg/libfabric
BuildRequires: autoconf
BuildRequires: automake
@ -70,6 +71,7 @@ services, such as RDMA. This package contains the development files.
%prep
%setup -q -n %{name}-%{version}%{git_ver}
%patch0 -p1
%patch1
%build
rm -f config/libtool.m4

32
prov-rxm-Disable-128-bit-atomics.patch Normal file
View File

@ -0,0 +1,32 @@
commit 740b5e9daa2319f7397797f2f17d8e56245fdce4
Author: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Date: Thu Oct 6 18:02:38 2022 +0200
prov/rxm: Disable 128-bit atomics
128-bit atomics fail (cause segfault) in release build of
provider. Cause is likely related to alignment. Fail
query calls for 128-bit integers to indicate support is not
provided.
https://github.com/ofiwg/libfabric/issues/7248
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
diff --git prov/rxm/src/rxm_atomic.c prov/rxm/src/rxm_atomic.c
index 28e29ade0dde..0f070b92f446 100644
--- prov/rxm/src/rxm_atomic.c
+++ prov/rxm/src/rxm_atomic.c
@@ -509,6 +509,12 @@ int rxm_ep_query_atomic(struct fid_domain *domain, enum fi_datatype datatype,
return -FI_EINVAL;
}
+ if ((datatype == FI_INT128) || (datatype == FI_UINT128)) {
+ FI_WARN(&rxm_prov, FI_LOG_EP_CTRL,
+ "128-bit integers not supported\n");
+ return -FI_EOPNOTSUPP;
+ }
+
ret = ofi_atomic_valid(&rxm_prov, datatype, op, flags);
if (ret || !attr)
return ret;