Accepting request 1226522 from security:forensics

- Update 0001-Export-libfvalue_value_get_entry.patch so libnk2
  does not fail to build

OBS-URL: https://build.opensuse.org/request/show/1226522
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/libfvalue?expand=0&rev=13

0001-Export-libfvalue_value_get_entry.patch

@@ -0,0 +1,92 @@
+From 9829f2df776a28ac373a3235030123bcd902a06f Mon Sep 17 00:00:00 2001
+From: Jan Engelhardt <jengelh@inai.de>
+Date: Sat, 2 Nov 2024 16:36:19 +0100
+Subject: [PATCH] Export libfvalue_value_get_entry
+References: https://github.com/libyal/libfvalue/issues/6
+References: https://github.com/libyal/libfvalue/pull/7
+
+libesedb_multi_value.c:338:13: error: implicit declaration of function 'libfvalue_value_get_entry'; did you mean 'libfvalue_value_get_data'? [-Wimplicit-function-declaration]
+libesedb_multi_value.c:385:13: error: implicit declaration of function 'libfvalue_value_copy_entry_data'; did you mean 'libfvalue_value_set_entry_data'? [-Wimplicit-function-declaration]
+libesedb_record.c:3813:29: error: implicit declaration of function 'libfvalue_value_append_entry'; did you mean 'libfvalue_value_append_entry_data'? [-Wimplicit-function-declaration]
+libesedb_value_data_handle.c:175:29: error: implicit declaration of function 'libfvalue_data_handle_append_value_entry'; did you mean 'libfvalue_data_handle_append_value_entry_data'? [-Wimplicit-function-declaration]
+
+``libfvalue_value_get_entry`` et al is used externally, by libesedb.
+Hence, it needs to be exported for DLLs to work correctly. This patch
+corrects that problem.
+---
+ include/libfvalue.h.in |   34 ++++++++++++++++++++++++++++++++++
+ 1 file changed, 34 insertions(+)
+
+Index: libfvalue-20240415/include/libfvalue.h.in
+===================================================================
+--- libfvalue-20240415.orig/include/libfvalue.h.in
++++ libfvalue-20240415/include/libfvalue.h.in
+@@ -28,6 +28,7 @@
+ #include <libfvalue/extern.h>
+ #include <libfvalue/features.h>
+ #include <libfvalue/types.h>
++#include <libcerror/types.h>
+ 
+ #include <stdio.h>
+ 
+@@ -210,6 +211,14 @@ int libfvalue_data_handle_set_value_entr
+      int encoding,
+      libfvalue_error_t **error );
+ 
++LIBFVALUE_EXTERN \
++int libfvalue_data_handle_append_value_entry(
++     libfvalue_data_handle_t *data_handle,
++     int *value_entry_index,
++     size_t value_entry_offset,
++     size_t value_entry_size,
++     libcerror_error_t **error );
++
+ /* Appends a value entry
+  * Returns if successful or -1 on error
+  */
+@@ -943,6 +952,14 @@ int libfvalue_value_get_number_of_value_
+      int *number_of_value_entries,
+      libfvalue_error_t **error );
+ 
++LIBFVALUE_EXTERN \
++int libfvalue_value_get_entry(
++     libfvalue_value_t *value,
++     int value_entry_index,
++     size_t *entry_data_offset,
++     size_t *entry_data_size,
++     libcerror_error_t **error );
++
+ /* Retrieves the entry data
+  * Returns 1 if successful, 0 if the value has no data or -1 on error
+  */
+@@ -967,6 +984,14 @@ int libfvalue_value_set_entry_data(
+      int encoding,
+      libfvalue_error_t **error );
+ 
++LIBFVALUE_EXTERN \
++int libfvalue_value_append_entry(
++     libfvalue_value_t *value,
++     int *value_entry_index,
++     size_t entry_data_offset,
++     size_t entry_data_size,
++     libcerror_error_t **error );
++
+ /* Appends the entry data
+  * Returns 1 if successful or -1 on error
+  */
+@@ -979,6 +1004,15 @@ int libfvalue_value_append_entry_data(
+      int encoding,
+      libfvalue_error_t **error );
+ 
++LIBFVALUE_EXTERN \
++int libfvalue_value_copy_entry_data(
++     libfvalue_value_t *value,
++     int value_entry_index,
++     uint8_t *entry_data,
++     size_t entry_data_size,
++     int *encoding,
++     libcerror_error_t **error );
++
+ /* Copies the value data from a boolean value
+  * Returns 1 if successful, 0 if value could not be set or -1 on error
+  */

_scmsync.obsinfo

@@ -0,0 +1,4 @@
+mtime: 1732626484
+commit: 2332cb9e6c98d514ecf810387f0f990b5d6a9f715f93a2d5e92d5f6dad52c4a9
+url: https://src.opensuse.org/jengelh/libfvalue
+revision: master

build.specials.obscpio

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:6eb42f6acd24c8664d1bce560d3b6cbb2179aa83bec382dc85b17839325f46c1
+size 256

libfvalue.changes

@@ -1,3 +1,14 @@
+-------------------------------------------------------------------
+Mon Nov 25 16:55:09 UTC 2024 - Jan Engelhardt <jengelh@inai.de>
+
+- Update 0001-Export-libfvalue_value_get_entry.patch so libnk2
+  does not fail to build
+
+-------------------------------------------------------------------
+Sat Nov  2 16:03:42 UTC 2024 - Jan Engelhardt <jengelh@inai.de>
+
+- Add 0001-Export-libfvalue_value_get_entry.patch
+
 -------------------------------------------------------------------
 Mon Apr 15 20:06:32 UTC 2024 - Jan Engelhardt <jengelh@inai.de>
 

libfvalue.spec

@@ -27,6 +27,7 @@ URL:            https://github.com/libyal/libfvalue
 Source:         https://github.com/libyal/libfvalue/releases/download/%version/libfvalue-experimental-%version.tar.gz
 Source2:        https://github.com/libyal/libfvalue/releases/download/%version/libfvalue-experimental-%version.tar.gz.asc
 Source9:        %name.keyring
+Patch1:         0001-Export-libfvalue_value_get_entry.patch
 BuildRequires:  c_compiler
 BuildRequires:  pkg-config
 BuildRequires:  pkgconfig(libcdata) >= 20240414