Commit Graph

1 Commits

Author SHA256 Message Date
d2915c3e86 Accepting request 264334 from home:chorler:branches:security:netfilter
I'm experimenting with conntrack / conntrackd, when running nfct I got a segfault.

The segfault is fixed by moving the first free:

GDB shows the segfault on free of the pointer 0x45454545...  Valgrind shows me this:
==5278== Invalid read of size 8
==5278==    at 0x523E970: nfct_helper_free (libnetfilter_cthelper.c:118)
==5278==    by 0x403361: nfct_cmd_helper_add (helper.c:249)
==5278==    by 0x401EB0: main (nfct.c:77)
==5278==  Address 0x59f4618 is 40 bytes inside a block of size 80 free'd
==5278==    at 0x4C28ADC: free (vg_replace_malloc.c:446)
==5278==    by 0x523E96F: nfct_helper_free (libnetfilter_cthelper.c:116)
==5278==    by 0x403361: nfct_cmd_helper_add (helper.c:249)
==5278==    by 0x401EB0: main (nfct.c:77)

OBS-URL: https://build.opensuse.org/request/show/264334
OBS-URL: https://build.opensuse.org/package/show/security:netfilter/libnetfilter_cthelper?expand=0&rev=20
2014-12-08 17:16:34 +00:00