pool/libnma
SHA256
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accepting request 794787 from home:JonathanKang:branches:GNOME:Factory

Browse Source 
- Add libnma-fix-segment-fault.patch: nma-ws: properly dispose
  wireless security objects(bsc#1168347 glgo#GNOME/libnma#7).

OBS-URL: https://build.opensuse.org/request/show/794787
OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/libnma?expand=0&rev=9
This commit is contained in:
Dominique Leuenberger 2020-04-17 07:58:27 +00:00 committed by Git OBS Bridge
parent f6aa816c9d
commit 7132f703bb
3 changed files with 94 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
libnma-fix-segment-fault.patch Normal file
View File

@ -0,0 +1,86 @@
From c901762a4c310bc651590df11152d2fbbf5aa9c1 Mon Sep 17 00:00:00 2001
From: Beniamino Galvani <bgalvani@redhat.com>
Date: Sat, 11 Apr 2020 15:44:17 +0200
Subject: [PATCH] nma-ws: properly dispose wireless security objects
Chain up to parent to properly free resources on dispose().
Fixes: b61cc1b9fa040 ("nma-ws: add")
https://gitlab.gnome.org/GNOME/libnma/-/issues/7
---
src/nma-ws/nma-ws-802-1x.c | 2 ++
src/nma-ws/nma-ws-leap.c | 2 ++
src/nma-ws/nma-ws-sae.c | 2 ++
src/nma-ws/nma-ws-wep-key.c | 2 ++
src/nma-ws/nma-ws-wpa-psk.c | 2 ++
5 files changed, 10 insertions(+)
diff --git a/src/nma-ws/nma-ws-802-1x.c b/src/nma-ws/nma-ws-802-1x.c
index ba348266..0c148ce5 100644
--- a/src/nma-ws/nma-ws-802-1x.c
+++ b/src/nma-ws/nma-ws-802-1x.c
@@ -482,6 +482,8 @@ dispose (GObject *object)
g_clear_pointer (&self->secrets_hints, g_strfreev);
g_clear_pointer (&self->username, g_free);
g_clear_pointer (&self->password, g_free);
+
+ G_OBJECT_CLASS (nma_ws_802_1x_parent_class)->dispose (object);
}
static void
diff --git a/src/nma-ws/nma-ws-leap.c b/src/nma-ws/nma-ws-leap.c
index f90d43aa..df6d2dde 100644
--- a/src/nma-ws/nma-ws-leap.c
+++ b/src/nma-ws/nma-ws-leap.c
@@ -260,6 +260,8 @@ dispose (GObject *object)
NMAWsLeap *self = NMA_WS_LEAP (object);
g_clear_object (&self->connection);
+
+ G_OBJECT_CLASS (nma_ws_leap_parent_class)->dispose (object);
}
static void
diff --git a/src/nma-ws/nma-ws-sae.c b/src/nma-ws/nma-ws-sae.c
index e3454bbd..00fb6ff5 100644
--- a/src/nma-ws/nma-ws-sae.c
+++ b/src/nma-ws/nma-ws-sae.c
@@ -252,6 +252,8 @@ dispose (GObject *object)
NMAWsSae *self = NMA_WS_SAE (object);
g_clear_object (&self->connection);
+
+ G_OBJECT_CLASS (nma_ws_sae_parent_class)->dispose (object);
}
static void
diff --git a/src/nma-ws/nma-ws-wep-key.c b/src/nma-ws/nma-ws-wep-key.c
index cae8c272..992aabf7 100644
--- a/src/nma-ws/nma-ws-wep-key.c
+++ b/src/nma-ws/nma-ws-wep-key.c
@@ -404,6 +404,8 @@ dispose (GObject *object)
NMAWsWepKey *self = NMA_WS_WEP_KEY (object);
g_clear_object (&self->connection);
+
+ G_OBJECT_CLASS (nma_ws_wep_key_parent_class)->dispose (object);
}
static void
diff --git a/src/nma-ws/nma-ws-wpa-psk.c b/src/nma-ws/nma-ws-wpa-psk.c
index 1c73922a..27604960 100644
--- a/src/nma-ws/nma-ws-wpa-psk.c
+++ b/src/nma-ws/nma-ws-wpa-psk.c
@@ -270,6 +270,8 @@ dispose (GObject *object)
NMAWsWpaPsk *self = NMA_WS_WPA_PSK (object);
g_clear_object (&self->connection);
+
+ G_OBJECT_CLASS (nma_ws_wpa_psk_parent_class)->dispose (object);
}
static void
--
2.24.1

6
libnma.changes
View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Fri Apr 17 06:59:36 UTC 2020 - Jonathan Kang <songchuan.kang@suse.com>
- Add libnma-fix-segment-fault.patch: nma-ws: properly dispose
wireless security objects(bsc#1168347 glgo#GNOME/libnma#7).
-------------------------------------------------------------------
Fri Mar 6 19:15:04 UTC 2020 - Bjørn Lie <bjorn.lie@gmail.com>

2
libnma.spec
View File

@ -26,6 +26,8 @@ Summary: Shared library for NetworkManager-applet
License: GPL-2.0-or-later
URL: https://gitlab.gnome.org/GNOME/libnma
Source0: https://download.gnome.org/sources/%{name}/%{base_ver}/%{name}-%{version}.tar.xz
# PATCH-FIX-UPSTREAM libnma-fix-segment-fault.patch bsc#1168347 glgo#GNOME/libnma#7 sckang@suse.com -- nma-ws: properly dispose wireless security objects.
Patch0: libnma-fix-segment-fault.patch
BuildRequires: gtk-doc
BuildRequires: meson