Accepting request 798290 from GNOME:Factory

OBS-URL: https://build.opensuse.org/request/show/798290
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/libproxy?expand=0&rev=76
This commit is contained in:
Dominique Leuenberger 2020-04-29 18:41:54 +00:00 committed by Git OBS Bridge
commit 15fea2803f
3 changed files with 35 additions and 0 deletions

View File

@ -0,0 +1,26 @@
From 29c908647eec8e05674ba1c298d4f1c565d9f872 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Corentin=20No=C3=ABl?= <corentin@elementary.io>
Date: Sun, 26 Apr 2020 11:54:46 +0200
Subject: [PATCH] pxgsettings: use the correct syntax to connect to the changed
signal
As it is a detailed signal, it only makes sense to append a :: when there is a specific property to target.
It used to be accepted but triggers a runtime warning with latest GLib.
---
libproxy/modules/pxgsettings.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libproxy/modules/pxgsettings.cpp b/libproxy/modules/pxgsettings.cpp
index 9ed4333..0db5a6a 100644
--- a/libproxy/modules/pxgsettings.cpp
+++ b/libproxy/modules/pxgsettings.cpp
@@ -158,7 +158,7 @@ int main(int argc, char **argv) {
#else
gchar** keys = g_settings_list_keys(settings);
#endif
- g_signal_connect(settings, "changed::", G_CALLBACK (on_value_change), argv[i]);
+ g_signal_connect(settings, "changed", G_CALLBACK (on_value_change), argv[i]);
for (int j=0; keys[j]; on_value_change(settings, keys[j++],argv[i] ));
g_strfreev(keys);
}

View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Apr 27 10:10:47 UTC 2020 - Dominique Leuenberger <dimstar@opensuse.org>
- Add libproxy-pxgsettings.patch: pxgsettings: use the correct
syntax to connect to the changed signal.
-------------------------------------------------------------------
Thu Mar 12 07:10:15 UTC 2020 - Tomáš Chvátal <tchvatal@suse.com>

View File

@ -49,6 +49,8 @@ Source: https://github.com/libproxy/%{_name}/archive/%{version}.tar.gz
Source99: baselibs.conf
# PATCH-FIX-UPSTREAM libproxy-python3.7.patch dimstar@opensuse.org -- Add support for python 3.7 and 3.8, taken from upstream
Patch0: libproxy-python3.7.patch
# PATCH-FIX-UPSTREAM libproxy-pxgsettings.patch dimstar@opensuse.org -- pxgsettings: use the correct syntax to connect to the changed signal
Patch1: libproxy-pxgsettings.patch
BuildRequires: cmake
BuildRequires: gcc-c++
BuildRequires: libmodman-devel
@ -273,6 +275,7 @@ This package contains the Mono/.NET for libproxy.
%prep
%setup -q -n %{_sourcename}
%patch0 -p1
%patch1 -p1
mkdir build
%build