2011-12-27 05:11:19 +01:00
|
|
|
From 33a59a1905feb5d786e9d457f287dd9e81a9f747 Mon Sep 17 00:00:00 2001
|
|
|
|
From: =?UTF-8?q?Cristian=20Rodr=C3=ADguez?= <crrodriguez@opensuse.org>
|
|
|
|
Date: Tue, 27 Dec 2011 00:33:28 -0300
|
|
|
|
Subject: [PATCH] Use O_CLOEXEC where needed
|
|
|
|
|
|
|
|
---
|
|
|
|
src/agent.c | 2 +-
|
|
|
|
src/knownhost.c | 4 ++--
|
|
|
|
src/userauth.c | 2 +-
|
|
|
|
3 files changed, 4 insertions(+), 4 deletions(-)
|
|
|
|
|
2013-01-11 15:43:44 +01:00
|
|
|
Index: libssh2-1.4.3/src/agent.c
|
|
|
|
===================================================================
|
|
|
|
--- libssh2-1.4.3.orig/src/agent.c 2012-03-05 20:04:56.000000000 +0100
|
|
|
|
+++ libssh2-1.4.3/src/agent.c 2013-01-08 16:24:07.572195659 +0100
|
2011-12-01 03:46:12 +01:00
|
|
|
@@ -152,7 +152,7 @@ agent_connect_unix(LIBSSH2_AGENT *agent)
|
|
|
|
return _libssh2_error(agent->session, LIBSSH2_ERROR_BAD_USE,
|
|
|
|
"no auth sock variable");
|
|
|
|
|
|
|
|
- agent->fd = socket(PF_UNIX, SOCK_STREAM, 0);
|
2011-12-27 05:11:19 +01:00
|
|
|
+ agent->fd = socket(PF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
|
2011-12-01 03:46:12 +01:00
|
|
|
if (agent->fd < 0)
|
|
|
|
return _libssh2_error(agent->session, LIBSSH2_ERROR_BAD_SOCKET,
|
|
|
|
"failed creating socket");
|
2013-01-11 15:43:44 +01:00
|
|
|
Index: libssh2-1.4.3/src/knownhost.c
|
|
|
|
===================================================================
|
|
|
|
--- libssh2-1.4.3.orig/src/knownhost.c 2012-08-21 20:27:22.000000000 +0200
|
|
|
|
+++ libssh2-1.4.3/src/knownhost.c 2013-01-08 16:24:07.573195691 +0100
|
|
|
|
@@ -907,7 +907,7 @@ libssh2_knownhost_readfile(LIBSSH2_KNOWN
|
2011-12-01 03:46:12 +01:00
|
|
|
"Unsupported type of known-host information "
|
|
|
|
"store");
|
|
|
|
|
|
|
|
- file = fopen(filename, "r");
|
|
|
|
+ file = fopen(filename, "re");
|
|
|
|
if(file) {
|
|
|
|
while(fgets(buf, sizeof(buf), file)) {
|
2013-01-11 15:43:44 +01:00
|
|
|
if(libssh2_knownhost_readline(hosts, buf, strlen(buf), type)) {
|
|
|
|
@@ -1082,7 +1082,7 @@ libssh2_knownhost_writefile(LIBSSH2_KNOW
|
2011-12-01 03:46:12 +01:00
|
|
|
"Unsupported type of known-host information "
|
|
|
|
"store");
|
|
|
|
|
|
|
|
- file = fopen(filename, "w");
|
|
|
|
+ file = fopen(filename, "we");
|
|
|
|
if(!file)
|
|
|
|
return _libssh2_error(hosts->session, LIBSSH2_ERROR_FILE,
|
|
|
|
"Failed to open file");
|
2013-01-11 15:43:44 +01:00
|
|
|
Index: libssh2-1.4.3/src/userauth.c
|
|
|
|
===================================================================
|
|
|
|
--- libssh2-1.4.3.orig/src/userauth.c 2012-04-18 22:24:04.000000000 +0200
|
|
|
|
+++ libssh2-1.4.3/src/userauth.c 2013-01-08 16:24:07.573195691 +0100
|
|
|
|
@@ -467,7 +467,7 @@ file_read_publickey(LIBSSH2_SESSION * se
|
2011-12-01 03:46:12 +01:00
|
|
|
_libssh2_debug(session, LIBSSH2_TRACE_AUTH, "Loading public key file: %s",
|
|
|
|
pubkeyfile);
|
|
|
|
/* Read Public Key */
|
|
|
|
- fd = fopen(pubkeyfile, "r");
|
|
|
|
+ fd = fopen(pubkeyfile, "re");
|
|
|
|
if (!fd) {
|
|
|
|
return _libssh2_error(session, LIBSSH2_ERROR_FILE,
|
|
|
|
"Unable to open public key file");
|