Dirk Mueller
2c0adee1c1
- add test-xattr-don-t-rely-on-NUL-termination.patch (bsc#1202413) OBS-URL: https://build.opensuse.org/request/show/997479 OBS-URL: https://build.opensuse.org/package/show/devel:libraries:c_c++/liburing?expand=0&rev=20
47 lines
1.6 KiB
Diff
47 lines
1.6 KiB
Diff
From: Jiri Slaby <jslaby@suse.cz>
|
|
Date: Tue, 16 Aug 2022 12:44:14 +0200
|
|
Subject: test/xattr: don't rely on NUL-termination
|
|
Patch-mainline: yes
|
|
Git-commit: bf3fedba890e66d644692910964fe1d8cbf4fb1b
|
|
References: bsc#1202413
|
|
|
|
The returned value from io_uring_fgetxattr() needs not be NUL-terminated,
|
|
as we stored non-NUL-terminated string by io_uring_fsetxattr()
|
|
previously.
|
|
|
|
So don't use strlen() on value, but on VALUE1, and VALUE2 respectively.
|
|
|
|
This fixes random test failures.
|
|
|
|
Cc: Stefan Roesch <shr@fb.com>
|
|
Fixes: d6515e06f73c ("liburing: Add new test program to verify xattr support")
|
|
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
|
|
---
|
|
test/xattr.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/test/xattr.c b/test/xattr.c
|
|
index d88059cb..101d82b3 100644
|
|
--- a/test/xattr.c
|
|
+++ b/test/xattr.c
|
|
@@ -210,14 +210,14 @@ static int test_fxattr(void)
|
|
|
|
/* Test reading attributes. */
|
|
value_len = io_uring_fgetxattr(&ring, fd, KEY1, value, XATTR_SIZE);
|
|
- if (value_len != strlen(value) || strncmp(value, VALUE1, value_len)) {
|
|
+ if (value_len != strlen(VALUE1) || strncmp(value, VALUE1, value_len)) {
|
|
fprintf(stderr, "Error: fgetxattr expected value: %s, returned value: %s\n", VALUE1, value);
|
|
rc = -1;
|
|
goto Exit;
|
|
}
|
|
|
|
value_len = io_uring_fgetxattr(&ring, fd, KEY2, value, XATTR_SIZE);
|
|
- if (value_len != strlen(value)|| strncmp(value, VALUE2, value_len)) {
|
|
+ if (value_len != strlen(VALUE2) || strncmp(value, VALUE2, value_len)) {
|
|
fprintf(stderr, "Error: fgetxattr expected value: %s, returned value: %s\n", VALUE2, value);
|
|
rc = -1;
|
|
goto Exit;
|
|
--
|
|
2.35.3
|
|
|