2015-12-04 09:54:48 +01:00
|
|
|
From 3bff82b57564ffc1fe4fff23f9d121fcf410dd5a Mon Sep 17 00:00:00 2001
|
|
|
|
From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= <cbosdonnat@suse.com>
|
|
|
|
Date: Wed, 25 Nov 2015 11:43:56 +0100
|
|
|
|
Subject: [PATCH] Wait for udev events to be handled after removing veth
|
|
|
|
|
|
|
|
As per http://www.redhat.com/archives/libvir-list/2013-July/msg01279.html,
|
|
|
|
wait for udev events to be handled after removing a virtual NIC.
|
|
|
|
Any udev rule associated to NIC destroy could happen to run with a new
|
|
|
|
device with the same name that is being created.
|
|
|
|
---
|
|
|
|
src/lxc/lxc_controller.c | 1 +
|
|
|
|
src/lxc/lxc_driver.c | 2 ++
|
|
|
|
src/lxc/lxc_process.c | 1 +
|
|
|
|
3 files changed, 4 insertions(+)
|
|
|
|
|
2020-07-06 18:35:15 +02:00
|
|
|
Index: libvirt-6.5.0/src/lxc/lxc_controller.c
|
2015-12-18 22:01:20 +01:00
|
|
|
===================================================================
|
2020-07-06 18:35:15 +02:00
|
|
|
--- libvirt-6.5.0.orig/src/lxc/lxc_controller.c
|
|
|
|
+++ libvirt-6.5.0/src/lxc/lxc_controller.c
|
|
|
|
@@ -2028,6 +2028,7 @@ static int virLXCControllerDeleteInterfa
|
2015-12-04 09:54:48 +01:00
|
|
|
if (virNetDevVethDelete(ctrl->veths[i]) < 0)
|
|
|
|
ret = -1;
|
|
|
|
}
|
2017-04-03 06:57:47 +02:00
|
|
|
+ virWaitForDevices();
|
2015-12-04 09:54:48 +01:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
2020-07-06 18:35:15 +02:00
|
|
|
Index: libvirt-6.5.0/src/lxc/lxc_driver.c
|
2015-12-18 22:01:20 +01:00
|
|
|
===================================================================
|
2020-07-06 18:35:15 +02:00
|
|
|
--- libvirt-6.5.0.orig/src/lxc/lxc_driver.c
|
|
|
|
+++ libvirt-6.5.0/src/lxc/lxc_driver.c
|
|
|
|
@@ -66,6 +66,7 @@
|
2017-04-03 06:57:47 +02:00
|
|
|
#include "virtime.h"
|
|
|
|
#include "virtypedparam.h"
|
|
|
|
#include "viruri.h"
|
|
|
|
+#include "virutil.h"
|
|
|
|
#include "virstring.h"
|
|
|
|
#include "viraccessapicheck.h"
|
|
|
|
#include "viraccessapichecklxc.h"
|
2020-07-06 18:35:15 +02:00
|
|
|
@@ -3544,6 +3545,7 @@ lxcDomainAttachDeviceNetLive(virLXCDrive
|
2015-12-04 09:54:48 +01:00
|
|
|
case VIR_DOMAIN_NET_TYPE_NETWORK:
|
Accepting request 400351 from home:jfehlig:branches:Virtualization
- Update to libvirt 1.3.5
- Many incremental improvements and bug fixes, see
http://libvirt.org/news.html
- Dropped patches:
e4d131b8-mv-virDomainDefPostParseInternal.patch,
3e428670-post-parse-implicit-video.patch,
538012c8-default-vram.patch, 96b21fb0-vram-tests.patch,
400e716d-libxl-noprope-emulator.patch,
b90c4b5f-tests-use-qemu-xen.patch,
fccf2725-libxl-API-4.4.patch,
5325123d-libxl-migv2-save-restore.patch,
f9edcfa4-libxl-migv2-migration.patch,
a1c9a81a-libxl-rbd-fix.patch,
ba566428-libxl-dom-iface-addrs.patch
- spec: simplify and cleanup by removing many conditionals that
are never toogled. Also drop conditionals for suse_version <
1310
OBS-URL: https://build.opensuse.org/request/show/400351
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=538
2016-06-07 04:00:39 +02:00
|
|
|
case VIR_DOMAIN_NET_TYPE_ETHERNET:
|
2015-12-04 09:54:48 +01:00
|
|
|
ignore_value(virNetDevVethDelete(veth));
|
2017-04-03 06:57:47 +02:00
|
|
|
+ virWaitForDevices();
|
2015-12-04 09:54:48 +01:00
|
|
|
break;
|
|
|
|
|
|
|
|
case VIR_DOMAIN_NET_TYPE_DIRECT:
|
2020-07-06 18:35:15 +02:00
|
|
|
@@ -3982,6 +3984,7 @@ lxcDomainDetachDeviceNetLive(virDomainOb
|
2015-12-04 09:54:48 +01:00
|
|
|
virDomainAuditNet(vm, detach, NULL, "detach", false);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2017-04-03 06:57:47 +02:00
|
|
|
+ virWaitForDevices();
|
2015-12-04 09:54:48 +01:00
|
|
|
break;
|
|
|
|
|
|
|
|
/* It'd be nice to support this, but with macvlan
|
2020-07-06 18:35:15 +02:00
|
|
|
Index: libvirt-6.5.0/src/lxc/lxc_process.c
|
2015-12-18 22:01:20 +01:00
|
|
|
===================================================================
|
2020-07-06 18:35:15 +02:00
|
|
|
--- libvirt-6.5.0.orig/src/lxc/lxc_process.c
|
|
|
|
+++ libvirt-6.5.0/src/lxc/lxc_process.c
|
2020-03-10 02:55:25 +01:00
|
|
|
@@ -50,6 +50,7 @@
|
|
|
|
#include "virstring.h"
|
2017-04-03 06:57:47 +02:00
|
|
|
#include "virprocess.h"
|
|
|
|
#include "virsystemd.h"
|
|
|
|
+#include "virutil.h"
|
|
|
|
#include "netdev_bandwidth_conf.h"
|
2020-03-10 02:55:25 +01:00
|
|
|
#include "virutil.h"
|
2017-04-03 06:57:47 +02:00
|
|
|
|
2020-07-06 18:35:15 +02:00
|
|
|
@@ -231,6 +232,7 @@ static void virLXCProcessCleanup(virLXCD
|
2019-05-08 21:35:37 +02:00
|
|
|
VIR_WARN("Unable to release network device '%s'", NULLSTR(iface->ifname));
|
2015-12-04 09:54:48 +01:00
|
|
|
}
|
|
|
|
}
|
2017-04-03 06:57:47 +02:00
|
|
|
+ virWaitForDevices();
|
2015-12-04 09:54:48 +01:00
|
|
|
|
|
|
|
virDomainConfVMNWFilterTeardown(vm);
|
|
|
|
|