Accepting request 244865 from Virtualization

Automatic submission by obs-autosubmit

OBS-URL: https://build.opensuse.org/request/show/244865
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/libvirt?expand=0&rev=154

blockcopy-check-dst-identical-device.patch

@@ -0,0 +1,31 @@
+From 475b272c126d53f3985860422dc96b01b470423e Mon Sep 17 00:00:00 2001
+From: Chunyan Liu <cyliu@suse.com>
+Date: Tue, 29 Jul 2014 17:31:28 +0800
+Subject: [PATCH] blockcopy: check dst = identical device
+
+Check whether dst is the same device as source, if yes, report
+error and exit.
+
+Signed-off-by: Chunyan Liu <cyliu@suse.com>
+---
+ src/qemu/qemu_driver.c | 7 +++++++
+ 1 file changed, 7 insertions(+)
+
+Index: libvirt-1.2.7/src/qemu/qemu_driver.c
+===================================================================
+--- libvirt-1.2.7.orig/src/qemu/qemu_driver.c
++++ libvirt-1.2.7/src/qemu/qemu_driver.c
+@@ -15330,6 +15330,13 @@ qemuDomainBlockCopy(virDomainObjPtr vm,
+     }
+ 
+     /* Prepare the destination file.  */
++    if (STREQ_NULLABLE(realpath(disk->src->path, NULL), realpath(dest, NULL))) {
++        virReportError(VIR_ERR_INVALID_ARG,
++                       _("destination '%s' is the same as disk '%s' source"),
++                       dest, path);
++        goto endjob;
++    }
++
+     if (stat(dest, &st) < 0) {
+         if (errno != ENOENT) {
+             virReportSystemError(errno, _("unable to stat for disk %s: %s"),

libvirt.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Fri Aug  8 03:23:10 UTC 2014 - cyliu@suse.com
+
+- bnc#820399 - virsh blockcopy should refuse identical device
+  blockcopy-check-dst-identical-device.patch   
+
 -------------------------------------------------------------------
 Mon Aug  4 09:32:57 MDT 2014 - jfehlig@suse.com
 
@@ -26,6 +32,7 @@ Wed Jul 16 12:07:33 UTC 2014 - cbosdonnat@suse.com
 - added patches:
   * 9265f8ab-apparmor-lxc-rework.patch
   * 9b1e4cd5-skip-useless-apparmor-files.patch
+
 -------------------------------------------------------------------
 Wed Jul 16 11:40:35 UTC 2014 - cbosdonnat@suse.com
 

libvirt.spec

@@ -431,6 +431,7 @@ Source99:       baselibs.conf
 # Need to go upstream
 Patch100:       xen-name-for-devid.patch
 Patch101:       xen-pv-cdrom.patch
+Patch102:       blockcopy-check-dst-identical-device.patch
 # Our patches
 Patch200:       libvirtd-defaults.patch
 Patch201:       libvirtd-init-script.patch
@@ -944,6 +945,7 @@ namespaces.
 %setup -q
 %patch100 -p1
 %patch101 -p1
+%patch102 -p1
 %patch200 -p1
 %patch201 -p1
 %patch202 -p1