From 475b272c126d53f3985860422dc96b01b470423e Mon Sep 17 00:00:00 2001 From: Chunyan Liu Date: Tue, 29 Jul 2014 17:31:28 +0800 Subject: [PATCH] blockcopy: check dst = identical device Check whether dst is the same device as source, if yes, report error and exit. Signed-off-by: Chunyan Liu --- src/qemu/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) Index: libvirt-3.0.0/src/qemu/qemu_driver.c =================================================================== --- libvirt-3.0.0.orig/src/qemu/qemu_driver.c +++ libvirt-3.0.0/src/qemu/qemu_driver.c @@ -16828,6 +16828,15 @@ qemuDomainBlockCopyCommon(virDomainObjPt _("non-file destination not supported yet")); goto endjob; } + + if (STREQ_NULLABLE(realpath(disk->src->path, NULL), + realpath(mirror->path, NULL))) { + virReportError(VIR_ERR_INVALID_ARG, + _("destination '%s' is the same as disk '%s' source"), + mirror->path, path); + goto endjob; + } + if (stat(mirror->path, &st) < 0) { if (errno != ENOENT) { virReportSystemError(errno, _("unable to stat for disk %s: %s"),