Accepting request 257979 from KDE:Distro:Factory

1

OBS-URL: https://build.opensuse.org/request/show/257979
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/lokalize?expand=0&rev=22

lokalize.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Mon Oct 20 15:12:33 UTC 2014 - tchvatal@suse.com
+
+- Cleanup with spec-cleaner
+- Add recommends on libqt4-sql-sqlite as it is needed by
+  some of the plugins exclusively
+
 -------------------------------------------------------------------
 Sun Oct 12 12:41:52 UTC 2014 - tittiatcoke@gmail.com
 

lokalize.spec

@@ -17,57 +17,57 @@
 
 
 Name:           lokalize
-BuildRequires:  hunspell-devel
-BuildRequires:  libkde4-devel
+Version:        4.14.2
+Release:        0
 Summary:        KDE Translation Editor
 License:        GPL-2.0+
 Group:          System/GUI/KDE
 Url:            http://www.kde.org/
-Version:        4.14.2
-Release:        0
 Source0:        %{name}-%{version}.tar.xz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-build
+BuildRequires:  hunspell-devel
+BuildRequires:  libkde4-devel
 # Requires strigila_po.so (bnc#410716)
 Requires:       kdesdk-strigi-analyzers
 Requires:       libqt4_sql_backend
 Requires:       python-kde4
+# SQLite is actually needed by some plugins which won't
+# work with others
+Recommends:     libqt4-sql-sqlite
 Provides:       kde4-lokalize = 4.3.0
 Obsoletes:      kde4-lokalize < 4.3.0
-%kde4_runtime_requires
+BuildRoot:      %{_tmppath}/%{name}-%{version}-build
+%{kde4_runtime_requires}
 
 %description
 This package contains lokalize, an editor for translations
 
 %prep
-%setup -q -n %{name}-%{version}
+%setup -q
 
 %build
 %ifarch ppc64
-RPM_OPT_FLAGS="$RPM_OPT_FLAGS -mminimal-toc"
+RPM_OPT_FLAGS="%{optflags} -mminimal-toc"
 %endif
-export CXXFLAGS="$RPM_OPT_FLAGS -fPIC"
-export CFLAGS="$RPM_OPT_FLAGS -fPIC"
-  %cmake_kde4 -d build -- -DCMAKE_CXXFLAGS="$RPM_OPT_FLAGS" -DCMAKE_CFLAGS="$RPM_OPT_FLAGS" 
+export CXXFLAGS="%{optflags} -fPIC"
+export CFLAGS="%{optflags} -fPIC"
+  %cmake_kde4 -d build -- -DCMAKE_CXXFLAGS="%{optflags}" -DCMAKE_CFLAGS="%{optflags}"
 #make_jobs
   make
 
 %install
   cd build
-  %makeinstall
+  make DESTDIR=%{buildroot} install %{?_smp_mflags}
   cd ..
   %suse_update_desktop_file -r lokalize       Development Translation
-  %kde_post_install
+  %{kde_post_install}
 
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
 
-%clean
-  rm -rf $RPM_BUILD_ROOT
-
 %files
 %defattr(-,root,root)
-%doc COPYING 
+%doc COPYING
 %{_kde4_bindir}/lokalize
 %{_kde4_applicationsdir}/lokalize.desktop
 %{_kde4_htmldir}/en/lokalize/