34 lines
1.5 KiB
Diff
34 lines
1.5 KiB
Diff
|
From fd449e28e30886522c32df610c77124fb7be4b37 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Fabian Vogt <fvogt@suse.de>
|
||
|
|
Date: Mon, 29 Aug 2022 16:07:20 +0200
|
||
|
|
Subject: [PATCH] LXQtCompilerSettings: Drop use of -Bsymbolic
|
||
|
|
|
||
|
|
The use of "copy relocations" in ELF executables makes this rather dangerous,
|
||
|
|
as that moves the definition of the symbol from the library to the executable,
|
||
|
|
but the library still uses its own definition with -Bsymbolic.
|
||
|
|
|
||
|
|
In particular, this led to pcmanfm-qt not saving settings properly
|
||
|
|
(https://bugzilla.opensuse.org/show_bug.cgi?id=1195421), but can also cause
|
||
|
|
worse issues like just crashing on startup.
|
||
|
|
|
||
|
|
See https://bugreports.qt.io/browse/QTBUG-86173 and
|
||
|
|
https://bugzilla.opensuse.org/show_bug.cgi?id=1175278 for some details and
|
||
|
|
discussion about issues with -Bsymbolic.
|
||
|
|
---
|
||
|
|
cmake/modules/LXQtCompilerSettings.cmake | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/cmake/modules/LXQtCompilerSettings.cmake b/cmake/modules/LXQtCompilerSettings.cmake
|
||
|
|
index dfb0eaa..a8cb16d 100644
|
||
|
|
--- a/cmake/modules/LXQtCompilerSettings.cmake
|
||
|
|
+++ b/cmake/modules/LXQtCompilerSettings.cmake
|
||
|
|
@@ -164,7 +164,7 @@ if (CMAKE_COMPILER_IS_GNUCXX OR LXQT_COMPILER_IS_CLANGCXX)
|
||
|
|
set(NO_UNDEFINED_FLAGS "-Wl,--no-undefined")
|
||
|
|
# -Bsymbolic-functions: replace dynamic symbols used internally in
|
||
|
|
# shared libs with direct addresses.
|
||
|
|
- set(SYMBOLIC_FLAGS "-Wl,-Bsymbolic-functions -Wl,-Bsymbolic")
|
||
|
|
+ set(SYMBOLIC_FLAGS "-Wl,-Bsymbolic-functions")
|
||
|
|
endif()
|
||
|
|
|
||
|
|
set(CMAKE_SHARED_LINKER_FLAGS
|