mcelog/fix_setgroups_missing_call.patch
Dirk Mueller e7441a5615 Accepting request 1173682 from home:trenn:branches:Base:System
- Update to version 198:
  * Remove obsolete on disk dimm database code
  * page.c: Disable gcc warnings
  * page.c: Remove obsolete comment
  * mcelog: Fix clang warnings
  * mcelog: mempage_replace missing initialization of mempage fields
  * mcelog: Add third model number for Arrowlake
- Refresh patches according to mainline:
M    add-f10h-support.patch
M    email.patch
M    fix_setgroups_missing_call.patch
M    mcelog_invert_prefill_db_warning.patch

OBS-URL: https://build.opensuse.org/request/show/1173682
OBS-URL: https://build.opensuse.org/package/show/Base:System/mcelog?expand=0&rev=111
2024-05-14 06:52:51 +00:00

32 lines
988 B
Diff

---
mcelog.c | 9 +++++++++
1 file changed, 9 insertions(+)
Index: mcelog-198/mcelog.c
===================================================================
--- mcelog-198.orig/mcelog.c
+++ mcelog-198/mcelog.c
@@ -37,6 +37,7 @@
#include <assert.h>
#include <signal.h>
#include <pwd.h>
+#include <grp.h>
#include <sys/wait.h>
#include <fnmatch.h>
#include "mcelog.h"
@@ -1163,6 +1164,14 @@ static void general_setup(void)
static void drop_cred(void)
{
+ /* When dropping privileges from root, the `setgroups` call will
+ * remove any extraneous groups. If we don't call this, then
+ * even though our uid has dropped, we may still have groups
+ * that enable us to do super-user things. This will fail if we
+ * aren't root, so don't bother checking the return value, this
+ * is just done as an optimistic privilege dropping function.
+ */
+ setgroups(0, NULL);
if (runcred.uid != -1U && runcred.gid == -1U) {
struct passwd *pw = getpwuid(runcred.uid);
if (pw)