49 lines
1.8 KiB
Diff
49 lines
1.8 KiB
Diff
|
From 743d72f6b6aba44599099c7cbc879435f9005e3a Mon Sep 17 00:00:00 2001
|
||
|
|
From: Cheyenne Wills <cwills@sinenomine.net>
|
||
|
|
Date: Wed, 03 Apr 2024 11:36:54 -0600
|
||
|
|
Subject: [PATCH] Linux: Define afs_thread_wrapper() as static
|
||
|
|
|
||
|
|
When building against a Linux 6.8 kernel, functions that are missing
|
||
|
|
prototypes or declarations are flagged.
|
||
|
|
|
||
|
|
We can add the static attribute to functions that are not referenced
|
||
|
|
outside of the file that implements them to avoid having these functions
|
||
|
|
flagged by the compiler.
|
||
|
|
|
||
|
|
These functions are flagged due to missing prototypes when building
|
||
|
|
against a Linux 6.8 kernel (which sets the -Wmissing-declarations and
|
||
|
|
-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:
|
||
|
|
'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).
|
||
|
|
|
||
|
|
When building against a kernel with CONFIG_WERROR=y, the build fails.
|
||
|
|
|
||
|
|
This is an openafs-1.8.x specific commit.
|
||
|
|
|
||
|
|
The function afs_thread_wrapper() in LINUX/osi_misc.c on the master
|
||
|
|
branch was changed to a static function with commit:
|
||
|
|
'afs: Drop GLOCK for various Rx calls' (d5e1428a3b)
|
||
|
|
However this is a larger change than needed to fix the build problem and
|
||
|
|
the commit could have a significant impact for 1.8.x since it is
|
||
|
|
changing rx locking. To avoid introducing such a change, just change
|
||
|
|
the afs_thread_wrapper() to static as a 1.8.x specific commit.
|
||
|
|
|
||
|
|
There are no functional changes in this commit.
|
||
|
|
|
||
|
|
Change-Id: I4edc61e6a4989c16ccf41b935e205dbf209bf2a5
|
||
|
|
---
|
||
|
|
|
||
|
|
diff --git a/src/afs/LINUX/osi_misc.c b/src/afs/LINUX/osi_misc.c
|
||
|
|
index aa5d5fc..27f73cd 100644
|
||
|
|
--- a/src/afs/LINUX/osi_misc.c
|
||
|
|
+++ b/src/afs/LINUX/osi_misc.c
|
||
|
|
@@ -155,7 +155,8 @@
|
||
|
|
|
||
|
|
|
||
|
|
/* This could use some work, and support on more platforms. */
|
||
|
|
-int afs_thread_wrapper(void *rock)
|
||
|
|
+static int
|
||
|
|
+afs_thread_wrapper(void *rock)
|
||
|
|
{
|
||
|
|
void (*proc)(void) = rock;
|
||
|
|
__module_get(THIS_MODULE);
|