pcp/0010-services-switch-logutil-and-pmieutil-scripts-from-ty.patch

61 lines
2.7 KiB
Diff
Raw Permalink Normal View History

From e6d7bb6873531beb5b013a49e0b094cd7680cf89 Mon Sep 17 00:00:00 2001
From: Mark Goodwin <mgoodwin@redhat.com>
Date: Mon, 30 Aug 2021 11:22:19 +1000
Subject: [PATCH] services: switch logutil and pmieutil scripts from type
oneshot to exec
Switches the "daily" and "check" and related services from Type=oneshot
to Type=exec (or Type=simple for older versions of systemd that do
not support Type=exec) and nuke KillMode=none. Explicitly specify
Restart=none, even though it's the default, to be clear that these
timer invoked service scripts are not long running service daemons
and are expected to exit normally.
These changes are a precursor to further improvements to the long
running PCP services and systemd integration.
All tests in the logutil and pmieutil QA groups are passing and soak
testing on several platforms has not shown any new issues (and the
systemd warnings about "Support for KillMode=none is deprecated" are
gone).
Resolves: RHBZ#1942844
Resolves: Fedora BZ#1897945
Resolves: https://github.com/performancecopilot/pcp/issues/1186
Obsoletes the earlier PR#1355.
(cherry picked from commit 705b657107e8c812c96fa8b74d0f5d6384b00888)
Reviewed-by: David Disseldorp <ddiss@suse.de>
References: bsc#1186511
---
configure | 13 +++++++++++++
configure.ac | 14 ++++++++++++++
src/include/builddefs.in | 3 +++
src/pmfind/GNUmakefile | 1 +
src/pmfind/pmfind.service.in | 4 ++--
src/pmie/GNUmakefile | 2 ++
src/pmie/pmie_check.service.in | 4 ++--
src/pmie/pmie_daily.service.in | 4 ++--
src/pmlogger/GNUmakefile | 5 +++++
src/pmlogger/pmlogger_check.service.in | 4 ++--
src/pmlogger/pmlogger_daily-poll.service.in | 4 ++--
src/pmlogger/pmlogger_daily.service.in | 4 ++--
src/pmlogger/pmlogger_daily_report-poll.service.in | 4 ++--
src/pmlogger/pmlogger_daily_report.service.in | 4 ++--
14 files changed, 54 insertions(+), 16 deletions(-)
Accepting request 1164379 from home:mschreiner:branches:Base:System - Add fix for bsc#1222121: * 0011-disable-redis-proxying-by-default.patch - Upgrade to 6.2.0 (bsc#1217826): * Changes from pcp-6.2.0: - Client tools and utilities: pmlogger: default to creating version 3 PCP archives pmie, pmlogger, pmcd, pmproxy: init script hardening to run less as root:root, more as pcp:pcp and more safely pcp-reboot-init: new systemd service for $PCP_RC_DIR setup pcp2arrow: new, export metrics to parquet format for pandas pcp-atop: deterministic process sort when handling NULLs pcp-atop: update to v2.10.0 upstream code pcp-htop: update to latest upstream fixes pcp-geolocate: function with older versions of python pcp-meminfo: resolve possible 'broken pipe' diagnostics pcp-ss: fix handling of listening state sockets to match ss pcp-ss: fix the UDP UNCONN vs LISTEN state handling - PMDA additions, enhancements and bug fixes: pmdaproc: improvements for process accounting metrics pmdalinux: add pgpromote* and pgdemote* memory metrics pmdalinux: add metric sysfs.module.zswap.max_pool_percent pmdalinux: add new SNMP metric network.ip.outtransmits pmdasummary: send state change 0 (no change) back to pmcd pmdapostgresql: support the psycopg3 python module as well pmdaopenmetrics: kepler support - live metrics and logging - Server-side utilities and log management scripts: pmlogrewrite, pmlogredact: fix for missing data volumes pmcd: cosmetic change to avoid pipe2 name clash runaspcp: new helper utility for unprivileged rc scripts OBS-URL: https://build.opensuse.org/request/show/1164379 OBS-URL: https://build.opensuse.org/package/show/Base:System/pcp?expand=0&rev=133
2024-04-08 16:24:12 +02:00
Index: pcp-6.2.0/src/include/builddefs.in
===================================================================
Accepting request 1164379 from home:mschreiner:branches:Base:System - Add fix for bsc#1222121: * 0011-disable-redis-proxying-by-default.patch - Upgrade to 6.2.0 (bsc#1217826): * Changes from pcp-6.2.0: - Client tools and utilities: pmlogger: default to creating version 3 PCP archives pmie, pmlogger, pmcd, pmproxy: init script hardening to run less as root:root, more as pcp:pcp and more safely pcp-reboot-init: new systemd service for $PCP_RC_DIR setup pcp2arrow: new, export metrics to parquet format for pandas pcp-atop: deterministic process sort when handling NULLs pcp-atop: update to v2.10.0 upstream code pcp-htop: update to latest upstream fixes pcp-geolocate: function with older versions of python pcp-meminfo: resolve possible 'broken pipe' diagnostics pcp-ss: fix handling of listening state sockets to match ss pcp-ss: fix the UDP UNCONN vs LISTEN state handling - PMDA additions, enhancements and bug fixes: pmdaproc: improvements for process accounting metrics pmdalinux: add pgpromote* and pgdemote* memory metrics pmdalinux: add metric sysfs.module.zswap.max_pool_percent pmdalinux: add new SNMP metric network.ip.outtransmits pmdasummary: send state change 0 (no change) back to pmcd pmdapostgresql: support the psycopg3 python module as well pmdaopenmetrics: kepler support - live metrics and logging - Server-side utilities and log management scripts: pmlogrewrite, pmlogredact: fix for missing data volumes pmcd: cosmetic change to avoid pipe2 name clash runaspcp: new helper utility for unprivileged rc scripts OBS-URL: https://build.opensuse.org/request/show/1164379 OBS-URL: https://build.opensuse.org/package/show/Base:System/pcp?expand=0&rev=133
2024-04-08 16:24:12 +02:00
--- pcp-6.2.0.orig/src/include/builddefs.in
+++ pcp-6.2.0/src/include/builddefs.in
@@ -908,6 +908,9 @@ PCP_GROUP_INSTALL = @pcp_group_install@
# systemd service type for logutil scripts
SD_SERVICE_TYPE=@sd_service_type@
+# systemd service type for logutil scripts
+SD_SERVICE_TYPE=@sd_service_type@
+
PCPLIB = -lpcp
PCPLIB_EXTRAS = $(LIB_FOR_MATH) $(LIB_FOR_PTHREADS) $(LIB_FOR_DLOPEN) $(LIB_FOR_RT)
ifneq "$(PCPLIB)" "$(LIB_FOR_BASENAME)"