percona-toolkit/percona-toolkit-2.2.x-disable-default-version-check.patch

277 lines
11 KiB
Diff

From: Andreas Stieger <andreas.stieger@gmx.de>
Date: Mon, 17 Feb 2014 00:15:35 +0000
Subject: disable automatic version check for all tools
References: https://bugzilla.novell.com/show_bug.cgi?id=864194 https://bugs.launchpad.net/percona-toolkit/+bug/1279502
Upstream: no
Prevents transmission of version information to an external host
in the default configuration.
Can be used by owner of a Percona Server (or an attacker who can
control this destination for the client) to collect arbitrary
MySQL configuration parameters and execute commands (with -v).
Now the version check needs to be requested via command line or
global/tool specific/user configuration. (--version-check)
Note that the doc is parsed into a Perl Getopt::Long spec at runtime.
Setting "default: no" does not work, "default: 0" would work.
The spec file contains a %check section that tests this.
Patching the source was chosen over supplying default configuration
files in /etc/percona-toolkit/percona-toolkit.conf because not all
tools actually support the version check and would throw warnings.
---
bin/pt-archiver | 2 --
bin/pt-config-diff | 2 --
bin/pt-deadlock-logger | 2 --
bin/pt-diskstats | 2 --
bin/pt-duplicate-key-checker | 2 --
bin/pt-find | 2 --
bin/pt-fk-error-logger | 2 --
bin/pt-heartbeat | 2 --
bin/pt-index-usage | 2 --
bin/pt-kill | 2 --
bin/pt-online-schema-change | 2 --
bin/pt-query-digest | 2 --
bin/pt-slave-delay | 2 --
bin/pt-slave-restart | 2 --
bin/pt-table-checksum | 2 --
bin/pt-table-sync | 2 --
bin/pt-upgrade | 2 --
bin/pt-variable-advisor | 2 --
18 files changed, 36 deletions(-)
Index: percona-toolkit-2.2.17/bin/pt-archiver
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-archiver 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-archiver 2016-03-13 13:37:02.000000000 +0100
@@ -7958,8 +7958,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-config-diff
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-config-diff 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-config-diff 2016-03-13 13:37:02.000000000 +0100
@@ -5618,8 +5618,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-deadlock-logger
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-deadlock-logger 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-deadlock-logger 2016-03-13 13:37:02.000000000 +0100
@@ -5404,8 +5404,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-diskstats
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-diskstats 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-diskstats 2016-03-13 13:37:02.000000000 +0100
@@ -5480,8 +5480,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-duplicate-key-checker
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-duplicate-key-checker 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-duplicate-key-checker 2016-03-13 13:37:02.000000000 +0100
@@ -5462,8 +5462,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-find
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-find 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-find 2016-03-13 13:37:02.000000000 +0100
@@ -4456,8 +4456,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-fk-error-logger
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-fk-error-logger 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-fk-error-logger 2016-03-13 13:37:02.000000000 +0100
@@ -4391,8 +4391,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-heartbeat
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-heartbeat 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-heartbeat 2016-03-13 13:37:02.000000000 +0100
@@ -6940,8 +6940,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-index-usage
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-index-usage 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-index-usage 2016-03-13 13:37:02.000000000 +0100
@@ -7392,8 +7392,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-kill
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-kill 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-kill 2016-03-13 13:37:02.000000000 +0100
@@ -7736,8 +7736,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-online-schema-change
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-online-schema-change 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-online-schema-change 2016-03-13 13:37:02.000000000 +0100
@@ -11865,8 +11865,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-query-digest
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-query-digest 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-query-digest 2016-03-13 13:37:02.000000000 +0100
@@ -16327,8 +16327,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-slave-delay
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-slave-delay 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-slave-delay 2016-03-13 13:37:02.000000000 +0100
@@ -4711,8 +4711,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-slave-restart
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-slave-restart 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-slave-restart 2016-03-13 13:37:02.000000000 +0100
@@ -5777,8 +5777,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-table-checksum
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-table-checksum 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-table-checksum 2016-03-13 13:37:02.000000000 +0100
@@ -12657,8 +12657,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-table-sync
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-table-sync 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-table-sync 2016-03-13 13:37:02.000000000 +0100
@@ -12544,8 +12544,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-upgrade
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-upgrade 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-upgrade 2016-03-13 13:37:02.000000000 +0100
@@ -11100,8 +11100,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.17/bin/pt-variable-advisor
===================================================================
--- percona-toolkit-2.2.17.orig/bin/pt-variable-advisor 2016-03-07 10:09:38.000000000 +0100
+++ percona-toolkit-2.2.17/bin/pt-variable-advisor 2016-03-13 13:37:02.000000000 +0100
@@ -5981,8 +5981,6 @@ Show version and exit.
=item --[no]version-check
-default: yes
-
Check for the latest version of Percona Toolkit, MySQL, and other programs.
This is a standard "check for updates automatically" feature, with two