Olaf Hering
b6d44fd48e
- Update to version 1.4.0 * Bugfix: AcoustID submission fails with code 299 (PICARD-82) * Bugfix: Ignoring "hip hop rap" folksonomy tags also ignores "rap", "hip hop", etc. (PICARD-335) * Bugfix: Picard downloads multiple 'front' images instead of just first one. (PICARD-350) * Bugfix: Saving hidden file with only an extension drops the extension (PICARD-357) * Bugfix: Add directory opens in "wrong" dir (PICARD-366) * Bugfix: Picard should de-duplicate work lists (PICARD-375) * Bugfix: Tree selector in Options window is partially obscured, pane too narrow (PICARD-408) * Bugfix: tag acoustid_id can not be removed or deleted in script, renaming or plugin (PICARD-419) * Bugfix: Can't remove value from field (PICARD-546) * Bugfix: Can't open Options (PICARD-592) * Bugfix: "Tags from filenames" action stays enabled even if it is unavailable. (PICARD-688) * Bugfix: Using the first image type as filename changes the name of front images (PICARD-701) * Bugfix: Fingerprint Submission Failes if AcoustID tags are present and/or invalid (PICARD-706) * Bugfix: Picard moves into the selected folder (PICARD-726) * Bugfix: Picard does not support (recording) relationship credits (PICARD-730) * Bugfix: Picard repeats/duplicates field data (PICARD-748) * Bugfix: Number of pending web requests is not decremented on exceptions in the handler (PICARD-751) * Bugfix: Divide by zero error in _convert_folksonomy_tags_to_genre when no tag at the release/release group level ( PICARD-753) * Bugfix: Directory tree (file browser) not sorted for non-system drives under Windows (PICARD-754) * Bugfix: Crash when loading release with only zero count tags (PICARD-759) * Bugfix: No name and no window grouping in gnome-shell Alt-Tab app switcher (PICARD-761) * Bugfix: Lookup in Browser does not and can not load HTTPS version of musicbrainz.org (PICARD-764) * Bugfix: Unable to login using oauth via Picard options with Server Port set to 443 (PICARD-766) * Bugfix: "AttributeError: 'MetadataBox' object has no attribute 'resize_columns'" when enabling the cover art box ( PICARD-775) * Bugfix: Pre-gap tracks are not counted in absolutetracknumber (PICARD-778) * Bugfix: CAA cover art provider runs even if cover art has already been loaded (PICARD-780) * Bugfix: Toggling Embed Cover Art in Tags and restarting doesn't have the expected behavior (PICARD-782) * Bugfix: XMLWS redirects incorrectly (PICARD-788) * Bugfix: Handle empty collection-list in web server response (PICARD-798) OBS-URL: https://build.opensuse.org/request/show/457107 OBS-URL: https://build.opensuse.org/package/show/multimedia:apps/picard?expand=0&rev=47
65 lines
2.3 KiB
Diff
65 lines
2.3 KiB
Diff
From a2df06a4d9cbaf6cc5220fad42751bbb9f269c54 Mon Sep 17 00:00:00 2001
|
|
From: Sambhav Kothari <sambhavs.email@gmail.com>
|
|
Date: Sun, 22 Jan 2017 18:53:26 +0530
|
|
Subject: [PATCH 4/9] Update labels in _show method
|
|
|
|
---
|
|
picard/ui/coverartbox.py | 10 +++++++---
|
|
1 file changed, 7 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/picard/ui/coverartbox.py b/picard/ui/coverartbox.py
|
|
index f09326ab..2ec1719e 100644
|
|
--- a/picard/ui/coverartbox.py
|
|
+++ b/picard/ui/coverartbox.py
|
|
@@ -35,11 +35,11 @@ class ActiveLabel(QtGui.QLabel):
|
|
clicked = QtCore.pyqtSignal()
|
|
imageDropped = QtCore.pyqtSignal(QtCore.QUrl)
|
|
|
|
- def __init__(self, active=True, *args):
|
|
+ def __init__(self, active=True, drops=False, *args):
|
|
QtGui.QLabel.__init__(self, *args)
|
|
self.setMargin(0)
|
|
self.setActive(active)
|
|
- self.setAcceptDrops(False)
|
|
+ self.setAcceptDrops(drops)
|
|
|
|
def setActive(self, active):
|
|
self.active = active
|
|
@@ -67,6 +67,7 @@ class ActiveLabel(QtGui.QLabel):
|
|
if accepted:
|
|
event.acceptProposedAction()
|
|
|
|
+
|
|
class CoverArtThumbnail(ActiveLabel):
|
|
|
|
def __init__(self, active=False, drops=False, *args, **kwargs):
|
|
@@ -137,6 +138,7 @@ class CoverArtThumbnail(ActiveLabel):
|
|
def fetch_remote_image(self, url):
|
|
return self.parent().fetch_remote_image(url)
|
|
|
|
+
|
|
class CoverArtBox(QtGui.QGroupBox):
|
|
|
|
def __init__(self, parent):
|
|
@@ -147,7 +149,7 @@ class CoverArtBox(QtGui.QGroupBox):
|
|
self.setStyleSheet('''QGroupBox{background-color:none;border:1px;}''')
|
|
self.setFlat(True)
|
|
self.item = None
|
|
- self.cover_art_label = QtGui.QLabel('Cover-Art')
|
|
+ self.cover_art_label = QtGui.QLabel('')
|
|
self.cover_art_label.setAlignment(QtCore.Qt.AlignTop | QtCore.Qt.AlignHCenter)
|
|
self.cover_art = CoverArtThumbnail(False, True, parent)
|
|
self.orig_cover_art_label = QtGui.QLabel('')
|
|
@@ -163,6 +165,8 @@ class CoverArtBox(QtGui.QGroupBox):
|
|
def _show(self):
|
|
if self.cover_art.data == self.orig_cover_art.data:
|
|
self.orig_cover_art.setHidden(True)
|
|
+ self.cover_art_label.setText('')
|
|
+ self.orig_cover_art_label.setText('')
|
|
else:
|
|
self.orig_cover_art.setHidden(False)
|
|
self.cover_art_label.setText('New Cover-Art')
|
|
--
|
|
2.11.0
|
|
|