Olaf Hering
b6d44fd48e
- Update to version 1.4.0 * Bugfix: AcoustID submission fails with code 299 (PICARD-82) * Bugfix: Ignoring "hip hop rap" folksonomy tags also ignores "rap", "hip hop", etc. (PICARD-335) * Bugfix: Picard downloads multiple 'front' images instead of just first one. (PICARD-350) * Bugfix: Saving hidden file with only an extension drops the extension (PICARD-357) * Bugfix: Add directory opens in "wrong" dir (PICARD-366) * Bugfix: Picard should de-duplicate work lists (PICARD-375) * Bugfix: Tree selector in Options window is partially obscured, pane too narrow (PICARD-408) * Bugfix: tag acoustid_id can not be removed or deleted in script, renaming or plugin (PICARD-419) * Bugfix: Can't remove value from field (PICARD-546) * Bugfix: Can't open Options (PICARD-592) * Bugfix: "Tags from filenames" action stays enabled even if it is unavailable. (PICARD-688) * Bugfix: Using the first image type as filename changes the name of front images (PICARD-701) * Bugfix: Fingerprint Submission Failes if AcoustID tags are present and/or invalid (PICARD-706) * Bugfix: Picard moves into the selected folder (PICARD-726) * Bugfix: Picard does not support (recording) relationship credits (PICARD-730) * Bugfix: Picard repeats/duplicates field data (PICARD-748) * Bugfix: Number of pending web requests is not decremented on exceptions in the handler (PICARD-751) * Bugfix: Divide by zero error in _convert_folksonomy_tags_to_genre when no tag at the release/release group level ( PICARD-753) * Bugfix: Directory tree (file browser) not sorted for non-system drives under Windows (PICARD-754) * Bugfix: Crash when loading release with only zero count tags (PICARD-759) * Bugfix: No name and no window grouping in gnome-shell Alt-Tab app switcher (PICARD-761) * Bugfix: Lookup in Browser does not and can not load HTTPS version of musicbrainz.org (PICARD-764) * Bugfix: Unable to login using oauth via Picard options with Server Port set to 443 (PICARD-766) * Bugfix: "AttributeError: 'MetadataBox' object has no attribute 'resize_columns'" when enabling the cover art box ( PICARD-775) * Bugfix: Pre-gap tracks are not counted in absolutetracknumber (PICARD-778) * Bugfix: CAA cover art provider runs even if cover art has already been loaded (PICARD-780) * Bugfix: Toggling Embed Cover Art in Tags and restarting doesn't have the expected behavior (PICARD-782) * Bugfix: XMLWS redirects incorrectly (PICARD-788) * Bugfix: Handle empty collection-list in web server response (PICARD-798) OBS-URL: https://build.opensuse.org/request/show/457107 OBS-URL: https://build.opensuse.org/package/show/multimedia:apps/picard?expand=0&rev=47
42 lines
1.4 KiB
Diff
42 lines
1.4 KiB
Diff
From 623dde46e633ea26338293823ab1b8ebcc78e740 Mon Sep 17 00:00:00 2001
|
|
From: Sambhav Kothari <sambhavs.email@gmail.com>
|
|
Date: Sun, 22 Jan 2017 19:20:35 +0530
|
|
Subject: [PATCH 6/9] Implement __eq__ method for CoverArtThumbnail and update
|
|
_show() method
|
|
|
|
---
|
|
picard/ui/coverartbox.py | 10 +++++++++-
|
|
1 file changed, 9 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/picard/ui/coverartbox.py b/picard/ui/coverartbox.py
|
|
index 2ec1719e..03bcdc57 100644
|
|
--- a/picard/ui/coverartbox.py
|
|
+++ b/picard/ui/coverartbox.py
|
|
@@ -80,6 +80,12 @@ class CoverArtThumbnail(ActiveLabel):
|
|
self.clicked.connect(self.open_release_page)
|
|
self.imageDropped.connect(self.fetch_remote_image)
|
|
|
|
+ def __eq__(self, other):
|
|
+ if self.data and other.data:
|
|
+ return self.data.data == other.data.data
|
|
+ else:
|
|
+ return False
|
|
+
|
|
def show(self):
|
|
self.set_data(self.data, True)
|
|
|
|
@@ -163,7 +169,9 @@ class CoverArtBox(QtGui.QGroupBox):
|
|
self.setLayout(self.layout)
|
|
|
|
def _show(self):
|
|
- if self.cover_art.data == self.orig_cover_art.data:
|
|
+ # We want to show the 2 coverarts only if they are different
|
|
+ # and orig_cover_art is not None
|
|
+ if getattr(self.orig_cover_art, 'data', None) is None or self.cover_art == self.orig_cover_art:
|
|
self.orig_cover_art.setHidden(True)
|
|
self.cover_art_label.setText('')
|
|
self.orig_cover_art_label.setText('')
|
|
--
|
|
2.11.0
|
|
|