Accepting request 1108064 from multimedia:libs

OBS-URL: https://build.opensuse.org/request/show/1108064
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/pipewire?expand=0&rev=93

0001-audioconvert-fix-typo-in-neon-function.patch

@@ -1,28 +0,0 @@
-From b54f7fe90dd16b0f7a7e1e5bb1ef921212236029 Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 24 Aug 2023 13:44:10 +0200
-Subject: [PATCH] audioconvert: fix typo in neon function
-
-Thanks to Shengjiu Wang
-
-fixes #3463
----
- spa/plugins/audioconvert/fmt-ops-neon.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/spa/plugins/audioconvert/fmt-ops-neon.c b/spa/plugins/audioconvert/fmt-ops-neon.c
-index 0006456fc4..55be55fa58 100644
---- a/spa/plugins/audioconvert/fmt-ops-neon.c
-+++ b/spa/plugins/audioconvert/fmt-ops-neon.c
-@@ -294,7 +294,7 @@ conv_f32d_to_s16_2s_neon(void *data, void * SPA_RESTRICT dst, const void * SPA_R
- 		"      beq 4f\n"
- 		"3:"
- 		"      ld1 { v0.s }[0], [%[s0]], #4\n"
--		"      ld1 { v2.s }[0], [%[s1]], #4\n"
-+		"      ld1 { v1.s }[0], [%[s1]], #4\n"
- 		"      subs %[remainder], %[remainder], #1\n"
- 		"      sqadd  v0.4s, v0.4s, v2.4s\n"
- 		"      sqadd  v1.4s, v1.4s, v2.4s\n"
--- 
-GitLab
-

0001-bluez5-fix-BAP-profiles-showing.patch

@@ -1,36 +0,0 @@
-From dbd97020da06450366dca7020eeb62afcd135d83 Mon Sep 17 00:00:00 2001
-From: Pauli Virtanen <pav@iki.fi>
-Date: Tue, 22 Aug 2023 21:59:52 +0300
-Subject: [PATCH] bluez5: fix BAP profiles showing
-
-Now that we only show codec profiles, the logic that showed codecless
-profile for BAP has to be removed.
-
-This fixes BAP only showing off profile.
----
- spa/plugins/bluez5/bluez5-device.c | 9 ---------
- 1 file changed, 9 deletions(-)
-
-diff --git a/spa/plugins/bluez5/bluez5-device.c b/spa/plugins/bluez5/bluez5-device.c
-index 3dec1e0aa..ced1d8dc8 100644
---- a/spa/plugins/bluez5/bluez5-device.c
-+++ b/spa/plugins/bluez5/bluez5-device.c
-@@ -1661,15 +1661,6 @@ static struct spa_pod *build_profile(struct impl *this, struct spa_pod_builder *
- 
- 		name = spa_bt_profile_name(profile);
- 
--		/* If we can't codec switch, emit codecless profile */
--		if (current && !can_bap_codec_switch(this)) {
--			codec = 0;
--			index = get_index_from_profile(this, profile_index, codec);
--		} else if ((codec != 0) != can_bap_codec_switch(this)) {
--			errno = -EINVAL;
--			return NULL;
--		}
--
- 		if (codec) {
- 			media_codec = get_supported_media_codec(this, codec, &idx);
- 			if (media_codec == NULL) {
--- 
-GitLab
-

0001-impl-node-improve-suspend.patch

@@ -1,44 +0,0 @@
-From 3b052eaa9986c2f5182eb8a1b2f2b5c10be31a12 Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 24 Aug 2023 09:50:28 +0200
-Subject: [PATCH] impl-node: improve suspend
-
-Make sure we can only suspend when the node is (going to) IDLE. We don't
-really want to allow applications to suspend a node that is running or
-starting up.
-
-This might fix a race when a node is suspended at the same time it is
-started and cause silence. It also fixes the issue of total silence when
-doing "pactl suspend <node> 1" on a running node.
-
-See #3378
----
- src/pipewire/impl-node.c | 5 ++++-
- 1 file changed, 4 insertions(+), 1 deletion(-)
-
-diff --git a/src/pipewire/impl-node.c b/src/pipewire/impl-node.c
-index ca431c389..ff9effedc 100644
---- a/src/pipewire/impl-node.c
-+++ b/src/pipewire/impl-node.c
-@@ -591,6 +591,7 @@ static int node_send_command(void *object, const struct spa_command *command)
- {
- 	struct resource_data *data = object;
- 	struct pw_impl_node *node = data->node;
-+	struct impl *impl = SPA_CONTAINER_OF(node, struct impl, this);
- 	uint32_t id = SPA_NODE_COMMAND_ID(command);
- 
- 	pw_log_debug("%p: got command %d (%s)", node, id,
-@@ -598,7 +599,9 @@ static int node_send_command(void *object, const struct spa_command *command)
- 
- 	switch (id) {
- 	case SPA_NODE_COMMAND_Suspend:
--		suspend_node(node);
-+		if (node->info.state == PW_NODE_STATE_ERROR ||
-+		    impl->pending_state == PW_NODE_STATE_IDLE)
-+			suspend_node(node);
- 		break;
- 	default:
- 		spa_node_send_command(node->node, command);
--- 
-GitLab
-

0001-jack-make-sure-we-can-always-find-our-own-ports.patch

@@ -1,42 +0,0 @@
-From c41c812325ca1b0db1efc2fc06a3c90355be59d9 Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 24 Aug 2023 19:28:57 +0200
-Subject: [PATCH] jack: make sure we can always find our own ports
-
-find_port_by_name() is used to find our own ports before they become
-visible so make sure we can always find them.
-
-Fixes #3485
----
- pipewire-jack/src/pipewire-jack.c | 10 +++++++++-
- 1 file changed, 9 insertions(+), 1 deletion(-)
-
-diff --git a/pipewire-jack/src/pipewire-jack.c b/pipewire-jack/src/pipewire-jack.c
-index b93422bd3..ff5b6881d 100644
---- a/pipewire-jack/src/pipewire-jack.c
-+++ b/pipewire-jack/src/pipewire-jack.c
-@@ -719,12 +719,20 @@ static bool is_port_default(struct client *c, struct object *o)
- 	return false;
- }
- 
-+static inline bool client_port_visible(struct client *c, struct object *o)
-+{
-+	if (o->port.port != NULL && o->port.port->client == c)
-+		return true;
-+	return o->visible;
-+}
-+
- static struct object *find_port_by_name(struct client *c, const char *name)
- {
- 	struct object *o;
- 
- 	spa_list_for_each(o, &c->context.objects, link) {
--		if (o->type != INTERFACE_Port || o->removed || !o->visible)
-+		if (o->type != INTERFACE_Port || o->removed ||
-+		    (!client_port_visible(c, o)))
- 			continue;
- 		if (spa_streq(o->port.name, name) ||
- 		    spa_streq(o->port.alias1, name) ||
--- 
-GitLab
-

_service

@@ -3,7 +3,7 @@
   <service name="obs_scm" mode="manual">
     <param name="scm">git</param>
     <param name="url">https://gitlab.freedesktop.org/pipewire/pipewire.git</param>
-    <param name="revision">0.3.78</param>
+    <param name="revision">0.3.79</param>
     <param name="versionformat">@PARENT_TAG@</param>
 <!--
     <param name="revision">master</param>

pipewire-0.3.78.obscpio

@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:7d526fe0795980fc1ecb3d872ab7f78a83bfae89e7140a5e378e4009d3b0fe20
-size 12108301

pipewire.changes

@@ -1,3 +1,54 @@
+-------------------------------------------------------------------
+Tue Aug 29 17:32:30 UTC 2023 - Alexei Sorokin <sor.alexei@meowr.ru>
+
+- Update to version 0.3.79:
+ * Highlights
+   - Fix a regression in suspend that could cause silence.
+   - Fix a regression in JACK port registration that could cause
+     all kinds of JACK problems.
+   - Fix a typo in the neon sample conversion functions that could
+     cause distortion.
+   - Add BAP broadcast source and sink support.
+   - pw-top now has a batch mode to dump the output to stdout.
+   - Many more bugfixes and improvements.
+ * PipeWire
+   - Fix a regression in shutdown where a node might not first
+     suspend properly. This cause loss of sound in some cases.
+   - Failure to compile a regular expression in the config file
+     will now be reported and ! can be used to negate the match.
+   - Fix a regression where some nodes might not set running in
+     some cases.
+   - Nodes are now suspended before the format is cleared, which
+     might fix some crashes.
+ * Tools
+   - pw-top now has a batch mode to dump the output to stdout.
+ * SPA
+   - The queued samples in audioconvert are now correctly reported
+     in the delay.
+   - Make it easier to add a custom profile in ACP.
+   - Fix a typo in the neon sample conversion functions that could
+     cause distortion.
+   - device.profile.pro=true is added for pro audio nodes.
+   - An xrun counter was added to spa_io_clock to detect and track
+     skipped data because of xruns.
+ * Pulse-server
+   - Add alsa-sink and alsa-source modules.
+ * Bluetooth
+   - Fix a regression where only the BAP off profile is shown.
+   - Add BAP broadcast source and sink support.
+ * JACK
+   - Also emit a latency notify when the buffer size changes.
+   - Fix a regression in JACK port registration.
+   - jack_port_tie() is now supported.
+ * ALSA
+   - Improve property handling, support lists and ranges in
+     addition to fixed values.
+- Remove patches already included upstream:
+  * 0001-jack-make-sure-we-can-always-find-our-own-ports.patch
+  * 0001-audioconvert-fix-typo-in-neon-function.patch
+  * 0001-impl-node-improve-suspend.patch
+  * 0001-bluez5-fix-BAP-profiles-showing.patch
+
 -------------------------------------------------------------------
 Fri Aug 25 09:15:38 UTC 2023 - Antonio Larrosa <alarrosa@suse.com>
 

pipewire.obsinfo

@@ -1,4 +1,4 @@
 name: pipewire
-version: 0.3.78
+version: 0.3.79
-mtime: 1692695544
+mtime: 1693295126
-commit: 188f784430283afb08abb8e6540ddbc674e09399
+commit: b5c3f217926f9066a1afbee7eb20967dd6896c56

pipewire.spec

@@ -60,7 +60,7 @@
 %bcond_with aptx
 
 Name:           pipewire
-Version:        0.3.78
+Version:        0.3.79
 Release:        0
 Summary:        A Multimedia Framework designed to be an audio and video server and more
 License:        MIT
@@ -70,11 +70,6 @@ Source0:        %{name}-%{version}.tar.xz
 Source99:       baselibs.conf
 # PATCH-FIX-OPENSUSE reduce-meson-dependency.patch
 Patch0:         reduce-meson-dependency.patch
-Patch1:         0001-jack-make-sure-we-can-always-find-our-own-ports.patch
-Patch2:         0001-audioconvert-fix-typo-in-neon-function.patch
-Patch3:         0001-impl-node-improve-suspend.patch
-Patch4:         0001-bluez5-fix-BAP-profiles-showing.patch
-
 BuildRequires:  docutils
 BuildRequires:  doxygen
 BuildRequires:  fdupes
@@ -387,10 +382,6 @@ JACK libraries.
 sed -ie "s/version : '0.3.72'/version : '%{version}'/" %{P:0}
 %patch0 -p1
 %endif
-%patch1 -p1
-%patch2 -p1
-%patch3 -p1
-%patch4 -p1
 
 %build
 %if %{pkg_vcmp gcc < 8}