From 75fd9dda750c6bc192e56ed16d34a0920bdf41df Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Thu, 26 Jan 2017 16:59:48 +0100 Subject: [PATCH 2/2] [Color Picker] Add contrast frame around colors in popup This adds a frame around the color sections, makes it look a lot nicer and improves contrast. Since here the frame takes only a minor portion of surface area compared to the circle in a panel, I opted not to base it on luminosity, also for consistency's sake when there's 9 different colors in one view. Differential Revision: https://phabricator.kde.org/D4298 --- applets/colorpicker/package/contents/ui/main.qml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/applets/colorpicker/package/contents/ui/main.qml b/applets/colorpicker/package/contents/ui/main.qml index 845391cd8..ba1920a0c 100644 --- a/applets/colorpicker/package/contents/ui/main.qml +++ b/applets/colorpicker/package/contents/ui/main.qml @@ -318,9 +318,18 @@ Item { color: delegateMouse.currentColor + border { + color: theme.textColor + width: Math.round(units.devicePixelRatio) + } + Rectangle { - anchors.bottom: parent.bottom - width: parent.width + anchors { + bottom: parent.bottom + left: parent.left + right: parent.right + margins: rect.border.width + } height: colorLabel.contentHeight + 2 * units.smallSpacing color: theme.backgroundColor opacity: 0.8 -- 2.11.0