From ae9ce836c02f2e5f7664d8db6b532cc85a28bf7645405c06c8c30fe657da61eb Mon Sep 17 00:00:00 2001 From: Fabian Vogt Date: Mon, 22 Feb 2021 20:41:50 +0000 Subject: [PATCH] Accepting request 874437 from home:Vogtinator:plasma5.21 - Add patch to fix krunner crash caused by mismatched quotes: * 0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch OBS-URL: https://build.opensuse.org/request/show/874437 OBS-URL: https://build.opensuse.org/package/show/KDE:Frameworks5/plasma5-workspace?expand=0&rev=573 --- ...-Fix-empty-list-on-invalid-shell-quo.patch | 32 +++++++++++++++++++ plasma5-workspace.changes | 6 ++++ plasma5-workspace.spec | 1 + 3 files changed, 39 insertions(+) create mode 100644 0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch diff --git a/0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch b/0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch new file mode 100644 index 0000000..f6c3703 --- /dev/null +++ b/0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch @@ -0,0 +1,32 @@ +From 3a672ee43f48655ddcb544cc947680ba0aab7d2a Mon Sep 17 00:00:00 2001 +From: Alexander Lohnau +Date: Mon, 22 Feb 2021 18:10:08 +0100 +Subject: [PATCH] locations runner: Fix empty list on invalid shell quotes + +--- + runners/locations/locationrunner.cpp | 9 ++++++--- + 1 file changed, 6 insertions(+), 3 deletions(-) + +diff --git a/runners/locations/locationrunner.cpp b/runners/locations/locationrunner.cpp +index 175c07023..d1edeef02 100644 +--- a/runners/locations/locationrunner.cpp ++++ b/runners/locations/locationrunner.cpp +@@ -53,9 +53,12 @@ void LocationsRunner::match(Plasma::RunnerContext &context) + { + QString term = context.query(); + // If we have a query with an executable and optionally arguments, BUG: 433053 +- QFileInfo tmpInfo(KShell::tildeExpand(KShell::splitArgs(term).constFirst())); +- if (tmpInfo.isFile() && tmpInfo.isExecutable()) { +- return; ++ const QStringList split = KShell::splitArgs(term); ++ if (!split.isEmpty()) { ++ QFileInfo tmpInfo(KShell::tildeExpand(split.first())); ++ if (tmpInfo.isFile() && tmpInfo.isExecutable()) { ++ return; ++ } + } + // We want to expand ENV variables like $HOME to get the actual path, BUG: 358221 + KUriFilter::self()->filterUri(term, {QStringLiteral("kshorturifilter")}); +-- +2.25.1 + diff --git a/plasma5-workspace.changes b/plasma5-workspace.changes index 1cb6bb6..e67e8ee 100644 --- a/plasma5-workspace.changes +++ b/plasma5-workspace.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Mon Feb 22 17:53:47 UTC 2021 - Fabian Vogt + +- Add patch to fix krunner crash caused by mismatched quotes: + * 0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch + ------------------------------------------------------------------- Thu Feb 18 11:18:08 UTC 2021 - Fabian Vogt diff --git a/plasma5-workspace.spec b/plasma5-workspace.spec index ce10822..29c4bba 100644 --- a/plasma5-workspace.spec +++ b/plasma5-workspace.spec @@ -45,6 +45,7 @@ Source3: baselibs.conf # PATCH-FIX-UPSTREAM Patch1: 0001-libkworkspace-Interim-fix-for-the-logout-issue.patch Patch2: 0001-locations-runner-Fix-absolute-filepath-arguments.patch +Patch3: 0001-locations-runner-Fix-empty-list-on-invalid-shell-quo.patch # PATCHES 501-??? are PATCH-FIX-OPENSUSE Patch501: 0001-Use-qdbus-qt5.patch Patch502: 0001-Ignore-default-sddm-face-icons.patch