diff --git a/0001-Backport-fix-for-CVE-2024-6104.patch b/0001-Backport-fix-for-CVE-2024-6104.patch new file mode 100644 index 0000000..5e640ce --- /dev/null +++ b/0001-Backport-fix-for-CVE-2024-6104.patch @@ -0,0 +1,84 @@ +From 1a3445769d0a3c392487ec9480c0bfad07bde063 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Dan=20=C4=8Cerm=C3=A1k?= +Date: Sun, 30 Jun 2024 16:09:52 +0200 +Subject: [PATCH] Backport fix for CVE-2024-6104 + +This is https://github.com/hashicorp/go-retryablehttp/pull/158 only directly +applied to the vendor/ source tree +See also https://github.com/advisories/GHSA-v6v8-xj6m-xwqh +--- + .../hashicorp/go-retryablehttp/client.go | 28 ++++++++++++++----- + 1 file changed, 21 insertions(+), 7 deletions(-) + +diff --git a/vendor/github.com/hashicorp/go-retryablehttp/client.go b/vendor/github.com/hashicorp/go-retryablehttp/client.go +index 12ac50bcc..efee53c40 100644 +--- a/vendor/github.com/hashicorp/go-retryablehttp/client.go ++++ b/vendor/github.com/hashicorp/go-retryablehttp/client.go +@@ -658,9 +658,9 @@ func (c *Client) Do(req *Request) (*http.Response, error) { + if logger != nil { + switch v := logger.(type) { + case LeveledLogger: +- v.Debug("performing request", "method", req.Method, "url", req.URL) ++ v.Debug("performing request", "method", req.Method, "url", redactURL(req.URL)) + case Logger: +- v.Printf("[DEBUG] %s %s", req.Method, req.URL) ++ v.Printf("[DEBUG] %s %s", req.Method, redactURL(req.URL)) + } + } + +@@ -715,9 +715,9 @@ func (c *Client) Do(req *Request) (*http.Response, error) { + if err != nil { + switch v := logger.(type) { + case LeveledLogger: +- v.Error("request failed", "error", err, "method", req.Method, "url", req.URL) ++ v.Error("request failed", "error", err, "method", req.Method, "url", redactURL(req.URL)) + case Logger: +- v.Printf("[ERR] %s %s request failed: %v", req.Method, req.URL, err) ++ v.Printf("[ERR] %s %s request failed: %v", req.Method, redactURL(req.URL), err) + } + } else { + // Call this here to maintain the behavior of logging all requests, +@@ -753,7 +753,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) { + + wait := c.Backoff(c.RetryWaitMin, c.RetryWaitMax, i, resp) + if logger != nil { +- desc := fmt.Sprintf("%s %s", req.Method, req.URL) ++ desc := fmt.Sprintf("%s %s", req.Method, redactURL(req.URL)) + if resp != nil { + desc = fmt.Sprintf("%s (status: %d)", desc, resp.StatusCode) + } +@@ -818,11 +818,11 @@ func (c *Client) Do(req *Request) (*http.Response, error) { + // communicate why + if err == nil { + return nil, fmt.Errorf("%s %s giving up after %d attempt(s)", +- req.Method, req.URL, attempt) ++ req.Method, redactURL(req.URL), attempt) + } + + return nil, fmt.Errorf("%s %s giving up after %d attempt(s): %w", +- req.Method, req.URL, attempt, err) ++ req.Method, redactURL(req.URL), attempt, err) + } + + // Try to read the response body so we can reuse this connection. +@@ -903,3 +903,17 @@ func (c *Client) StandardClient() *http.Client { + Transport: &RoundTripper{Client: c}, + } + } ++ ++// Taken from url.URL#Redacted() which was introduced in go 1.15. ++// We can switch to using it directly if we'll bump the minimum required go version. ++func redactURL(u *url.URL) string { ++ if u == nil { ++ return "" ++ } ++ ++ ru := *u ++ if _, has := ru.User.Password(); has { ++ ru.User = url.UserPassword(ru.User.Username(), "xxxxx") ++ } ++ return ru.String() ++} +-- +2.45.2 + diff --git a/podman.changes b/podman.changes index 2949cbc..ee4c633 100644 --- a/podman.changes +++ b/podman.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Sun Jun 30 14:19:27 UTC 2024 - Dan Čermák + +- Add patch to fix bsc#1227052 / CVE-2024-6104: + * 0001-Backport-fix-for-CVE-2024-6104.patch +- Add missing BuildRequires man + ------------------------------------------------------------------- Wed Jun 05 05:24:29 UTC 2024 - danish.prakash@suse.com diff --git a/podman.spec b/podman.spec index cdec31d..22baeb0 100644 --- a/podman.spec +++ b/podman.spec @@ -30,6 +30,8 @@ Group: System/Management URL: https://%{project} Source0: %{name}-%{version}.tar.gz Source1: podman.conf +Patch0: 0001-Backport-fix-for-CVE-2024-6104.patch +BuildRequires: man BuildRequires: bash-completion BuildRequires: device-mapper-devel BuildRequires: fdupes