Daniel Garcia
d509d3561b
* Security Improvements:
- Previously, malformed multipart-form-data requests could log
multiple warnings and constitute a denial-of-service attack. Now
an exception is raised at the first error, so there is only one
log message per request. This fixes CVE-2025-47287.
* General Changes:
- Python 3.14 is now supported. Older versions of Tornado will
work on Python 3.14 but may log deprecation warnings.
- The free-threading mode of Python 3.13 is now supported on an
experimental basis. Prebuilt wheels are not yet available for
this configuration, but it can be built from source.
- The minimum supported Python version is 3.9.
* Deprecation Notices:
- Support for obs-fold continuation lines in HTTP headers is
deprecated and will be removed in Tornado 7.0, as is the use of
carriage returns without line feeds as header separators.
- The callback argument to websocket_connect is deprecated and
will be removed in Tornado 7.0. Note that on_message_callback is
not deprecated.
- The log_message and args attributes of tornado.web.HTTPError are
deprecated. Use the new get_message method instead.
OBS-URL: https://build.opensuse.org/package/show/devel:languages:python/python-tornado6?expand=0&rev=46
67 lines
2.7 KiB
Diff
67 lines
2.7 KiB
Diff
From c851aa8a949524b35f72c82b45a52353aa3c0558 Mon Sep 17 00:00:00 2001
|
|
From: Ran Benita <ran@unusedvar.com>
|
|
Date: Sun, 28 Apr 2024 14:17:54 +0300
|
|
Subject: [PATCH] testing: allow to instantiate an empty AsyncTestCase
|
|
|
|
`unittest.TestCase` has a feature where it allows instantiating
|
|
`MyTestClass()` with the default method name `runTest` even if a
|
|
`runTest` method doesn't actually exist. This is documented in
|
|
`TestCase`'s docs under "Changed in version 3.2"[0].
|
|
|
|
Since version 8.2, pytest relies on this, and started breaking on
|
|
Tornado's `AsyncTestCase`[1].
|
|
|
|
Change `AsyncTestCase` to allow empty instatiation, by matching the
|
|
upstream code.
|
|
|
|
[0] https://docs.python.org/3/library/unittest.html#unittest.TestCase
|
|
[1] https://github.com/pytest-dev/pytest/issues/12263
|
|
---
|
|
tornado/test/testing_test.py | 9 +++++++++
|
|
tornado/testing.py | 12 +++++++++++-
|
|
2 files changed, 20 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/tornado/test/testing_test.py b/tornado/test/testing_test.py
|
|
index 0429feee83..8e2b8db428 100644
|
|
--- a/tornado/test/testing_test.py
|
|
+++ b/tornado/test/testing_test.py
|
|
@@ -61,6 +61,15 @@ def test_subsequent_wait_calls(self):
|
|
self.io_loop.add_timeout(self.io_loop.time() + 0.2, self.stop)
|
|
self.wait(timeout=0.4)
|
|
|
|
+ def test_empty_instantation_is_allowed(self):
|
|
+ """
|
|
+ Test that empty instatiation of an AsyncTestCase is allowed.
|
|
+
|
|
+ unittest.TestCase docs guarantee this working, and pytest's unittest
|
|
+ support relies on it.
|
|
+ """
|
|
+ AsyncTestCaseTest()
|
|
+
|
|
|
|
class LeakTest(AsyncTestCase):
|
|
def tearDown(self):
|
|
diff --git a/tornado/testing.py b/tornado/testing.py
|
|
index bdbff87bc3..9455411a6d 100644
|
|
--- a/tornado/testing.py
|
|
+++ b/tornado/testing.py
|
|
@@ -177,7 +177,17 @@ def __init__(self, methodName: str = "runTest") -> None:
|
|
# the test will silently be ignored because nothing will consume
|
|
# the generator. Replace the test method with a wrapper that will
|
|
# make sure it's not an undecorated generator.
|
|
- setattr(self, methodName, _TestMethodWrapper(getattr(self, methodName)))
|
|
+ try:
|
|
+ test_method = getattr(self, methodName)
|
|
+ except AttributeError:
|
|
+ if methodName != "runTest":
|
|
+ # We allow instantiation with no explicit method name
|
|
+ # but not an *incorrect* or missing method name.
|
|
+ raise ValueError(
|
|
+ "no such test method in %s: %s" % (self.__class__, methodName)
|
|
+ )
|
|
+ else:
|
|
+ setattr(self, methodName, _TestMethodWrapper(test_method))
|
|
|
|
# Not used in this class itself, but used by @gen_test
|
|
self._test_generator = None # type: Optional[Union[Generator, Coroutine]]
|