36 lines
1.4 KiB
Diff
36 lines
1.4 KiB
Diff
|
From 6562305928517bbc5b2a4525b8baddb58a510666 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Li Qiang <liqiang6-s@360.cn>
|
||
|
|
Date: Sun, 18 Sep 2016 19:07:11 -0700
|
||
|
|
Subject: [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
In virtio gpu resource create dispatch, if the pixman format is zero
|
||
|
|
it doesn't free the resource object allocated previously. Thus leading
|
||
|
|
a host memory leak issue. This patch avoid this.
|
||
|
|
|
||
|
|
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
|
||
|
|
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
||
|
|
Message-id: 57df486e.8379240a.c3620.ff81@mx.google.com
|
||
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
||
|
|
(cherry picked from commit cb3a0522b694cc5bb6424497b3f828ccd28fd1dd)
|
||
|
|
[BR: CVE-2016-7994 BSC#1003613]
|
||
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
||
|
|
---
|
||
|
|
hw/display/virtio-gpu.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
|
||
|
|
index 7fe6ed8..5b6d17b 100644
|
||
|
|
--- a/hw/display/virtio-gpu.c
|
||
|
|
+++ b/hw/display/virtio-gpu.c
|
||
|
|
@@ -333,6 +333,7 @@ static void virtio_gpu_resource_create_2d(VirtIOGPU *g,
|
||
|
|
qemu_log_mask(LOG_GUEST_ERROR,
|
||
|
|
"%s: host couldn't handle guest format %d\n",
|
||
|
|
__func__, c2d.format);
|
||
|
|
+ g_free(res);
|
||
|
|
cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER;
|
||
|
|
return;
|
||
|
|
}
|