53 lines
2.6 KiB
Diff
53 lines
2.6 KiB
Diff
|
From: Pan Nengyuan <pannengyuan@huawei.com>
|
||
|
|
Date: Tue, 25 Feb 2020 15:55:54 +0800
|
||
|
|
Subject: virtio-crypto: do delete ctrl_vq in virtio_crypto_device_unrealize
|
||
|
|
|
||
|
|
Git-commit: d56e1c8256cb37e68f9b5d98c6cc4e6ca463f1fd
|
||
|
|
|
||
|
|
Similar to other virtio-deivces, ctrl_vq forgot to delete in virtio_crypto_device_unrealize, this patch fix it.
|
||
|
|
This device has aleardy maintained vq pointers. Thus, we use the new virtio_delete_queue function directly to do the cleanup.
|
||
|
|
|
||
|
|
The leak stack:
|
||
|
|
Direct leak of 10752 byte(s) in 3 object(s) allocated from:
|
||
|
|
#0 0x7f4c024b1970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
|
||
|
|
#1 0x7f4c018be49d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
|
||
|
|
#2 0x55a2f8017279 in virtio_add_queue /mnt/sdb/qemu-new/qemu_test/qemu/hw/virtio/virtio.c:2333
|
||
|
|
#3 0x55a2f8057035 in virtio_crypto_device_realize /mnt/sdb/qemu-new/qemu_test/qemu/hw/virtio/virtio-crypto.c:814
|
||
|
|
#4 0x55a2f8005d80 in virtio_device_realize /mnt/sdb/qemu-new/qemu_test/qemu/hw/virtio/virtio.c:3531
|
||
|
|
#5 0x55a2f8497d1b in device_set_realized /mnt/sdb/qemu-new/qemu_test/qemu/hw/core/qdev.c:891
|
||
|
|
#6 0x55a2f8b48595 in property_set_bool /mnt/sdb/qemu-new/qemu_test/qemu/qom/object.c:2238
|
||
|
|
#7 0x55a2f8b54fad in object_property_set_qobject /mnt/sdb/qemu-new/qemu_test/qemu/qom/qom-qobject.c:26
|
||
|
|
#8 0x55a2f8b4de2c in object_property_set_bool /mnt/sdb/qemu-new/qemu_test/qemu/qom/object.c:1390
|
||
|
|
#9 0x55a2f80609c9 in virtio_crypto_pci_realize /mnt/sdb/qemu-new/qemu_test/qemu/hw/virtio/virtio-crypto-pci.c:58
|
||
|
|
|
||
|
|
Reported-by: Euler Robot <euler.robot@huawei.com>
|
||
|
|
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
|
||
|
|
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>
|
||
|
|
Message-Id: <20200225075554.10835-5-pannengyuan@huawei.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
||
|
|
---
|
||
|
|
hw/virtio/virtio-crypto.c | 3 ++-
|
||
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c
|
||
|
|
index 6d42f95a890b7a58f8ba0bc75eae..b2e01fc015133decbe2dc3ee9073 100644
|
||
|
|
--- a/hw/virtio/virtio-crypto.c
|
||
|
|
+++ b/hw/virtio/virtio-crypto.c
|
||
|
|
@@ -831,12 +831,13 @@ static void virtio_crypto_device_unrealize(DeviceState *dev, Error **errp)
|
||
|
|
|
||
|
|
max_queues = vcrypto->multiqueue ? vcrypto->max_queues : 1;
|
||
|
|
for (i = 0; i < max_queues; i++) {
|
||
|
|
- virtio_del_queue(vdev, i);
|
||
|
|
+ virtio_delete_queue(vcrypto->vqs[i].dataq);
|
||
|
|
q = &vcrypto->vqs[i];
|
||
|
|
qemu_bh_delete(q->dataq_bh);
|
||
|
|
}
|
||
|
|
|
||
|
|
g_free(vcrypto->vqs);
|
||
|
|
+ virtio_delete_queue(vcrypto->ctrl_vq);
|
||
|
|
|
||
|
|
virtio_cleanup(vdev);
|
||
|
|
cryptodev_backend_set_used(vcrypto->cryptodev, false);
|