35 lines
1.3 KiB
Diff
35 lines
1.3 KiB
Diff
|
From dacb486f3fda3c43180f919cd8e9febf6016bc00 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Date: Fri, 27 Apr 2018 17:20:02 +0300
|
||
|
|
Subject: [PATCH] migration/block-dirty-bitmap: fix memory leak in
|
||
|
|
dirty_bitmap_load_bits
|
||
|
|
|
||
|
|
Release buf on error path too.
|
||
|
|
|
||
|
|
Bug was introduced in b35ebdf076d697bc "migration: add postcopy
|
||
|
|
migration of dirty bitmaps" with the whole function.
|
||
|
|
|
||
|
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Message-Id: <20180427142002.21930-3-vsementsov@virtuozzo.com>
|
||
|
|
Reviewed-by: Eric Blake <eblake@redhat.com>
|
||
|
|
CC: qemu-stable@nongnu.org
|
||
|
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||
|
|
(cherry picked from commit 16a2227893dc1d5cad78ed376ad1d7e300978fbe)
|
||
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
||
|
|
---
|
||
|
|
migration/block-dirty-bitmap.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
|
||
|
|
index dd04f102d8..8819aabe3a 100644
|
||
|
|
--- a/migration/block-dirty-bitmap.c
|
||
|
|
+++ b/migration/block-dirty-bitmap.c
|
||
|
|
@@ -600,6 +600,7 @@ static int dirty_bitmap_load_bits(QEMUFile *f, DirtyBitmapLoadState *s)
|
||
|
|
ret = qemu_get_buffer(f, buf, buf_size);
|
||
|
|
if (ret != buf_size) {
|
||
|
|
error_report("Failed to read bitmap bits");
|
||
|
|
+ g_free(buf);
|
||
|
|
return -EIO;
|
||
|
|
}
|
||
|
|
|