1f88dea66c
- Updating to Sphinx v3.1.2 in Factory is exposing an issue in qemu doc sources. Fix it docs-fix-trace-docs-build-with-sphinx-3..patch - Fix DoS possibility in ati-vga emulation (CVE-2020-13800 bsc#1172495) ati-vga-check-mm_index-before-recursive-.patch - Fix DoS possibility in Network Block Device (nbd) support infrastructure (CVE-2020-10761 bsc#1172710) nbd-server-Avoid-long-error-message-asse.patch - Fix null pointer dereference possibility (DoS) in MegaRAID SAS 8708EM2 emulation (CVE-2020-13659 bsc#1172386) exec-set-map-length-to-zero-when-returni.patch - Fix OOB access possibility in MegaRAID SAS 8708EM2 emulation (CVE-2020-13362 bsc#1172383) megasas-use-unsigned-type-for-reply_queu.patch - Fix legacy IGD passthrough hw-vfio-pci-quirks-Fix-broken-legacy-IGD.patch - The latest gcc10 available in Factory has the fix for the issue this patch was created to avoid, so drop it build-Work-around-gcc10-bug-by-not-using.patch - Switch to upstream versions of some patches we carry add-enum-cast-to-avoid-gcc10-warning.patch -> golan-Add-explicit-type-casts-for-nodnic.patch Be-explicit-about-fcommon-compiler-direc.patch -> build-Be-explicit-about-fcommon-compiler.patch Do-not-apply-WORKAROUND_CFLAGS-for-host-.patch -> build-Do-not-apply-WORKAROUND_CFLAGS-for.patch Fix-s-directive-argument-is-null-error.patch -> build-Fix-s-directive-argument-is-null-e.patch Workaround-compilation-error-with-gcc-9..patch -> build-Workaround-compilation-error-with-.patch work-around-gcc10-problem-with-zero-leng.patch -> intel-Avoid-spurious-compiler-warning-on.patch - Fix vgabios issue for cirrus graphics emulation, which effectively downgraded it to standard VGA behavior vga-fix-cirrus-bios.patch - Fix OOB access possibility in ES1370 audio device emulation (CVE-2020-13361 bsc#1172384) es1370-check-total-frame-count-against-c.patch OBS-URL: https://build.opensuse.org/request/show/822154 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=553
51 lines
1.8 KiB
Diff
51 lines
1.8 KiB
Diff
From: Prasad J Pandit <pjp@fedoraproject.org>
|
|
Date: Thu, 14 May 2020 00:55:38 +0530
|
|
Subject: megasas: use unsigned type for reply_queue_head and check index
|
|
|
|
Git-commit: f50ab86a2620bd7e8507af865b164655ee921661
|
|
References: bsc#1172383, CVE-2020-13362
|
|
|
|
A guest user may set 'reply_queue_head' field of MegasasState to
|
|
a negative value. Later in 'megasas_lookup_frame' it is used to
|
|
index into s->frames[] array. Use unsigned type to avoid OOB
|
|
access issue.
|
|
|
|
Also check that 'index' value stays within s->frames[] bounds
|
|
through the while() loop in 'megasas_lookup_frame' to avoid OOB
|
|
access.
|
|
|
|
Reported-by: Ren Ding <rding@gatech.edu>
|
|
Reported-by: Hanqing Zhao <hanqing@gatech.edu>
|
|
Reported-by: Alexander Bulekov <alxndr@bu.edu>
|
|
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
|
|
Acked-by: Alexander Bulekov <alxndr@bu.edu>
|
|
Message-Id: <20200513192540.1583887-2-ppandit@redhat.com>
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
|
---
|
|
hw/scsi/megasas.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
|
|
index af18c88b656e7f5fa299c5f0dda1..6ce598cd6908b5223470b506c481 100644
|
|
--- a/hw/scsi/megasas.c
|
|
+++ b/hw/scsi/megasas.c
|
|
@@ -112,7 +112,7 @@ typedef struct MegasasState {
|
|
uint64_t reply_queue_pa;
|
|
void *reply_queue;
|
|
int reply_queue_len;
|
|
- int reply_queue_head;
|
|
+ uint16_t reply_queue_head;
|
|
int reply_queue_tail;
|
|
uint64_t consumer_pa;
|
|
uint64_t producer_pa;
|
|
@@ -445,7 +445,7 @@ static MegasasCmd *megasas_lookup_frame(MegasasState *s,
|
|
|
|
index = s->reply_queue_head;
|
|
|
|
- while (num < s->fw_cmds) {
|
|
+ while (num < s->fw_cmds && index < MEGASAS_MAX_FRAMES) {
|
|
if (s->frames[index].pa && s->frames[index].pa == frame) {
|
|
cmd = &s->frames[index];
|
|
break;
|