eb1e0a8392
Include two recent fixes from Alex Graf. OBS-URL: https://build.opensuse.org/request/show/511335 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=349
55 lines
2.2 KiB
Diff
55 lines
2.2 KiB
Diff
From ea61b5439c77d6fdeb62a04c39affa534b09fcdd Mon Sep 17 00:00:00 2001
|
|
From: Alexander Graf <agraf@suse.de>
|
|
Date: Wed, 12 Jul 2017 14:43:45 +0200
|
|
Subject: [PATCH] vnc: Set default kbd delay to 10ms
|
|
|
|
The current VNC default keyboard delay is 1ms. With that we're constantly
|
|
typing faster than the guest receives keyboard events from an XHCI attached
|
|
USB HID device.
|
|
|
|
The default keyboard delay time in the input layer however is 10ms. I don't know
|
|
how that number came to be, but empirical tests on some OpenQA driven ARM
|
|
systems show that 10ms really is a reasonable default number for the delay.
|
|
|
|
This patch moves the VNC delay also to 10ms. That way our default is much
|
|
safer (good!) and also consistent with the input layer default (also good!).
|
|
|
|
Signed-off-by: Alexander Graf <agraf@suse.de>
|
|
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
|
|
Message-id: 1499863425-103133-1-git-send-email-agraf@suse.de
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
(cherry picked from commit d3b0db6dfea6b3a9ee0d96aceb796bdcafa84314)
|
|
[BR: BSC#1031692]
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
|
---
|
|
qemu-options.hx | 2 +-
|
|
ui/vnc.c | 2 +-
|
|
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/qemu-options.hx b/qemu-options.hx
|
|
index 4712277d7c..ab7e32a4a0 100644
|
|
--- a/qemu-options.hx
|
|
+++ b/qemu-options.hx
|
|
@@ -1491,7 +1491,7 @@ spec but is traditional QEMU behavior.
|
|
@item key-delay-ms
|
|
|
|
Set keyboard delay, for key down and key up events, in milliseconds.
|
|
-Default is 1. Keyboards are low-bandwidth devices, so this slowdown
|
|
+Default is 10. Keyboards are low-bandwidth devices, so this slowdown
|
|
can help the device and guest to keep up and not lose events in case
|
|
events are arriving in bulk. Possible causes for the latter are flaky
|
|
network connections, or scripts for automated testing.
|
|
diff --git a/ui/vnc.c b/ui/vnc.c
|
|
index 51d6f2353f..3528d50c8a 100644
|
|
--- a/ui/vnc.c
|
|
+++ b/ui/vnc.c
|
|
@@ -3884,7 +3884,7 @@ void vnc_display_open(const char *id, Error **errp)
|
|
}
|
|
|
|
lock_key_sync = qemu_opt_get_bool(opts, "lock-key-sync", true);
|
|
- key_delay_ms = qemu_opt_get_number(opts, "key-delay-ms", 1);
|
|
+ key_delay_ms = qemu_opt_get_number(opts, "key-delay-ms", 10);
|
|
sasl = qemu_opt_get_bool(opts, "sasl", false);
|
|
#ifndef CONFIG_VNC_SASL
|
|
if (sasl) {
|