d55739b786
- qemu: virtio-net: heap use-after-free in virtio_net_receive_rcu (bsc#1189938 CVE-2021-3748) solved by virtio-net-fix-use-after-unmap-free-for-.patch - kvm,qemu: out-of-bounds write in UAS (USB Attached SCSI) device emulation (bsc#1189702 CVE-2021-3713) * Patches added: uas-add-stream-number-sanity-checks.patch OBS-URL: https://build.opensuse.org/request/show/927617 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=676
62 lines
2.0 KiB
Diff
62 lines
2.0 KiB
Diff
From: Gerd Hoffmann <kraxel@redhat.com>
|
|
Date: Wed, 18 Aug 2021 14:05:05 +0200
|
|
Subject: uas: add stream number sanity checks.
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Git-commit: 13b250b12ad3c59114a6a17d59caf073ce45b33a
|
|
References: bsc#1189702 CVE-2021-3713
|
|
|
|
The device uses the guest-supplied stream number unchecked, which can
|
|
lead to guest-triggered out-of-band access to the UASDevice->data3 and
|
|
UASDevice->status3 fields. Add the missing checks.
|
|
|
|
Fixes: CVE-2021-3713
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
Reported-by: Chen Zhe <chenzhe@huawei.com>
|
|
Reported-by: Tan Jingguo <tanjingguo@huawei.com>
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
Message-Id: <20210818120505.1258262-2-kraxel@redhat.com>
|
|
Signed-off-by: Jose R Ziviani <jose.ziviani@suse.com>
|
|
---
|
|
hw/usb/dev-uas.c | 11 +++++++++++
|
|
1 file changed, 11 insertions(+)
|
|
|
|
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
|
|
index 263056231c794735c29584e821a8..f6309a5ebfdcc84f81945dd04be0 100644
|
|
--- a/hw/usb/dev-uas.c
|
|
+++ b/hw/usb/dev-uas.c
|
|
@@ -840,6 +840,9 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
|
|
}
|
|
break;
|
|
case UAS_PIPE_ID_STATUS:
|
|
+ if (p->stream > UAS_MAX_STREAMS) {
|
|
+ goto err_stream;
|
|
+ }
|
|
if (p->stream) {
|
|
QTAILQ_FOREACH(st, &uas->results, next) {
|
|
if (st->stream == p->stream) {
|
|
@@ -867,6 +870,9 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
|
|
break;
|
|
case UAS_PIPE_ID_DATA_IN:
|
|
case UAS_PIPE_ID_DATA_OUT:
|
|
+ if (p->stream > UAS_MAX_STREAMS) {
|
|
+ goto err_stream;
|
|
+ }
|
|
if (p->stream) {
|
|
req = usb_uas_find_request(uas, p->stream);
|
|
} else {
|
|
@@ -902,6 +908,11 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
|
|
p->status = USB_RET_STALL;
|
|
break;
|
|
}
|
|
+
|
|
+err_stream:
|
|
+ error_report("%s: invalid stream %d", __func__, p->stream);
|
|
+ p->status = USB_RET_STALL;
|
|
+ return;
|
|
}
|
|
|
|
static void usb_uas_unrealize(USBDevice *dev)
|