3d5fb0946f
for update_git.sh OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=62
126 lines
4.4 KiB
Diff
126 lines
4.4 KiB
Diff
From dca5711f3a271a3a0f41207e03f7bf5c7c24d08f Mon Sep 17 00:00:00 2001
|
|
From: Ulrich Hecht <uli@suse.de>
|
|
Date: Tue, 14 Apr 2009 16:37:42 +0200
|
|
Subject: [PATCH] qemu-img-vmdk-scsi
|
|
|
|
Support creation of SCSI VMDK images in qemu-img.
|
|
|
|
Signed-off-by: Ulrich Hecht <uli@suse.de>
|
|
---
|
|
block.c | 5 ++++-
|
|
block/vmdk.c | 12 ++++++++++--
|
|
block_int.h | 2 ++
|
|
qemu-img.c | 8 +++++++-
|
|
4 files changed, 23 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/block.c b/block.c
|
|
index d015887..4b9f81d 100644
|
|
--- a/block.c
|
|
+++ b/block.c
|
|
@@ -3151,7 +3151,7 @@ int bdrv_img_create(const char *filename, const char *fmt,
|
|
char *options, uint64_t img_size, int flags)
|
|
{
|
|
QEMUOptionParameter *param = NULL, *create_options = NULL;
|
|
- QEMUOptionParameter *backing_fmt, *backing_file, *size;
|
|
+ QEMUOptionParameter *backing_fmt, *backing_file, *size, *scsi;
|
|
BlockDriverState *bs = NULL;
|
|
BlockDriver *drv, *proto_drv;
|
|
BlockDriver *backing_drv = NULL;
|
|
@@ -3261,6 +3261,9 @@ int bdrv_img_create(const char *filename, const char *fmt,
|
|
|
|
printf("Formatting '%s', fmt=%s ", filename, fmt);
|
|
print_option_parameters(param);
|
|
+ scsi = get_option_parameter(param, BLOCK_OPT_SCSI);
|
|
+ if (scsi && scsi->value.n)
|
|
+ printf(", SCSI");
|
|
puts("");
|
|
|
|
ret = bdrv_create(drv, filename, param);
|
|
diff --git a/block/vmdk.c b/block/vmdk.c
|
|
index f544159..2b9531d 100644
|
|
--- a/block/vmdk.c
|
|
+++ b/block/vmdk.c
|
|
@@ -1375,7 +1375,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
|
|
"ddb.geometry.cylinders = \"%" PRId64 "\"\n"
|
|
"ddb.geometry.heads = \"16\"\n"
|
|
"ddb.geometry.sectors = \"63\"\n"
|
|
- "ddb.adapterType = \"ide\"\n";
|
|
+ "ddb.adapterType = \"%s\"\n";
|
|
|
|
if (filename_decompose(filename, path, prefix, postfix, PATH_MAX)) {
|
|
return -EINVAL;
|
|
@@ -1390,6 +1390,8 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
|
|
flags |= options->value.n ? BLOCK_FLAG_COMPAT6 : 0;
|
|
} else if (!strcmp(options->name, BLOCK_OPT_SUBFMT)) {
|
|
fmt = options->value.s;
|
|
+ } else if (!strcmp(options->name, BLOCK_OPT_SCSI)) {
|
|
+ flags |= options->value.n ? BLOCK_FLAG_SCSI: 0;
|
|
}
|
|
options++;
|
|
}
|
|
@@ -1480,7 +1482,8 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
|
|
parent_desc_line,
|
|
ext_desc_lines,
|
|
(flags & BLOCK_FLAG_COMPAT6 ? 6 : 4),
|
|
- total_size / (int64_t)(63 * 16 * 512));
|
|
+ total_size / (int64_t)(63 * 16 * 512),
|
|
+ flags & BLOCK_FLAG_SCSI ? "lsilogic" : "ide");
|
|
if (split || flat) {
|
|
fd = open(
|
|
filename,
|
|
@@ -1583,6 +1586,11 @@ static QEMUOptionParameter vmdk_create_options[] = {
|
|
"VMDK flat extent format, can be one of "
|
|
"{monolithicSparse (default) | monolithicFlat | twoGbMaxExtentSparse | twoGbMaxExtentFlat | streamOptimized} "
|
|
},
|
|
+ {
|
|
+ .name = BLOCK_OPT_SCSI,
|
|
+ .type = OPT_FLAG,
|
|
+ .help = "SCSI image"
|
|
+ },
|
|
{ NULL }
|
|
};
|
|
|
|
diff --git a/block_int.h b/block_int.h
|
|
index 77c0187..b79ab4b 100644
|
|
--- a/block_int.h
|
|
+++ b/block_int.h
|
|
@@ -33,10 +33,12 @@
|
|
|
|
#define BLOCK_FLAG_ENCRYPT 1
|
|
#define BLOCK_FLAG_COMPAT6 4
|
|
+#define BLOCK_FLAG_SCSI 8
|
|
|
|
#define BLOCK_OPT_SIZE "size"
|
|
#define BLOCK_OPT_ENCRYPT "encryption"
|
|
#define BLOCK_OPT_COMPAT6 "compat6"
|
|
+#define BLOCK_OPT_SCSI "scsi"
|
|
#define BLOCK_OPT_BACKING_FILE "backing_file"
|
|
#define BLOCK_OPT_BACKING_FMT "backing_fmt"
|
|
#define BLOCK_OPT_CLUSTER_SIZE "cluster_size"
|
|
diff --git a/qemu-img.c b/qemu-img.c
|
|
index 01cc0d3..21f3544 100644
|
|
--- a/qemu-img.c
|
|
+++ b/qemu-img.c
|
|
@@ -661,7 +661,7 @@ static int img_convert(int argc, char **argv)
|
|
const uint8_t *buf1;
|
|
BlockDriverInfo bdi;
|
|
QEMUOptionParameter *param = NULL, *create_options = NULL;
|
|
- QEMUOptionParameter *out_baseimg_param;
|
|
+ QEMUOptionParameter *out_baseimg_param, *scsi;
|
|
char *options = NULL;
|
|
const char *snapshot_name = NULL;
|
|
float local_progress;
|
|
@@ -852,6 +852,12 @@ static int img_convert(int argc, char **argv)
|
|
}
|
|
}
|
|
|
|
+ if ((scsi = get_option_parameter(param, BLOCK_OPT_SCSI)) && scsi->value.n && strcmp(drv->format_name, "vmdk")) {
|
|
+ error_report("SCSI devices not supported for this file format");
|
|
+ ret = -1;
|
|
+ goto out;
|
|
+ }
|
|
+
|
|
/* Create the new image */
|
|
ret = bdrv_create(drv, out_filename, param);
|
|
if (ret < 0) {
|