b29d656ff3
Fix buffer overflow in console VT100 emulation (bnc#777084 / CVE-2012-3515) OBS-URL: https://build.opensuse.org/request/show/132617 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=106
127 lines
3.9 KiB
Diff
127 lines
3.9 KiB
Diff
From 0a57a3cd95bf6b0a3d4764129981f0938dbfaed3 Mon Sep 17 00:00:00 2001
|
|
From: Ian Campbell <ian.campbell@citrix.com>
|
|
Date: Wed, 5 Sep 2012 12:19:51 +0200
|
|
Subject: [PATCH] console: bounds check whenever changing the cursor due to an
|
|
escape code
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
This is XSA-17 / CVE-2012-3515
|
|
|
|
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
|
|
[AF: fixed Coding Style; bnc#777084]
|
|
Signed-off-by: Andreas Färber <afaerber@suse.de>
|
|
---
|
|
console.c | 58 +++++++++++++++++++++++++++++-----------------------------
|
|
1 files changed, 29 insertions(+), 29 deletions(-)
|
|
|
|
diff --git a/console.c b/console.c
|
|
index f5e8814..7fa6516 100644
|
|
--- a/console.c
|
|
+++ b/console.c
|
|
@@ -850,6 +850,26 @@ static void console_clear_xy(TextConsole *s, int x, int y)
|
|
update_xy(s, x, y);
|
|
}
|
|
|
|
+/* set cursor, checking bounds */
|
|
+static void set_cursor(TextConsole *s, int x, int y)
|
|
+{
|
|
+ if (x < 0) {
|
|
+ x = 0;
|
|
+ }
|
|
+ if (y < 0) {
|
|
+ y = 0;
|
|
+ }
|
|
+ if (y >= s->height) {
|
|
+ y = s->height - 1;
|
|
+ }
|
|
+ if (x >= s->width) {
|
|
+ x = s->width - 1;
|
|
+ }
|
|
+
|
|
+ s->x = x;
|
|
+ s->y = y;
|
|
+}
|
|
+
|
|
static void console_putchar(TextConsole *s, int ch)
|
|
{
|
|
TextCell *c;
|
|
@@ -921,7 +941,9 @@ static void console_putchar(TextConsole *s, int ch)
|
|
s->esc_params[s->nb_esc_params] * 10 + ch - '0';
|
|
}
|
|
} else {
|
|
- s->nb_esc_params++;
|
|
+ if (s->nb_esc_params < MAX_ESC_PARAMS) {
|
|
+ s->nb_esc_params++;
|
|
+ }
|
|
if (ch == ';')
|
|
break;
|
|
#ifdef DEBUG_CONSOLE
|
|
@@ -935,59 +957,37 @@ static void console_putchar(TextConsole *s, int ch)
|
|
if (s->esc_params[0] == 0) {
|
|
s->esc_params[0] = 1;
|
|
}
|
|
- s->y -= s->esc_params[0];
|
|
- if (s->y < 0) {
|
|
- s->y = 0;
|
|
- }
|
|
+ set_cursor(s, s->x, s->y - s->esc_params[0]);
|
|
break;
|
|
case 'B':
|
|
/* move cursor down */
|
|
if (s->esc_params[0] == 0) {
|
|
s->esc_params[0] = 1;
|
|
}
|
|
- s->y += s->esc_params[0];
|
|
- if (s->y >= s->height) {
|
|
- s->y = s->height - 1;
|
|
- }
|
|
+ set_cursor(s, s->x, s->y + s->esc_params[0]);
|
|
break;
|
|
case 'C':
|
|
/* move cursor right */
|
|
if (s->esc_params[0] == 0) {
|
|
s->esc_params[0] = 1;
|
|
}
|
|
- s->x += s->esc_params[0];
|
|
- if (s->x >= s->width) {
|
|
- s->x = s->width - 1;
|
|
- }
|
|
+ set_cursor(s, s->x + s->esc_params[0], s->y);
|
|
break;
|
|
case 'D':
|
|
/* move cursor left */
|
|
if (s->esc_params[0] == 0) {
|
|
s->esc_params[0] = 1;
|
|
}
|
|
- s->x -= s->esc_params[0];
|
|
- if (s->x < 0) {
|
|
- s->x = 0;
|
|
- }
|
|
+ set_cursor(s, s->x - s->esc_params[0], s->y);
|
|
break;
|
|
case 'G':
|
|
/* move cursor to column */
|
|
- s->x = s->esc_params[0] - 1;
|
|
- if (s->x < 0) {
|
|
- s->x = 0;
|
|
- }
|
|
+ set_cursor(s, s->esc_params[0] - 1, s->y);
|
|
break;
|
|
case 'f':
|
|
case 'H':
|
|
/* move cursor to row, column */
|
|
- s->x = s->esc_params[1] - 1;
|
|
- if (s->x < 0) {
|
|
- s->x = 0;
|
|
- }
|
|
- s->y = s->esc_params[0] - 1;
|
|
- if (s->y < 0) {
|
|
- s->y = 0;
|
|
- }
|
|
+ set_cursor(s, s->esc_params[1] - 1, s->esc_params[0] - 1);
|
|
break;
|
|
case 'J':
|
|
switch (s->esc_params[0]) {
|