Dirk Mueller
680daa4eb0
* Flake8 / Stop leaking filedescriptors
- Update rpmlint-tests:
* Stop leaking filedescriptors
* Address various deprecation warnings
* Avoid leaking fds and further Python 3.x porting
- drop sourced-dirs.diff, fix-shared-library-matching.diff,
suse-python-abi-check.diff, add-check-for-tmpfiles-created-at-r.diff: obsolete
ignore-readelf-ar-error.diff, remove-ghostfile-checks.diff
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=499
45 lines
2.0 KiB
Diff
45 lines
2.0 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:40 +0200
|
|
Subject: [PATCH] invalid-filerequires.diff
|
|
|
|
===================================================================
|
|
---
|
|
TagsCheck.py | 10 ++++++++++
|
|
1 file changed, 10 insertions(+)
|
|
|
|
Index: rpmlint-rpmlint-1.10/TagsCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.10.orig/TagsCheck.py
|
|
+++ rpmlint-rpmlint-1.10/TagsCheck.py
|
|
@@ -452,6 +452,7 @@ invalid_version_regex = re.compile(r'([0
|
|
# () are here for grouping purpose in the regexp
|
|
forbidden_words_regex = re.compile(r'(%s)' % Config.getOption('ForbiddenWords'), re.IGNORECASE)
|
|
valid_buildhost_regex = re.compile(Config.getOption('ValidBuildHost'))
|
|
+valid_filedep_regex = re.compile(r'(?:/s?bin/|^/etc/|^/usr/lib/sendmail$)')
|
|
use_epoch = Config.getOption('UseEpoch', False)
|
|
use_utf8 = Config.getOption('UseUTF8', Config.USEUTF8_DEFAULT)
|
|
max_line_len = Config.getOption('MaxLineLength', 79)
|
|
@@ -632,6 +633,9 @@ class TagsCheck(AbstractCheck.AbstractCh
|
|
if d[0].startswith('/usr/local/'):
|
|
printError(pkg, 'invalid-dependency', d[0])
|
|
|
|
+ if d[0].startswith('/') and not valid_filedep_regex.search(d[0]):
|
|
+ printWarning(pkg, 'invalid-filepath-dependency', d[0])
|
|
+
|
|
if is_source:
|
|
if lib_devel_number_regex.search(d[0]):
|
|
printError(pkg, 'invalid-build-requires', d[0])
|
|
@@ -1181,6 +1185,12 @@ unneeded explicit Requires: tags.''',
|
|
'''This package provides 2 times the same capacity. It should only provide it
|
|
once.''',
|
|
|
|
+'invalid-filepath-dependency',
|
|
+'''A package has a file or path based dependency that is not resolveable for
|
|
+package solvers because it is not in the whitelist for path based dependencies
|
|
+and therefore not available in repository metadata. Please use a symbolic requires
|
|
+instead or require a file in bin or /etc.''',
|
|
+
|
|
'tag-not-utf8',
|
|
'''The character encoding of the value of this tag is not UTF-8.''',
|
|
|