Dirk Mueller
1cdbc13b57
* test: Skip fedoradev GPG checks at least for now * test: Refresh fedora* packages on image build * test: Use assertEqual where appropriate, thanks to flake8/hacking * test: Update fedora24 config to fedora26, run it on Travis * Add a new test for tmpfiles.d snippets in the /etc/ tree. * Add new tests for systemd units and udev rules in /etc/ tree * test: Disable hacking for now until it's flake8 3.4+ compatible * test: Set up flake8-bugbear, enable it in fedoradev container * rpmlint: Avoid unused loop control variable * ZipCheck: Add TODO * *: Avoid mutable argument defaults * Be aware of -debugsource packages * rpmdiff: Fix unused variable from previous commit * rpmdiff: Support soft dependencies * BinariesCheck, FilesCheck: Ignore various .build-id dirs * Add python3-devel and rpm-build to fedoradev container to provoke some issues * BinariesCheck: Popen env consistency fix * Pkg.getstatusoutput: Set LC_ALL for all Popens, defaulting to C * rpmlint: Fix checking specfile from stdin * test.sh: Extract rpmlint command to run_rpmlint * Revert "Remove unused spec_lines check_spec argument" * BinariesCheck: Trivial cleanups * travis: Run make install too * FilesCheck: Allow multiple bytecode magic values per Python version * tests: Make output test tools easier to reuse * FilesCheck: hg.python.org -> github.com/python * Pkg: Return vendor and distribution as unicode strings * FilesCheck: Add Python 3.7 bytecode magic value * Pkg.b2s: Add some more test cases OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=482
43 lines
2.0 KiB
Diff
43 lines
2.0 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:38 +0200
|
|
Subject: [PATCH] docdata-examples.diff
|
|
|
|
===================================================================
|
|
---
|
|
FilesCheck.py | 8 ++++++--
|
|
1 file changed, 6 insertions(+), 2 deletions(-)
|
|
|
|
Index: rpmlint-rpmlint-1.10/FilesCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.10.orig/FilesCheck.py
|
|
+++ rpmlint-rpmlint-1.10/FilesCheck.py
|
|
@@ -189,6 +189,7 @@ bin_regex = re.compile(r'^/(?:usr/(?:s?b
|
|
includefile_regex = re.compile(r'\.(c|h)(pp|xx)?$', re.IGNORECASE)
|
|
develfile_regex = re.compile(r'\.(a|cmxa?|mli?|gir)$')
|
|
buildconfigfile_regex = re.compile(r'(\.pc|/bin/.+-config)$')
|
|
+docdir_examples_regex = re.compile('^/usr/(?:share/doc/packages|lib(?:64))/[^/]+/(?:example|demo|script|contrib)')
|
|
# room for improvement with catching more -R, but also for false positives...
|
|
buildconfig_rpath_regex = re.compile(r'(?:-rpath|Wl,-R)\b')
|
|
sofile_regex = re.compile(r'/lib(64)?/(.+/)?lib[^/]+\.so$')
|
|
@@ -785,7 +786,7 @@ class FilesCheck(AbstractCheck.AbstractC
|
|
includefile_regex.search(f) or \
|
|
develfile_regex.search(f) or \
|
|
logrotate_regex.search(f)
|
|
- if nonexec_file:
|
|
+ if nonexec_file and not docdir_examples_regex.search(f):
|
|
printWarning(pkg, 'spurious-executable-perm', f)
|
|
elif f.startswith('/etc/') and f not in config_files and \
|
|
f not in ghost_files:
|
|
@@ -1154,7 +1155,10 @@ included in your package.''',
|
|
'spurious-executable-perm',
|
|
'''The file is installed with executable permissions, but was identified as one
|
|
that probably should not be executable. Verify if the executable bits are
|
|
-desired, and remove if not.''',
|
|
+desired, and remove if not.
|
|
+NOTE: example scripts should be packaged under %docdir/examples, which will avoid
|
|
+this warning.
|
|
+''',
|
|
|
|
'world-writable',
|
|
'''A file or directory in the package is installed with world writable
|